Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ignore_status #161

Merged
merged 2 commits into from
Jul 11, 2022
Merged

Add ignore_status #161

merged 2 commits into from
Jul 11, 2022

Conversation

sepich
Copy link
Contributor

@sepich sepich commented Jun 27, 2022

Fix for: #160
It seems this option would look better inside of http_client_config, but I do not see easy way to extend HTTPClientConfig (because it has own UnmarshalJSON())

SuperQ
SuperQ reviewed Jul 2, 2022
View reviewed changes
Copy link
Contributor

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if instead of this, we add something more like the blackbox_exporter's "allowed status codes". This way you can be more explicit about what non-2xx codes are allowed.

sepich added 2 commits July 4, 2022 11:38
@sepich
Add ignore_status
1dacd46 
Signed-off-by: Alexander Ryabov <alexander.ryabov@jetbrains.com>
@sepich
Use valid_status_codes slice
d4f81a9 
Signed-off-by: Alexander Ryabov <alexander.ryabov@jetbrains.com>
@sepich
Copy link
Contributor Author

sepich commented Jul 4, 2022

Yeah, that would also work for us. Fixed.

SuperQ
SuperQ approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperQ SuperQ requested a review from rustycl0ck July 4, 2022 10:40
rustycl0ck
rustycl0ck approved these changes Jul 10, 2022
View reviewed changes
Copy link
Member

@rustycl0ck rustycl0ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR.

@rustycl0ck rustycl0ck merged commit f8ddc2f into prometheus-community:master Jul 11, 2022
SuperQ added a commit that referenced this pull request Jul 11, 2022
@SuperQ
Release v0.5.0
59477d6 
Breaking Change:

The exporter config file format has changed. It now supports multiple modules
to scrape different endpoints.

* [FEATURE] Support custom valuetype #145
* [FEATURE] Support modules configuration #146
* [FEATURE] Accept non-2xx HTTP status #161

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ SuperQ mentioned this pull request Jul 11, 2022
Merged
SuperQ added a commit that referenced this pull request Jul 11, 2022
@SuperQ
Release v0.5.0 (#166)
2c1ca88 
Breaking Change:

The exporter config file format has changed. It now supports multiple modules
to scrape different endpoints.

* [FEATURE] Support custom valuetype #145
* [FEATURE] Support modules configuration #146
* [FEATURE] Accept non-2xx HTTP status #161

Signed-off-by: SuperQ <superq@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rustycl0ck rustycl0ck rustycl0ck approved these changes

@SuperQ SuperQ SuperQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sepich @rustycl0ck @SuperQ