Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

Adds Proxy Protocol Support #367

Merged
merged 2 commits into from
May 27, 2021
Merged

Adds Proxy Protocol Support #367

merged 2 commits into from
May 27, 2021

Conversation

danehans
Copy link
Contributor

Adds support for managing the proxy protocol for AWS Classic load balancers.

Requires: #366

Fixes: #49

xref: https://projectcontour.io/guides/proxy-proto/

@danehans danehans requested a review from a team as a code owner May 21, 2021 03:52
@danehans danehans requested review from stevesloka and skriss and removed request for a team May 21, 2021 03:52
@danehans
Copy link
Contributor Author

Since this PR requires #366, filter your review to this commit.

@codecov
Copy link

codecov bot commented May 21, 2021 •
edited
Loading

Codecov Report

Merging #367 (1844057) into main (a217614) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

❗ Current head 1844057 differs from pull request most recent head bbfec50. Consider uploading reports for the commit bbfec50 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #367      +/-   ##
==========================================
- Coverage   58.17%   58.07%   -0.10%     
==========================================
  Files          19       19              
  Lines        1805     1801       -4     
==========================================
- Hits         1050     1046       -4     
  Misses        728      728              
  Partials       27       27
Impacted Files Coverage Δ
internal/objects/service/service.go 50.88% <100.00%> (-1.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a217614...bbfec50. Read the comment docs.

@danehans danehans self-assigned this May 21, 2021
@danehans danehans added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 21, 2021
@danehans danehans added this to the 1.16.0 milestone May 21, 2021
@youngnick
Copy link
Member

I've just merged #366, this needs a rebase now @danehans.

@danehans
Adds Proxy Protocol Support
e4e5cad 
Signed-off-by: Daneyon Hansen <daneyonhansen@gmail.com>
@danehans
Adds an LB Provider Type Check
bbfec50 
Signed-off-by: Daneyon Hansen <daneyonhansen@gmail.com>
@danehans danehans modified the milestones: 1.16.0, 1.17.0 May 27, 2021
skriss
skriss approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have a refactor in mind for the test code to check each service for an exact set of annotations, but I'm happy to submit that in a follow-up.

@skriss skriss merged commit 85ba632 into projectcontour:main May 27, 2021
@danehans danehans mentioned this pull request Jun 2, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@youngnick youngnick youngnick approved these changes

@skriss skriss skriss approved these changes

@AskAlice AskAlice AskAlice approved these changes

@stevesloka stevesloka Awaiting requested review from stevesloka

Assignees

@danehans danehans

Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

Add Proxy Protocol Support
4 participants
@danehans @youngnick @AskAlice @skriss