Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

Extend NetworkPublishing API #159

Closed
danehans opened this issue Dec 10, 2020 · 3 comments
Closed

Extend NetworkPublishing API #159

danehans opened this issue Dec 10, 2020 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@danehans
Copy link
Contributor

Extend the NetworkPublishing API to support the following use cases:

  • Set the awsLbBackendProtoAnnotation: tcp annotation only if the provider of LoadBalancerServicePublishingType is AWS.
  • Add support to NodePortServicePublishingType to specify: 1) auto (default) or manual port allocation. If manual, provide fields to specify the desired http/https nodePorts (30080 default for http and 30443 default for https).
@danehans danehans added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 10, 2020
@danehans
Copy link
Contributor Author

xref: #151
xref: #152

@stevesloka
Copy link
Member

Support to NodePortServicePublishingType to specify: 1) auto (default) or manual port allocation. If manual, provide fields to specify the desired http/https nodePorts (30080 default for http and 30443 default for https).

This implies the default by choosing option #1 is ports 30080 & 30443. Just want to confirm that's the thought, in my head, auto implies that k8s is specifying the ports which is the default unless you specify the ports (e.g. manual).

@danehans
Copy link
Contributor Author

danehans commented Jun 2, 2021

Fixed by:

@danehans danehans closed this as completed Jun 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants