Adds Support for Managing AWS Load Balancer Type #366
Conversation
danehans
requested review from
skriss and
youngnick
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## main #366 +/- ##
==========================================
+ Coverage 55.66% 55.91% +0.24%
==========================================
Files 19 19
Lines 1775 1785 +10
==========================================
+ Hits 988 998 +10
Misses 761 761
Partials 26 26
Continue to review full report at Codecov.
|
danehans
added
the
release-note
There was a problem hiding this comment.
@danehans I checked this, looks good. Only thing that I believe has to change is now aws-load-balancer-backend-protol annotation is handled, as it should be implemented only if Classic load balancer is used: https://projectcontour.io/guides/deploy-aws-nlb/
internal/objects/service/service.go
Outdated
| if provider == operatorv1alpha1.AWSLoadBalancerProvider && | ||
| contour.Spec.NetworkPublishing.Envoy.Type == operatorv1alpha1.LoadBalancerServicePublishingType && | ||
| contour.Spec.NetworkPublishing.Envoy.LoadBalancer.ProviderParameters.Type == operatorv1alpha1.AWSLoadBalancerProvider && | ||
| contour.Spec.NetworkPublishing.Envoy.LoadBalancer.ProviderParameters.AWS != nil && |
There was a problem hiding this comment.
Would this not be obsolete, since next condition already includes != nil condition in it?
There was a problem hiding this comment.
AWS provider params is an optional field. Checking to make sure it's not nil and the param type is NLB.
Signed-off-by: Daneyon Hansen <daneyonhansen@gmail.com>
Signed-off-by: Daneyon Hansen <daneyonhansen@gmail.com>
|
@BostjanBozic commit |
|
@danehans LGTM |
Extends and implements the Contour API for managing AWS load balancer types. Supports Classic ELB and NLB.
Fixes #187
xref: #336
cc: @BostjanBozic