Consolidate error types #7916

kpschoedel · 2021-06-25T17:18:12Z

Problem

CHIP currently has CHIP_ERROR, INET_ERROR, BLE_ERROR,
ASN1_ERROR, System::Error. Since they're all integers underneath,
there is no type checking, and existing code routinely treats them
as interchangeable. There is also existing code that uses int and
int32_t. Each also has a …_NO_ERROR code which is independently
configurable, but existing code assumes they are equal, and there is
exising code that assumes the C convention that the value is 0.

Change overview

Fixes #7688 Unify chip errors

This change is largely a mechanical replacement of type and some error
code names, with a few cleanups of weak typing.

Consolidated error types to one, CHIP_ERROR.

Removed configurability of CHIP_NO_ERROR; it must be 0.

Added CHIP_ERROR_FORMAT to replace hardcoded PRI…32 in printf()
format strings.

Added CHIP_ERROR_SENTINEL to replace the use of CHIP_ERROR_MAX as a
sentinel.

Renamed or consolidated the following errors, which have the same
meaning. Merely similar codes are left alone. This change contains
compatibility defintitions to avoid breaking PRs in flight, which
will be removed in a followup.

before	after
ASN1_ERROR	CHIP_ERROR
ASN1_NO_ERROR	CHIP_NO_ERROR
BLE_ERROR	CHIP_ERROR
BLE_NO_ERROR	CHIP_NO_ERROR
BLE_ERROR_BAD_ARGS	CHIP_ERROR_INVALID_ARGUMENT
BLE_ERROR_INCORRECT_STATE	CHIP_ERROR_INCORRECT_STATE
BLE_ERROR_MESSAGE_INCOMPLETE	CHIP_ERROR_MESSAGE_INCOMPLETE
BLE_ERROR_NOT_IMPLEMENTED	CHIP_ERROR_NOT_IMPLEMENTED
BLE_ERROR_NO_ENDPOINTS	CHIP_ERROR_ENDPOINT_POOL_FULL
BLE_ERROR_NO_MEMORY	CHIP_ERROR_NO_MEMORY
BLE_ERROR_OUTBOUND_MESSAGE_TOO_BIG	CHIP_ERROR_OUTBOUND_MESSAGE_TOO_BIG
BLE_ERROR_RECEIVED_MESSAGE_TOO_BIG	CHIP_ERROR_INBOUND_MESSAGE_TOO_BIG
CHIP_SYSTEM_NO_ERROR	CHIP_NO_ERROR
CHIP_SYSTEM_ERROR_ACCESS_DENIED	CHIP_ERROR_ACCESS_DENIED
CHIP_SYSTEM_ERROR_BAD_ARGS	CHIP_ERROR_INVALID_ARGUMENT
CHIP_SYSTEM_ERROR_NOT_SUPPORTED	CHIP_ERROR_UNSUPPORTED_CHIP_FEATURE
CHIP_SYSTEM_ERROR_NO_MEMORY	CHIP_ERROR_NO_MEMORY
CHIP_SYSTEM_ERROR_REAL_TIME_NOT_SYNCED	CHIP_ERROR_REAL_TIME_NOT_SYNCED
CHIP_SYSTEM_ERROR_UNEXPECTED_EVENT	CHIP_ERROR_UNEXPECTED_EVENT
CHIP_SYSTEM_ERROR_UNEXPECTED_STATE	CHIP_ERROR_INCORRECT_STATE
INET_ERROR	CHIP_ERROR
INET_NO_ERROR	CHIP_NO_ERROR
INET_ERROR_BAD_ARGS	CHIP_ERROR_INVALID_ARGUMENT
INET_ERROR_INBOUND_MESSAGE_TOO_BIG	CHIP_ERROR_INBOUND_MESSAGE_TOO_BIG
INET_ERROR_INCORRECT_STATE	CHIP_ERROR_INCORRECT_STATE
INET_ERROR_MESSAGE_TOO_LONG	CHIP_ERROR_MESSAGE_TOO_LONG
INET_ERROR_NO_CONNECTION_HANDLER	CHIP_ERROR_NO_CONNECTION_HANDLER
INET_ERROR_NO_ENDPOINTS	CHIP_ERROR_ENDPOINT_POOL_FULL
INET_ERROR_NOT_IMPLEMENTED	CHIP_ERROR_NOT_IMPLEMENTED
INET_ERROR_NOT_SUPPORTED	CHIP_ERROR_UNSUPPORTED_CHIP_FEATURE
INET_ERROR_NO_MEMORY	CHIP_ERROR_NO_MEMORY
INET_ERROR_CONNECTION_ABORTED	CHIP_ERROR_CONNECTION_ABORTED

Testing

Modified some unit tests to account for consolidated error codes.

Built locally with CHIP_ERROR hardcoded to int32_t, uint32_t,
int16_t, and uint16_t to shake out mistaken type assumptions.

kpschoedel · 2021-06-25T17:23:37Z

Intended followups:

Remove compatibility definitions
Use smaller constants that fit in instruction immediate fields to save flash on small platforms. Subject to measurements, this might take the form of a compound code (bit mask or even class) as suggested in Unifiy/consolidate error types in CHIP #7722.

Possible additional followup:

Remove error erasures (e.g. VerifyOrReturnError(result == CHIP_NO_ERROR, CHIP_ERROR_INTERNAL)) to save flash.

kpschoedel · 2021-06-25T17:27:08Z

The various Error.h files have a comment at the top,

 *  NOTE WELL: On some platforms, this header is included by C-language programs.

Is that still true, or just a leftover from inherited code?

bzbarsky-apple · 2021-06-26T06:09:33Z

/rebase

github-actions · 2021-06-26T06:35:04Z

Size increase report for "gn_qpg6100-example-build" from 7e851e0

File	Section	File	VM
chip-qpg6100-lighting-example.out	.heap	0	8
chip-qpg6100-lighting-example.out	.data	-8	-8
chip-qpg6100-lighting-example.out	.text	-220	-220

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
[Unmapped],0,220
.heap,8,0
.data,-8,-8
.debug_aranges,0,-16
.debug_abbrev,0,-35
.debug_frame,0,-56
.debug_ranges,0,-72
.debug_line,0,-98
.debug_str,0,-147
.symtab,0,-160
.strtab,0,-172
.text,-220,-220
.debug_loc,0,-720
.debug_info,0,-3376

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'

bzbarsky-apple · 2021-06-26T06:46:53Z

@kpschoedel The ZAP failure seems to be because this PR hand-edited generated files without modifying the generation templates accordingly... Should probably change the templates (and then regenerate the generated bits instead of hand-editing).

github-actions · 2021-06-26T07:01:47Z

Size increase report for "nrfconnect-example-build" from 7e851e0

File	Section	File	VM
chip-lock.elf	device_handles	8	8
chip-lock.elf	datas	-8	-8
chip-lock.elf	rodata	-72	-72
chip-lock.elf	text	-120	-120
chip-shell.elf	datas	-8	-8
chip-shell.elf	text	-112	-112
chip-shell.elf	rodata	-168	-172

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
device_handles,8,8
.shstrtab,0,3
datas,-8,-8
.debug_aranges,0,-16
.debug_frame,0,-60
rodata,-72,-72
.debug_ranges,0,-88
text,-120,-120
.debug_str,0,-145
.strtab,0,-163
.symtab,0,-176
.debug_line,0,-372
.debug_loc,0,-743
.debug_abbrev,0,-1081
.debug_info,0,-4727

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_line,0,266
.shstrtab,0,-1
datas,-8,-8
.debug_aranges,0,-16
.debug_ranges,0,-16
.debug_frame,0,-48
text,-112,-112
.debug_str,0,-134
.strtab,0,-163
rodata,-172,-168
.symtab,0,-192
.debug_loc,0,-334
.debug_abbrev,0,-747
.debug_info,0,-2395

github-actions · 2021-06-26T07:02:09Z

Size increase report for "esp32-example-build" from 7e851e0

File	Section	File	VM
chip-all-clusters-app.elf	.flash.text	76	76
chip-all-clusters-app.elf	.dram0.data	-8	-8
chip-all-clusters-app.elf	.flash.rodata	-184	-184

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
[Unmapped],0,192
.debug_loc,0,151
.flash.text,76,76
.debug_line,0,54
.debug_abbrev,0,-7
.dram0.data,-8,-8
.debug_aranges,0,-16
.debug_frame,0,-48
.debug_ranges,0,-80
.symtab,0,-80
.debug_str,0,-146
.strtab,0,-172
.flash.rodata,-184,-184
.debug_info,0,-4140

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize
.debug_str,0,-13
.debug_line,0,-15
.debug_info,0,-32

#### Problem CHIP currently has `CHIP_ERROR`, `INET_ERROR`, `BLE_ERROR`, `ASN1_ERROR`, `System::Error`. Since they're all integers underneath, there is no type checking, and existing code routinely treats them as interchangeable. There is also existing code that uses `int` and `int32_t`. Each also has a `…_NO_ERROR` code which is independently configurable, but existing code assumes they are equal, and there is exising code that assumes the C convention that the value is 0. #### Change overview Fixes project-chip#7688 Unify chip errors This change is largely a mechanical replacement of type and some error code names, with a few cleanups of weak typing. Consolidated error types to one, `CHIP_ERROR`. Removed configurability of `CHIP_NO_ERROR`; it must be 0. Added `CHIP_ERROR_FORMAT` to replace hardcoded `PRI…32` in `printf()` format strings. Added `CHIP_ERROR_SENTINEL` to replace the use of `CHIP_ERROR_MAX` as a sentinel. Renamed or consolidated the following errors, which have the same meaning. Merely similar codes are left alone. This change contains compatibility defintitions to avoid breaking PRs in flight, which will be removed in a followup. | before | after | |:---------------------------------------|:------------------------------------| | ASN1_ERROR | CHIP_ERROR | | ASN1_NO_ERROR | CHIP_NO_ERROR | | BLE_ERROR | CHIP_ERROR | | BLE_NO_ERROR | CHIP_NO_ERROR | | BLE_ERROR_BAD_ARGS | CHIP_ERROR_INVALID_ARGUMENT | | BLE_ERROR_INCORRECT_STATE | CHIP_ERROR_INCORRECT_STATE | | BLE_ERROR_MESSAGE_INCOMPLETE | CHIP_ERROR_MESSAGE_INCOMPLETE | | BLE_ERROR_NOT_IMPLEMENTED | CHIP_ERROR_NOT_IMPLEMENTED | | BLE_ERROR_NO_ENDPOINTS | CHIP_ERROR_ENDPOINT_POOL_FULL | | BLE_ERROR_NO_MEMORY | CHIP_ERROR_NO_MEMORY | | BLE_ERROR_OUTBOUND_MESSAGE_TOO_BIG | CHIP_ERROR_OUTBOUND_MESSAGE_TOO_BIG | | BLE_ERROR_RECEIVED_MESSAGE_TOO_BIG | CHIP_ERROR_INBOUND_MESSAGE_TOO_BIG | | CHIP_SYSTEM_NO_ERROR | CHIP_NO_ERROR | | CHIP_SYSTEM_ERROR_ACCESS_DENIED | CHIP_ERROR_ACCESS_DENIED | | CHIP_SYSTEM_ERROR_BAD_ARGS | CHIP_ERROR_INVALID_ARGUMENT | | CHIP_SYSTEM_ERROR_NOT_SUPPORTED | CHIP_ERROR_UNSUPPORTED_CHIP_FEATURE | | CHIP_SYSTEM_ERROR_NO_MEMORY | CHIP_ERROR_NO_MEMORY | | CHIP_SYSTEM_ERROR_REAL_TIME_NOT_SYNCED | CHIP_ERROR_REAL_TIME_NOT_SYNCED | | CHIP_SYSTEM_ERROR_UNEXPECTED_EVENT | CHIP_ERROR_UNEXPECTED_EVENT | | CHIP_SYSTEM_ERROR_UNEXPECTED_STATE | CHIP_ERROR_INCORRECT_STATE | | INET_ERROR | CHIP_ERROR | | INET_NO_ERROR | CHIP_NO_ERROR | | INET_ERROR_BAD_ARGS | CHIP_ERROR_INVALID_ARGUMENT | | INET_ERROR_INBOUND_MESSAGE_TOO_BIG | CHIP_ERROR_INBOUND_MESSAGE_TOO_BIG | | INET_ERROR_INCORRECT_STATE | CHIP_ERROR_INCORRECT_STATE | | INET_ERROR_MESSAGE_TOO_LONG | CHIP_ERROR_MESSAGE_TOO_LONG | | INET_ERROR_NO_CONNECTION_HANDLER | CHIP_ERROR_NO_CONNECTION_HANDLER | | INET_ERROR_NO_ENDPOINTS | CHIP_ERROR_ENDPOINT_POOL_FULL | | INET_ERROR_NOT_IMPLEMENTED | CHIP_ERROR_NOT_IMPLEMENTED | | INET_ERROR_NOT_SUPPORTED | CHIP_ERROR_UNSUPPORTED_CHIP_FEATURE | | INET_ERROR_NO_MEMORY | CHIP_ERROR_NO_MEMORY | | INET_ERROR_CONNECTION_ABORTED | CHIP_ERROR_CONNECTION_ABORTED | #### Testing Modified some unit tests to account for consolidated error codes. Built locally with `CHIP_ERROR` hardcoded to `int32_t`, `uint32_t`, `int16_t`, and `uint16_t` to shake out mistaken type assumptions.

* Darwin * Doxygen

* Change default CHIP_CONFIG_ERROR_TYPE back to `int32_t`. * Fix CHIP_ERROR_INBOUND_MESSAGE_TOO_BIG message text. * C++-style casts.

woody-apple · 2021-06-28T21:23:30Z

@saurabhst @msandstedt @Damian-Nordic @jepenven-silabs @mspang ?

woody-apple · 2021-06-30T18:42:27Z

@mspang @Damian-Nordic @LuDuda @jmartinez-silabs ?

* add electrical measurement cluster to controller-clusters.zap Only a selection of the optional clusters is enabled. mandatory: - measurement type optional: - total active power - rms voltage - rms voltage min - rms voltage max - rms current - rms current min - rms current max - active power - active power min - active power max * add electrical measurement cluster to zap_cluster_list.py * add electrical measurement cluster to all-clusters-app * add electrical measurement cluster to all-cluster-app/esp32 * add app helpers for electrical measurement cluster * fix all cluster app build * regen all * Regenerating * Restyled by whitespace * Restyled by clang-format * Regenerating * Restyled by whitespace * Restyled by google-java-format * [fix] Wrong callback passed to WriteAttribute in Python[TE4] (#8019) * Fix callback typr * Run codegen * Mdns: _chip* -> _matter*, remove 0's on subtypes (#7805) * Mdns: _chip* i-> _matter*, remove 0's on subtypes The second ballot changed the format of the subtypes as well as fixed the service name prefix from _chip* to _matter*. NOTE FOR DEVs: Updating past this change will require updating the devices and controllers as otherwise they will be unable to find each other. * Darwin - use local kLocalDomain var. It includes a . and the one in the ServiceNaming doesn't. * Trying again for Darwin. * Fix host name. * Fix small error on merge * Use a dedicated chip-types.xml file into src/app/zap-templates/zcl (#7873) * Update chip-types.xml * Update gen/ folders * Revert "Mark UDP socket as ready for write in send msg. (#7927)" (#8027) Turns out the code causes that subsequent select()-s never wait so another solution for the original issue must be prepared. This reverts commit 8c55523. * [ZAP] Add isAnalog instead of isDiscreteType to account for string types (#7821) * Mdns: separate query responders for advertisers (#7615) * Mdns: separate query responders for advertisers The current setup uses a single query responder for commissionable and operational and all the records are cleared together and added in a large group. This makes it challenging to run commissionable and operational at the same time since they can't be cleared individually and because there are duplicate records between operational and commissionable. This commit changes the code to use one query responder per advertisement type and gets the ResponseSender to loop through the query responders to filter for answers. * Apply suggestions from code review Co-authored-by: chrisdecenzo <61757564+chrisdecenzo@users.noreply.github.com> * Restyled by clang-format * Fix tests - they were not testing right. * Restyled by clang-format * Update number of responders Represents 5 multi-admin fabrics for operational, commissionable and commissioner. * Whoops - broke a test with my last "minor" change. * Lighten the stack load for the failing test. Co-authored-by: chrisdecenzo <61757564+chrisdecenzo@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io> * [nrfconnect] Stop using cooperative threads (#8025) nRF Connect platform used cooperative threads, that is threads that cannot be preempted, to workaround some synchronization issues in the past, but it's no longer needed and is risky. The latter was revealed by #7927, which caused that `select()` never waits (needs to be fixed in another PR). Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no> * IPV6-only test app for esp32 (examples/ipv6only-app) (#7289) Adds RPCs that conform to NDM/GDM WiFi capabilities. Disables IPV4 DHCP client. Assigns link-local IPV6 address. Starts a UDP echo server on an IPV6 UDP socket. Test: Ran on M5Stack and verified it scanned and connected to wifi, after connected verified it echoed UDP messages. * [ESP32] fix compile error for persistent-storage app (#7940) * [ESP32] fix compile error for persistent-storage app * add CI for all ESP examples * Consolidate error types (#7916) * Consolidate error types #### Problem CHIP currently has `CHIP_ERROR`, `INET_ERROR`, `BLE_ERROR`, `ASN1_ERROR`, `System::Error`. Since they're all integers underneath, there is no type checking, and existing code routinely treats them as interchangeable. There is also existing code that uses `int` and `int32_t`. Each also has a `…_NO_ERROR` code which is independently configurable, but existing code assumes they are equal, and there is exising code that assumes the C convention that the value is 0. #### Change overview Fixes #7688 Unify chip errors This change is largely a mechanical replacement of type and some error code names, with a few cleanups of weak typing. Consolidated error types to one, `CHIP_ERROR`. Removed configurability of `CHIP_NO_ERROR`; it must be 0. Added `CHIP_ERROR_FORMAT` to replace hardcoded `PRI…32` in `printf()` format strings. Added `CHIP_ERROR_SENTINEL` to replace the use of `CHIP_ERROR_MAX` as a sentinel. Renamed or consolidated the following errors, which have the same meaning. Merely similar codes are left alone. This change contains compatibility defintitions to avoid breaking PRs in flight, which will be removed in a followup. | before | after | |:---------------------------------------|:------------------------------------| | ASN1_ERROR | CHIP_ERROR | | ASN1_NO_ERROR | CHIP_NO_ERROR | | BLE_ERROR | CHIP_ERROR | | BLE_NO_ERROR | CHIP_NO_ERROR | | BLE_ERROR_BAD_ARGS | CHIP_ERROR_INVALID_ARGUMENT | | BLE_ERROR_INCORRECT_STATE | CHIP_ERROR_INCORRECT_STATE | | BLE_ERROR_MESSAGE_INCOMPLETE | CHIP_ERROR_MESSAGE_INCOMPLETE | | BLE_ERROR_NOT_IMPLEMENTED | CHIP_ERROR_NOT_IMPLEMENTED | | BLE_ERROR_NO_ENDPOINTS | CHIP_ERROR_ENDPOINT_POOL_FULL | | BLE_ERROR_NO_MEMORY | CHIP_ERROR_NO_MEMORY | | BLE_ERROR_OUTBOUND_MESSAGE_TOO_BIG | CHIP_ERROR_OUTBOUND_MESSAGE_TOO_BIG | | BLE_ERROR_RECEIVED_MESSAGE_TOO_BIG | CHIP_ERROR_INBOUND_MESSAGE_TOO_BIG | | CHIP_SYSTEM_NO_ERROR | CHIP_NO_ERROR | | CHIP_SYSTEM_ERROR_ACCESS_DENIED | CHIP_ERROR_ACCESS_DENIED | | CHIP_SYSTEM_ERROR_BAD_ARGS | CHIP_ERROR_INVALID_ARGUMENT | | CHIP_SYSTEM_ERROR_NOT_SUPPORTED | CHIP_ERROR_UNSUPPORTED_CHIP_FEATURE | | CHIP_SYSTEM_ERROR_NO_MEMORY | CHIP_ERROR_NO_MEMORY | | CHIP_SYSTEM_ERROR_REAL_TIME_NOT_SYNCED | CHIP_ERROR_REAL_TIME_NOT_SYNCED | | CHIP_SYSTEM_ERROR_UNEXPECTED_EVENT | CHIP_ERROR_UNEXPECTED_EVENT | | CHIP_SYSTEM_ERROR_UNEXPECTED_STATE | CHIP_ERROR_INCORRECT_STATE | | INET_ERROR | CHIP_ERROR | | INET_NO_ERROR | CHIP_NO_ERROR | | INET_ERROR_BAD_ARGS | CHIP_ERROR_INVALID_ARGUMENT | | INET_ERROR_INBOUND_MESSAGE_TOO_BIG | CHIP_ERROR_INBOUND_MESSAGE_TOO_BIG | | INET_ERROR_INCORRECT_STATE | CHIP_ERROR_INCORRECT_STATE | | INET_ERROR_MESSAGE_TOO_LONG | CHIP_ERROR_MESSAGE_TOO_LONG | | INET_ERROR_NO_CONNECTION_HANDLER | CHIP_ERROR_NO_CONNECTION_HANDLER | | INET_ERROR_NO_ENDPOINTS | CHIP_ERROR_ENDPOINT_POOL_FULL | | INET_ERROR_NOT_IMPLEMENTED | CHIP_ERROR_NOT_IMPLEMENTED | | INET_ERROR_NOT_SUPPORTED | CHIP_ERROR_UNSUPPORTED_CHIP_FEATURE | | INET_ERROR_NO_MEMORY | CHIP_ERROR_NO_MEMORY | | INET_ERROR_CONNECTION_ABORTED | CHIP_ERROR_CONNECTION_ABORTED | #### Testing Modified some unit tests to account for consolidated error codes. Built locally with `CHIP_ERROR` hardcoded to `int32_t`, `uint32_t`, `int16_t`, and `uint16_t` to shake out mistaken type assumptions. * Build fixes * Darwin * Doxygen * Fixes * Change default CHIP_CONFIG_ERROR_TYPE back to `int32_t`. * Fix CHIP_ERROR_INBOUND_MESSAGE_TOO_BIG message text. * C++-style casts. * fix: CHIPError.h uses stdint.h * zap * fix for Mbed merge * Throw exception instead of return 0 for get-fabricid in case of error (#7884) * Implement User Directed Commissioning - Phase 1 (#8034) * Updated CHIP Certs Implementation to Use Spans instaed of Pointer/Len Pairs. (#7599) Specifically, added the following FixedSpan types: - CertificateKeyId - P256ECDSASignatureSpan - P256PublicKeySpan Also redefined mString member in the ChipRDN structure to be ByteSpan. * Zap use const expr for clusters commands attributes (#7946) * Remove duplicated command ids and attribute ids definitions from the encoder-src.zapt template Add ids/Commands.zapt template Update template to use Commands.h and Clusters.h * Fix XML definitions typos for attributes name * Add ids/Commands.h to the gen folder of src/app/common * Update log messages for session expiry (#8017) * Update log messages for session expiry * update format specifier * Remove client-command-macro.h-aa80d825 from examples/bridge-app/bridge-common/gen (#8026) * Fix Ble endpoint pool FULL on macOS controller (#7806) * * Move naming qpg6100 to qpg (#7936) * Removal Env overrides sdk root and target IC * fix build error in TCP.cpp (#8072) Include <limits> to satisfy the proper use of std::numeric_limits. * Add lighting example for Mbed OS (#8048) * Add back structs, bitmaps and enums of the Messaging cluster into ami… (#8061) * Add back structs, bitmaps and enums of the Messaging cluster into ami.xml * Update gen/ folders * Deprecated ASN1Writer::Finalize() Method. (#8056) * Split KeyValueStoreManager.java into interface and impl, and add Set() in JNI. (#8046) * [Test] Add Test_TC_DM_3_1 (#8067) * Add Test_TC_DM_3_1 to src/app/tests/suites with all tests disabled since the attributes are not present into commissioning.xml * Update generated tests * Followup #7873 - Replace emberAfPutInt8uInResp(ZCL_DEFAULT_RESPONSE_COMMAND_ID) by emberAfPutInt32uInResp(ZCL_DEFAULT_RESPONSE_COMMAND_ID) in src/app/util/util.cpp (#8060) * Remove call-command-handler.cpp from src/controller/data_model/gen/ and from src/darwin/Framework/CHIP.xcodeproj/project.pbxproj (#8021) * Add PID to Darwin/Linux Log Lines (#7657) * Add PID to Darwin/Linux Log Lines Problem: - Debugging test failures that involve multiple instances of applications is difficult when the log lines don't indicate which process/application they're coming from. Solution: - Added PID to the log lines on Darwin & Linux minimally to aid in debugging. Testing: - Ran chip-tool on both platforms. * Restyled by clang-format Co-authored-by: Restyled.io <commits@restyled.io> * Update Darwin framework to use GetConnectedDevice (#8011) * Update Darwin framework to use GetConnectedDevice * address review comments * Add a string circular buffer. (#7475) * Add a string circular buffer. * Update src/lib/support/StringCircularBuffer.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/lib/support/StringCircularBuffer.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/lib/support/StringCircularBuffer.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Resolve comments * Resolve comments * Resolve comments * Resolve comments Co-authored-by: Justin Wood <woody@apple.com> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * [lighting-app] Enable optional Basic Cluster attributes (#8083) * [lighting-app] Enable optional Basic Cluster attributes Enable optional Basic Cluster attributes as requested by Chaintanya, to verify a proper behaviour of the Python controller. * Re-gen code * Add GenerateEventPathList and test (#8014) Summary of Changes: -- Add GenerateEventPathList function in ReadClinet -- Add one event path test and two event path test -- Fix im e2e cirque test in chip_im_responder from PR 7634 since cirque test is not enabled * Have a single loopback transport implementation for tests. (#8045) We have multiple, some with different bells and whistles. Should have one shared thing. Unfortunately, some consumers want to drive things off the loopback (like resending reliable messages) that other consumers can't know about because they are at lower layers of the stack. We just use a virtual hook for that for now. * Don't treat a resolve as done in chip-device-ctrl until we have a CASE connection. (#8012) This ensures that following commands will work instead of racing the CASE connection setup. * Regenerating * Restyled by whitespace * Restyled by google-java-format * Regenerating Co-authored-by: Justin Wood <woody@apple.com> Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Song Guo <songguo@google.com> Co-authored-by: C Freeman <cecille@google.com> Co-authored-by: Vivien Nicolas <vnicolas@apple.com> Co-authored-by: Damian Królik <66667989+Damian-Nordic@users.noreply.github.com> Co-authored-by: chrisdecenzo <61757564+chrisdecenzo@users.noreply.github.com> Co-authored-by: rgoliver <rgoliver@google.com> Co-authored-by: Wang Qixiang <43193572+wqx6@users.noreply.github.com> Co-authored-by: Kevin Schoedel <67607049+kpschoedel@users.noreply.github.com> Co-authored-by: Yufeng Wang <yufengwang@google.com> Co-authored-by: Evgeny Margolis <emargolis@google.com> Co-authored-by: Pankaj Garg <pgarg2@apple.com> Co-authored-by: krypton36 <joshuavillasenor@me.com> Co-authored-by: Timothy Maes <timothy.maes@qorvo.com> Co-authored-by: CodeChronos <1197535+CodeChronos928@users.noreply.github.com> Co-authored-by: Vincent Coubard <vincent.coubard@arm.com> Co-authored-by: Austin Hsieh <77706079+austinh0@users.noreply.github.com> Co-authored-by: Jerry Johns <johnsj@google.com> Co-authored-by: Zang MingJie <zealot0630@gmail.com> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> Co-authored-by: yunhanw-google <yunhanw@google.com>

PR project-chip#7916 _Consolidate error types_ included some temporary definitions to avoid breaking any PRs in flight. #### Change overview - Removed the temporary definitions. - Updated names in recent PRs. #### Testing No changes to functionality.

* #### Problem PR #7916 _Consolidate error types_ included some temporary definitions to avoid breaking any PRs in flight. #### Change overview - Removed the temporary definitions. - Updated names in recent PRs. #### Testing No changes to functionality. * missed esp32 example * missed Mbed mutex * missed chip-tool and more Mbed

* Consolidate error types #### Problem CHIP currently has `CHIP_ERROR`, `INET_ERROR`, `BLE_ERROR`, `ASN1_ERROR`, `System::Error`. Since they're all integers underneath, there is no type checking, and existing code routinely treats them as interchangeable. There is also existing code that uses `int` and `int32_t`. Each also has a `…_NO_ERROR` code which is independently configurable, but existing code assumes they are equal, and there is exising code that assumes the C convention that the value is 0. #### Change overview Fixes project-chip#7688 Unify chip errors This change is largely a mechanical replacement of type and some error code names, with a few cleanups of weak typing. Consolidated error types to one, `CHIP_ERROR`. Removed configurability of `CHIP_NO_ERROR`; it must be 0. Added `CHIP_ERROR_FORMAT` to replace hardcoded `PRI…32` in `printf()` format strings. Added `CHIP_ERROR_SENTINEL` to replace the use of `CHIP_ERROR_MAX` as a sentinel. Renamed or consolidated the following errors, which have the same meaning. Merely similar codes are left alone. This change contains compatibility defintitions to avoid breaking PRs in flight, which will be removed in a followup. | before | after | |:---------------------------------------|:------------------------------------| | ASN1_ERROR | CHIP_ERROR | | ASN1_NO_ERROR | CHIP_NO_ERROR | | BLE_ERROR | CHIP_ERROR | | BLE_NO_ERROR | CHIP_NO_ERROR | | BLE_ERROR_BAD_ARGS | CHIP_ERROR_INVALID_ARGUMENT | | BLE_ERROR_INCORRECT_STATE | CHIP_ERROR_INCORRECT_STATE | | BLE_ERROR_MESSAGE_INCOMPLETE | CHIP_ERROR_MESSAGE_INCOMPLETE | | BLE_ERROR_NOT_IMPLEMENTED | CHIP_ERROR_NOT_IMPLEMENTED | | BLE_ERROR_NO_ENDPOINTS | CHIP_ERROR_ENDPOINT_POOL_FULL | | BLE_ERROR_NO_MEMORY | CHIP_ERROR_NO_MEMORY | | BLE_ERROR_OUTBOUND_MESSAGE_TOO_BIG | CHIP_ERROR_OUTBOUND_MESSAGE_TOO_BIG | | BLE_ERROR_RECEIVED_MESSAGE_TOO_BIG | CHIP_ERROR_INBOUND_MESSAGE_TOO_BIG | | CHIP_SYSTEM_NO_ERROR | CHIP_NO_ERROR | | CHIP_SYSTEM_ERROR_ACCESS_DENIED | CHIP_ERROR_ACCESS_DENIED | | CHIP_SYSTEM_ERROR_BAD_ARGS | CHIP_ERROR_INVALID_ARGUMENT | | CHIP_SYSTEM_ERROR_NOT_SUPPORTED | CHIP_ERROR_UNSUPPORTED_CHIP_FEATURE | | CHIP_SYSTEM_ERROR_NO_MEMORY | CHIP_ERROR_NO_MEMORY | | CHIP_SYSTEM_ERROR_REAL_TIME_NOT_SYNCED | CHIP_ERROR_REAL_TIME_NOT_SYNCED | | CHIP_SYSTEM_ERROR_UNEXPECTED_EVENT | CHIP_ERROR_UNEXPECTED_EVENT | | CHIP_SYSTEM_ERROR_UNEXPECTED_STATE | CHIP_ERROR_INCORRECT_STATE | | INET_ERROR | CHIP_ERROR | | INET_NO_ERROR | CHIP_NO_ERROR | | INET_ERROR_BAD_ARGS | CHIP_ERROR_INVALID_ARGUMENT | | INET_ERROR_INBOUND_MESSAGE_TOO_BIG | CHIP_ERROR_INBOUND_MESSAGE_TOO_BIG | | INET_ERROR_INCORRECT_STATE | CHIP_ERROR_INCORRECT_STATE | | INET_ERROR_MESSAGE_TOO_LONG | CHIP_ERROR_MESSAGE_TOO_LONG | | INET_ERROR_NO_CONNECTION_HANDLER | CHIP_ERROR_NO_CONNECTION_HANDLER | | INET_ERROR_NO_ENDPOINTS | CHIP_ERROR_ENDPOINT_POOL_FULL | | INET_ERROR_NOT_IMPLEMENTED | CHIP_ERROR_NOT_IMPLEMENTED | | INET_ERROR_NOT_SUPPORTED | CHIP_ERROR_UNSUPPORTED_CHIP_FEATURE | | INET_ERROR_NO_MEMORY | CHIP_ERROR_NO_MEMORY | | INET_ERROR_CONNECTION_ABORTED | CHIP_ERROR_CONNECTION_ABORTED | #### Testing Modified some unit tests to account for consolidated error codes. Built locally with `CHIP_ERROR` hardcoded to `int32_t`, `uint32_t`, `int16_t`, and `uint16_t` to shake out mistaken type assumptions. * Build fixes * Darwin * Doxygen * Fixes * Change default CHIP_CONFIG_ERROR_TYPE back to `int32_t`. * Fix CHIP_ERROR_INBOUND_MESSAGE_TOO_BIG message text. * C++-style casts. * fix: CHIPError.h uses stdint.h * zap * fix for Mbed merge

* add electrical measurement cluster to controller-clusters.zap Only a selection of the optional clusters is enabled. mandatory: - measurement type optional: - total active power - rms voltage - rms voltage min - rms voltage max - rms current - rms current min - rms current max - active power - active power min - active power max * add electrical measurement cluster to zap_cluster_list.py * add electrical measurement cluster to all-clusters-app * add electrical measurement cluster to all-cluster-app/esp32 * add app helpers for electrical measurement cluster * fix all cluster app build * regen all * Regenerating * Restyled by whitespace * Restyled by clang-format * Regenerating * Restyled by whitespace * Restyled by google-java-format * [fix] Wrong callback passed to WriteAttribute in Python[TE4] (project-chip#8019) * Fix callback typr * Run codegen * Mdns: _chip* -> _matter*, remove 0's on subtypes (project-chip#7805) * Mdns: _chip* i-> _matter*, remove 0's on subtypes The second ballot changed the format of the subtypes as well as fixed the service name prefix from _chip* to _matter*. NOTE FOR DEVs: Updating past this change will require updating the devices and controllers as otherwise they will be unable to find each other. * Darwin - use local kLocalDomain var. It includes a . and the one in the ServiceNaming doesn't. * Trying again for Darwin. * Fix host name. * Fix small error on merge * Use a dedicated chip-types.xml file into src/app/zap-templates/zcl (project-chip#7873) * Update chip-types.xml * Update gen/ folders * Revert "Mark UDP socket as ready for write in send msg. (project-chip#7927)" (project-chip#8027) Turns out the code causes that subsequent select()-s never wait so another solution for the original issue must be prepared. This reverts commit 8c55523. * [ZAP] Add isAnalog instead of isDiscreteType to account for string types (project-chip#7821) * Mdns: separate query responders for advertisers (project-chip#7615) * Mdns: separate query responders for advertisers The current setup uses a single query responder for commissionable and operational and all the records are cleared together and added in a large group. This makes it challenging to run commissionable and operational at the same time since they can't be cleared individually and because there are duplicate records between operational and commissionable. This commit changes the code to use one query responder per advertisement type and gets the ResponseSender to loop through the query responders to filter for answers. * Apply suggestions from code review Co-authored-by: chrisdecenzo <61757564+chrisdecenzo@users.noreply.github.com> * Restyled by clang-format * Fix tests - they were not testing right. * Restyled by clang-format * Update number of responders Represents 5 multi-admin fabrics for operational, commissionable and commissioner. * Whoops - broke a test with my last "minor" change. * Lighten the stack load for the failing test. Co-authored-by: chrisdecenzo <61757564+chrisdecenzo@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io> * [nrfconnect] Stop using cooperative threads (project-chip#8025) nRF Connect platform used cooperative threads, that is threads that cannot be preempted, to workaround some synchronization issues in the past, but it's no longer needed and is risky. The latter was revealed by project-chip#7927, which caused that `select()` never waits (needs to be fixed in another PR). Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no> * IPV6-only test app for esp32 (examples/ipv6only-app) (project-chip#7289) Adds RPCs that conform to NDM/GDM WiFi capabilities. Disables IPV4 DHCP client. Assigns link-local IPV6 address. Starts a UDP echo server on an IPV6 UDP socket. Test: Ran on M5Stack and verified it scanned and connected to wifi, after connected verified it echoed UDP messages. * [ESP32] fix compile error for persistent-storage app (project-chip#7940) * [ESP32] fix compile error for persistent-storage app * add CI for all ESP examples * Consolidate error types (project-chip#7916) * Consolidate error types #### Problem CHIP currently has `CHIP_ERROR`, `INET_ERROR`, `BLE_ERROR`, `ASN1_ERROR`, `System::Error`. Since they're all integers underneath, there is no type checking, and existing code routinely treats them as interchangeable. There is also existing code that uses `int` and `int32_t`. Each also has a `…_NO_ERROR` code which is independently configurable, but existing code assumes they are equal, and there is exising code that assumes the C convention that the value is 0. #### Change overview Fixes project-chip#7688 Unify chip errors This change is largely a mechanical replacement of type and some error code names, with a few cleanups of weak typing. Consolidated error types to one, `CHIP_ERROR`. Removed configurability of `CHIP_NO_ERROR`; it must be 0. Added `CHIP_ERROR_FORMAT` to replace hardcoded `PRI…32` in `printf()` format strings. Added `CHIP_ERROR_SENTINEL` to replace the use of `CHIP_ERROR_MAX` as a sentinel. Renamed or consolidated the following errors, which have the same meaning. Merely similar codes are left alone. This change contains compatibility defintitions to avoid breaking PRs in flight, which will be removed in a followup. | before | after | |:---------------------------------------|:------------------------------------| | ASN1_ERROR | CHIP_ERROR | | ASN1_NO_ERROR | CHIP_NO_ERROR | | BLE_ERROR | CHIP_ERROR | | BLE_NO_ERROR | CHIP_NO_ERROR | | BLE_ERROR_BAD_ARGS | CHIP_ERROR_INVALID_ARGUMENT | | BLE_ERROR_INCORRECT_STATE | CHIP_ERROR_INCORRECT_STATE | | BLE_ERROR_MESSAGE_INCOMPLETE | CHIP_ERROR_MESSAGE_INCOMPLETE | | BLE_ERROR_NOT_IMPLEMENTED | CHIP_ERROR_NOT_IMPLEMENTED | | BLE_ERROR_NO_ENDPOINTS | CHIP_ERROR_ENDPOINT_POOL_FULL | | BLE_ERROR_NO_MEMORY | CHIP_ERROR_NO_MEMORY | | BLE_ERROR_OUTBOUND_MESSAGE_TOO_BIG | CHIP_ERROR_OUTBOUND_MESSAGE_TOO_BIG | | BLE_ERROR_RECEIVED_MESSAGE_TOO_BIG | CHIP_ERROR_INBOUND_MESSAGE_TOO_BIG | | CHIP_SYSTEM_NO_ERROR | CHIP_NO_ERROR | | CHIP_SYSTEM_ERROR_ACCESS_DENIED | CHIP_ERROR_ACCESS_DENIED | | CHIP_SYSTEM_ERROR_BAD_ARGS | CHIP_ERROR_INVALID_ARGUMENT | | CHIP_SYSTEM_ERROR_NOT_SUPPORTED | CHIP_ERROR_UNSUPPORTED_CHIP_FEATURE | | CHIP_SYSTEM_ERROR_NO_MEMORY | CHIP_ERROR_NO_MEMORY | | CHIP_SYSTEM_ERROR_REAL_TIME_NOT_SYNCED | CHIP_ERROR_REAL_TIME_NOT_SYNCED | | CHIP_SYSTEM_ERROR_UNEXPECTED_EVENT | CHIP_ERROR_UNEXPECTED_EVENT | | CHIP_SYSTEM_ERROR_UNEXPECTED_STATE | CHIP_ERROR_INCORRECT_STATE | | INET_ERROR | CHIP_ERROR | | INET_NO_ERROR | CHIP_NO_ERROR | | INET_ERROR_BAD_ARGS | CHIP_ERROR_INVALID_ARGUMENT | | INET_ERROR_INBOUND_MESSAGE_TOO_BIG | CHIP_ERROR_INBOUND_MESSAGE_TOO_BIG | | INET_ERROR_INCORRECT_STATE | CHIP_ERROR_INCORRECT_STATE | | INET_ERROR_MESSAGE_TOO_LONG | CHIP_ERROR_MESSAGE_TOO_LONG | | INET_ERROR_NO_CONNECTION_HANDLER | CHIP_ERROR_NO_CONNECTION_HANDLER | | INET_ERROR_NO_ENDPOINTS | CHIP_ERROR_ENDPOINT_POOL_FULL | | INET_ERROR_NOT_IMPLEMENTED | CHIP_ERROR_NOT_IMPLEMENTED | | INET_ERROR_NOT_SUPPORTED | CHIP_ERROR_UNSUPPORTED_CHIP_FEATURE | | INET_ERROR_NO_MEMORY | CHIP_ERROR_NO_MEMORY | | INET_ERROR_CONNECTION_ABORTED | CHIP_ERROR_CONNECTION_ABORTED | #### Testing Modified some unit tests to account for consolidated error codes. Built locally with `CHIP_ERROR` hardcoded to `int32_t`, `uint32_t`, `int16_t`, and `uint16_t` to shake out mistaken type assumptions. * Build fixes * Darwin * Doxygen * Fixes * Change default CHIP_CONFIG_ERROR_TYPE back to `int32_t`. * Fix CHIP_ERROR_INBOUND_MESSAGE_TOO_BIG message text. * C++-style casts. * fix: CHIPError.h uses stdint.h * zap * fix for Mbed merge * Throw exception instead of return 0 for get-fabricid in case of error (project-chip#7884) * Implement User Directed Commissioning - Phase 1 (project-chip#8034) * Updated CHIP Certs Implementation to Use Spans instaed of Pointer/Len Pairs. (project-chip#7599) Specifically, added the following FixedSpan types: - CertificateKeyId - P256ECDSASignatureSpan - P256PublicKeySpan Also redefined mString member in the ChipRDN structure to be ByteSpan. * Zap use const expr for clusters commands attributes (project-chip#7946) * Remove duplicated command ids and attribute ids definitions from the encoder-src.zapt template Add ids/Commands.zapt template Update template to use Commands.h and Clusters.h * Fix XML definitions typos for attributes name * Add ids/Commands.h to the gen folder of src/app/common * Update log messages for session expiry (project-chip#8017) * Update log messages for session expiry * update format specifier * Remove client-command-macro.h-aa80d825 from examples/bridge-app/bridge-common/gen (project-chip#8026) * Fix Ble endpoint pool FULL on macOS controller (project-chip#7806) * * Move naming qpg6100 to qpg (project-chip#7936) * Removal Env overrides sdk root and target IC * fix build error in TCP.cpp (project-chip#8072) Include <limits> to satisfy the proper use of std::numeric_limits. * Add lighting example for Mbed OS (project-chip#8048) * Add back structs, bitmaps and enums of the Messaging cluster into ami… (project-chip#8061) * Add back structs, bitmaps and enums of the Messaging cluster into ami.xml * Update gen/ folders * Deprecated ASN1Writer::Finalize() Method. (project-chip#8056) * Split KeyValueStoreManager.java into interface and impl, and add Set() in JNI. (project-chip#8046) * [Test] Add Test_TC_DM_3_1 (project-chip#8067) * Add Test_TC_DM_3_1 to src/app/tests/suites with all tests disabled since the attributes are not present into commissioning.xml * Update generated tests * Followup project-chip#7873 - Replace emberAfPutInt8uInResp(ZCL_DEFAULT_RESPONSE_COMMAND_ID) by emberAfPutInt32uInResp(ZCL_DEFAULT_RESPONSE_COMMAND_ID) in src/app/util/util.cpp (project-chip#8060) * Remove call-command-handler.cpp from src/controller/data_model/gen/ and from src/darwin/Framework/CHIP.xcodeproj/project.pbxproj (project-chip#8021) * Add PID to Darwin/Linux Log Lines (project-chip#7657) * Add PID to Darwin/Linux Log Lines Problem: - Debugging test failures that involve multiple instances of applications is difficult when the log lines don't indicate which process/application they're coming from. Solution: - Added PID to the log lines on Darwin & Linux minimally to aid in debugging. Testing: - Ran chip-tool on both platforms. * Restyled by clang-format Co-authored-by: Restyled.io <commits@restyled.io> * Update Darwin framework to use GetConnectedDevice (project-chip#8011) * Update Darwin framework to use GetConnectedDevice * address review comments * Add a string circular buffer. (project-chip#7475) * Add a string circular buffer. * Update src/lib/support/StringCircularBuffer.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/lib/support/StringCircularBuffer.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/lib/support/StringCircularBuffer.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Resolve comments * Resolve comments * Resolve comments * Resolve comments Co-authored-by: Justin Wood <woody@apple.com> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * [lighting-app] Enable optional Basic Cluster attributes (project-chip#8083) * [lighting-app] Enable optional Basic Cluster attributes Enable optional Basic Cluster attributes as requested by Chaintanya, to verify a proper behaviour of the Python controller. * Re-gen code * Add GenerateEventPathList and test (project-chip#8014) Summary of Changes: -- Add GenerateEventPathList function in ReadClinet -- Add one event path test and two event path test -- Fix im e2e cirque test in chip_im_responder from PR 7634 since cirque test is not enabled * Have a single loopback transport implementation for tests. (project-chip#8045) We have multiple, some with different bells and whistles. Should have one shared thing. Unfortunately, some consumers want to drive things off the loopback (like resending reliable messages) that other consumers can't know about because they are at lower layers of the stack. We just use a virtual hook for that for now. * Don't treat a resolve as done in chip-device-ctrl until we have a CASE connection. (project-chip#8012) This ensures that following commands will work instead of racing the CASE connection setup. * Regenerating * Restyled by whitespace * Restyled by google-java-format * Regenerating Co-authored-by: Justin Wood <woody@apple.com> Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Song Guo <songguo@google.com> Co-authored-by: C Freeman <cecille@google.com> Co-authored-by: Vivien Nicolas <vnicolas@apple.com> Co-authored-by: Damian Królik <66667989+Damian-Nordic@users.noreply.github.com> Co-authored-by: chrisdecenzo <61757564+chrisdecenzo@users.noreply.github.com> Co-authored-by: rgoliver <rgoliver@google.com> Co-authored-by: Wang Qixiang <43193572+wqx6@users.noreply.github.com> Co-authored-by: Kevin Schoedel <67607049+kpschoedel@users.noreply.github.com> Co-authored-by: Yufeng Wang <yufengwang@google.com> Co-authored-by: Evgeny Margolis <emargolis@google.com> Co-authored-by: Pankaj Garg <pgarg2@apple.com> Co-authored-by: krypton36 <joshuavillasenor@me.com> Co-authored-by: Timothy Maes <timothy.maes@qorvo.com> Co-authored-by: CodeChronos <1197535+CodeChronos928@users.noreply.github.com> Co-authored-by: Vincent Coubard <vincent.coubard@arm.com> Co-authored-by: Austin Hsieh <77706079+austinh0@users.noreply.github.com> Co-authored-by: Jerry Johns <johnsj@google.com> Co-authored-by: Zang MingJie <zealot0630@gmail.com> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> Co-authored-by: yunhanw-google <yunhanw@google.com>

) * #### Problem PR project-chip#7916 _Consolidate error types_ included some temporary definitions to avoid breaking any PRs in flight. #### Change overview - Removed the temporary definitions. - Updated names in recent PRs. #### Testing No changes to functionality. * missed esp32 example * missed Mbed mutex * missed chip-tool and more Mbed

boring-cyborg bot added the examples label Jun 25, 2021

pullapprove bot requested review from chrisdecenzo, jelderton, jmartinez-silabs, LuDuda, mspang, saurabhst and woody-apple June 25, 2021 17:18

pullapprove bot added the review - pending label Jun 25, 2021

kpschoedel force-pushed the error-types branch from 7e34abb to 8c16737 Compare June 25, 2021 17:45

woody-apple force-pushed the error-types branch from ce0097d to 6b07f4c Compare June 26, 2021 06:18

kpschoedel force-pushed the error-types branch from 6b07f4c to b0247a2 Compare June 28, 2021 16:22

kpschoedel added 5 commits June 28, 2021 13:46

Build fixes

e820c60

* Darwin * Doxygen

Fixes

df53078

* Change default CHIP_CONFIG_ERROR_TYPE back to `int32_t`. * Fix CHIP_ERROR_INBOUND_MESSAGE_TOO_BIG message text. * C++-style casts.

fix: CHIPError.h uses stdint.h

212488e

zap

948d1c4

woody-apple approved these changes Jun 28, 2021

View reviewed changes

woody-apple added the has conflicts label Jun 28, 2021

saurabhst approved these changes Jun 28, 2021

View reviewed changes

Merge remote-tracking branch 'origin/master' into error-types

021f061

kpschoedel force-pushed the error-types branch from b0247a2 to 021f061 Compare June 29, 2021 14:49

kpschoedel added 3 commits June 29, 2021 13:10

Merge remote-tracking branch 'origin/master' into error-types

045b7a2

fix for Mbed merge

d0375d0

Merge remote-tracking branch 'origin/master' into error-types

ef588e4

jmartinez-silabs approved these changes Jun 30, 2021

View reviewed changes

pullapprove bot added review - approved and removed review - pending labels Jun 30, 2021

mspang added the technical review - DONE label Jun 30, 2021

mspang approved these changes Jun 30, 2021

View reviewed changes

mspang merged commit 9c01258 into project-chip:master Jun 30, 2021

kpschoedel deleted the error-types branch July 2, 2021 16:09

kpschoedel mentioned this pull request Jul 5, 2021

Clean up temporary error code macros added in PR#7916 #8119

Merged

emargolis mentioned this pull request Jul 21, 2021

CHIP Certificate Code Mixes ASN1_ERROR and CHIP_ERROR Error Spaces #4310

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Consolidate error types #7916

Consolidate error types #7916

kpschoedel commented Jun 25, 2021 •

edited

Loading

kpschoedel commented Jun 25, 2021

kpschoedel commented Jun 25, 2021

bzbarsky-apple commented Jun 26, 2021

github-actions bot commented Jun 26, 2021

bzbarsky-apple commented Jun 26, 2021

github-actions bot commented Jun 26, 2021

github-actions bot commented Jun 26, 2021

woody-apple commented Jun 28, 2021

woody-apple commented Jun 30, 2021

Consolidate error types #7916

Consolidate error types #7916

Conversation

kpschoedel commented Jun 25, 2021 • edited Loading

Problem

Change overview

Testing

kpschoedel commented Jun 25, 2021

kpschoedel commented Jun 25, 2021

bzbarsky-apple commented Jun 26, 2021

github-actions bot commented Jun 26, 2021

bzbarsky-apple commented Jun 26, 2021

github-actions bot commented Jun 26, 2021

github-actions bot commented Jun 26, 2021

woody-apple commented Jun 28, 2021

woody-apple commented Jun 30, 2021

kpschoedel commented Jun 25, 2021 •

edited

Loading