Clean up temporary error code macros added in PR#7916

[kpschoedel]

Problem

PR #7916 Consolidate error types included some temporary
definitions to avoid breaking any PRs in flight.

Change overview

• Removed the temporary definitions.
• Updated names in recent PRs.

Testing

No changes to functionality.

[kpschoedel]

At the moment there are no uses of the old names in open PRs.

[github-actions]

Size increase report for "gn_qpg-example-build" from 7aece18

File	Section	File	VM
chip-qpg6100-lighting-example.out	.text	20	20

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
.debug_loc,0,32
.text,20,20
.debug_str,0,1
[Unmapped],0,-20
.debug_ranges,0,-40
.debug_abbrev,0,-101
.debug_info,0,-114
.debug_line,0,-430

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'

[github-actions]

Size increase report for "esp32-example-build" from 7aece18

File	Section	File	VM
chip-all-clusters-app.elf	.flash.text	4	4
chip-lock-app.elf	.flash.text	4	4

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_str,0,2
.debug_info,0,-2
.debug_line,0,-6
.debug_abbrev,0,-20
.debug_loc,0,-34

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.flash.text,4,4
.debug_str,0,2
.debug_abbrev,0,-79
.debug_ranges,0,-80
.debug_loc,0,-157
.debug_info,0,-200
.debug_line,0,-510

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize
.flash.text,4,4
.debug_str,0,-2
.debug_abbrev,0,-55
.debug_ranges,0,-80
.debug_loc,0,-106
.debug_info,0,-139
.debug_line,0,-318

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
.debug_str,0,-1
.debug_line,0,-47
.debug_abbrev,0,-55
.debug_ranges,0,-80
.debug_loc,0,-134
.debug_info,0,-139

[jelderton]

Leaving open for other reviews before merging

[kpschoedel]

Currently there is one open PR using the old names (#8518) and I have commented there.