Updated CHIP Certs to Use Spans Instead of Pointer/Len Pairs #7599

emargolis · 2021-06-14T15:05:44Z

Problem

Currently CHIP Cert implementation is using data pointer/len pairs to represent some data structures. It should be more convenient and cleaner to use ByteSpan and FixedByteSpan types for that.

Change overview

Updated CHIP Certs Implementation to Use Spans Instead of Pointer/Len Pairs

Specifically, added the following FixedSpan types:

CertificateKeyId
P256ECDSASignatureSpan
P256PublicKeySpan
Also redefined mString member in the ChipRDN structure to be ByteSpan.

Testing

CHIP Cert Unit Testing

Ticket: #7458

woody-apple · 2021-06-15T18:23:56Z

@emargolis looks like a real build failure

src/credentials/CHIPCert.h

mspang

The union changes look suspicious.

woody-apple · 2021-06-16T04:02:20Z

/rebase

src/credentials/CHIPCert.cpp

src/credentials/CHIPCertToX509.cpp

src/tools/chip-cert/CertUtils.cpp

woody-apple · 2021-06-17T01:32:46Z

/rebase

woody-apple · 2021-06-21T22:22:26Z

@emargolis conflicts :(

woody-apple · 2021-06-22T01:33:19Z

/rebase

src/credentials/CHIPCert.h

emargolis · 2021-06-26T08:56:46Z

@mspang Following your recommendation I eliminated the problematic union from the ChipRDN struct.

github-actions · 2021-06-26T09:22:56Z

Size increase report for "esp32-example-build" from 17dbc19

File	Section	File	VM
chip-all-clusters-app.elf	.dram0.bss	0	-56
chip-all-clusters-app.elf	.flash.text	-216	-216

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,41125
.debug_str,0,1322
.debug_loc,0,778
.debug_line,0,262
.debug_ranges,0,184
.xt.prop._ZNK4chip9FixedSpanIKhLj20EE10data_equalIS1_vEEbRKNS0_IT_Lj20EEE,0,152
.shstrtab,0,148
.strtab,0,144
.xt.prop._ZNK4chip11Credentials24OperationalCredentialSet15GetDevOpCredLenERKNS_9FixedSpanIKhLj20EEE,0,76
.symtab,0,64
.debug_frame,0,24
.debug_aranges,0,8
.dram0.bss,-56,0
.xt.prop._ZNK4chip11Credentials24OperationalCredentialSet15GetDevOpCredLenERKNS0_16CertificateKeyIdE,0,-76
.flash.text,-216,-216
.debug_abbrev,0,-975

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

github-actions · 2021-06-26T09:23:15Z

Size increase report for "gn_qpg6100-example-build" from 17dbc19

File	Section	File	VM
chip-qpg6100-lighting-example.out	.heap	0	56
chip-qpg6100-lighting-example.out	.bss	0	-56
chip-qpg6100-lighting-example.out	.text	-224	-224

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
.debug_info,0,27158
.debug_str,0,1286
.debug_line,0,623
.debug_ranges,0,408
[Unmapped],0,224
.strtab,0,151
.debug_frame,0,84
.symtab,0,80
.heap,56,0
.debug_aranges,0,8
.shstrtab,0,1
.bss,-56,0
.text,-224,-224
.debug_loc,0,-300
.debug_abbrev,0,-619

github-actions · 2021-06-26T09:37:46Z

Size increase report for "nrfconnect-example-build" from 17dbc19

File	Section	File	VM
chip-lock.elf	[LOAD #3 [RW]]	0	-22
chip-lock.elf	bss	0	-42
chip-lock.elf	text	-176	-176

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_info,0,27758
.debug_str,0,1286
.debug_line,0,925
.debug_loc,0,762
.debug_ranges,0,456
.strtab,0,151
.symtab,0,80
.debug_frame,0,76
.debug_aranges,0,8
.shstrtab,0,1
[LOAD #3 [RW]],-22,0
bss,-42,0
text,-176,-176
.debug_abbrev,0,-591

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_info,0,6504
.debug_str,0,479
.debug_line,0,-24
.debug_loc,0,-87
.debug_abbrev,0,-160

emargolis · 2021-06-29T16:12:34Z

@mspang Can this be merged?

src/credentials/CHIPCert.h

mspang · 2021-06-30T20:39:03Z

@emargolis needs rebase

… Pairs. Specifically, added the following FixedSpan types: - CertificateKeyId - P256ECDSASignatureSpan - P256PublicKeySpan Also redefined mString member in the ChipRDN structure to be ByteSpan.

emargolis · 2021-06-30T21:48:00Z

@emargolis needs rebase

rebased and ready to merge

* add electrical measurement cluster to controller-clusters.zap Only a selection of the optional clusters is enabled. mandatory: - measurement type optional: - total active power - rms voltage - rms voltage min - rms voltage max - rms current - rms current min - rms current max - active power - active power min - active power max * add electrical measurement cluster to zap_cluster_list.py * add electrical measurement cluster to all-clusters-app * add electrical measurement cluster to all-cluster-app/esp32 * add app helpers for electrical measurement cluster * fix all cluster app build * regen all * Regenerating * Restyled by whitespace * Restyled by clang-format * Regenerating * Restyled by whitespace * Restyled by google-java-format * [fix] Wrong callback passed to WriteAttribute in Python[TE4] (#8019) * Fix callback typr * Run codegen * Mdns: _chip* -> _matter*, remove 0's on subtypes (#7805) * Mdns: _chip* i-> _matter*, remove 0's on subtypes The second ballot changed the format of the subtypes as well as fixed the service name prefix from _chip* to _matter*. NOTE FOR DEVs: Updating past this change will require updating the devices and controllers as otherwise they will be unable to find each other. * Darwin - use local kLocalDomain var. It includes a . and the one in the ServiceNaming doesn't. * Trying again for Darwin. * Fix host name. * Fix small error on merge * Use a dedicated chip-types.xml file into src/app/zap-templates/zcl (#7873) * Update chip-types.xml * Update gen/ folders * Revert "Mark UDP socket as ready for write in send msg. (#7927)" (#8027) Turns out the code causes that subsequent select()-s never wait so another solution for the original issue must be prepared. This reverts commit 8c55523. * [ZAP] Add isAnalog instead of isDiscreteType to account for string types (#7821) * Mdns: separate query responders for advertisers (#7615) * Mdns: separate query responders for advertisers The current setup uses a single query responder for commissionable and operational and all the records are cleared together and added in a large group. This makes it challenging to run commissionable and operational at the same time since they can't be cleared individually and because there are duplicate records between operational and commissionable. This commit changes the code to use one query responder per advertisement type and gets the ResponseSender to loop through the query responders to filter for answers. * Apply suggestions from code review Co-authored-by: chrisdecenzo <61757564+chrisdecenzo@users.noreply.github.com> * Restyled by clang-format * Fix tests - they were not testing right. * Restyled by clang-format * Update number of responders Represents 5 multi-admin fabrics for operational, commissionable and commissioner. * Whoops - broke a test with my last "minor" change. * Lighten the stack load for the failing test. Co-authored-by: chrisdecenzo <61757564+chrisdecenzo@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io> * [nrfconnect] Stop using cooperative threads (#8025) nRF Connect platform used cooperative threads, that is threads that cannot be preempted, to workaround some synchronization issues in the past, but it's no longer needed and is risky. The latter was revealed by #7927, which caused that `select()` never waits (needs to be fixed in another PR). Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no> * IPV6-only test app for esp32 (examples/ipv6only-app) (#7289) Adds RPCs that conform to NDM/GDM WiFi capabilities. Disables IPV4 DHCP client. Assigns link-local IPV6 address. Starts a UDP echo server on an IPV6 UDP socket. Test: Ran on M5Stack and verified it scanned and connected to wifi, after connected verified it echoed UDP messages. * [ESP32] fix compile error for persistent-storage app (#7940) * [ESP32] fix compile error for persistent-storage app * add CI for all ESP examples * Consolidate error types (#7916) * Consolidate error types #### Problem CHIP currently has `CHIP_ERROR`, `INET_ERROR`, `BLE_ERROR`, `ASN1_ERROR`, `System::Error`. Since they're all integers underneath, there is no type checking, and existing code routinely treats them as interchangeable. There is also existing code that uses `int` and `int32_t`. Each also has a `…_NO_ERROR` code which is independently configurable, but existing code assumes they are equal, and there is exising code that assumes the C convention that the value is 0. #### Change overview Fixes #7688 Unify chip errors This change is largely a mechanical replacement of type and some error code names, with a few cleanups of weak typing. Consolidated error types to one, `CHIP_ERROR`. Removed configurability of `CHIP_NO_ERROR`; it must be 0. Added `CHIP_ERROR_FORMAT` to replace hardcoded `PRI…32` in `printf()` format strings. Added `CHIP_ERROR_SENTINEL` to replace the use of `CHIP_ERROR_MAX` as a sentinel. Renamed or consolidated the following errors, which have the same meaning. Merely similar codes are left alone. This change contains compatibility defintitions to avoid breaking PRs in flight, which will be removed in a followup. | before | after | |:---------------------------------------|:------------------------------------| | ASN1_ERROR | CHIP_ERROR | | ASN1_NO_ERROR | CHIP_NO_ERROR | | BLE_ERROR | CHIP_ERROR | | BLE_NO_ERROR | CHIP_NO_ERROR | | BLE_ERROR_BAD_ARGS | CHIP_ERROR_INVALID_ARGUMENT | | BLE_ERROR_INCORRECT_STATE | CHIP_ERROR_INCORRECT_STATE | | BLE_ERROR_MESSAGE_INCOMPLETE | CHIP_ERROR_MESSAGE_INCOMPLETE | | BLE_ERROR_NOT_IMPLEMENTED | CHIP_ERROR_NOT_IMPLEMENTED | | BLE_ERROR_NO_ENDPOINTS | CHIP_ERROR_ENDPOINT_POOL_FULL | | BLE_ERROR_NO_MEMORY | CHIP_ERROR_NO_MEMORY | | BLE_ERROR_OUTBOUND_MESSAGE_TOO_BIG | CHIP_ERROR_OUTBOUND_MESSAGE_TOO_BIG | | BLE_ERROR_RECEIVED_MESSAGE_TOO_BIG | CHIP_ERROR_INBOUND_MESSAGE_TOO_BIG | | CHIP_SYSTEM_NO_ERROR | CHIP_NO_ERROR | | CHIP_SYSTEM_ERROR_ACCESS_DENIED | CHIP_ERROR_ACCESS_DENIED | | CHIP_SYSTEM_ERROR_BAD_ARGS | CHIP_ERROR_INVALID_ARGUMENT | | CHIP_SYSTEM_ERROR_NOT_SUPPORTED | CHIP_ERROR_UNSUPPORTED_CHIP_FEATURE | | CHIP_SYSTEM_ERROR_NO_MEMORY | CHIP_ERROR_NO_MEMORY | | CHIP_SYSTEM_ERROR_REAL_TIME_NOT_SYNCED | CHIP_ERROR_REAL_TIME_NOT_SYNCED | | CHIP_SYSTEM_ERROR_UNEXPECTED_EVENT | CHIP_ERROR_UNEXPECTED_EVENT | | CHIP_SYSTEM_ERROR_UNEXPECTED_STATE | CHIP_ERROR_INCORRECT_STATE | | INET_ERROR | CHIP_ERROR | | INET_NO_ERROR | CHIP_NO_ERROR | | INET_ERROR_BAD_ARGS | CHIP_ERROR_INVALID_ARGUMENT | | INET_ERROR_INBOUND_MESSAGE_TOO_BIG | CHIP_ERROR_INBOUND_MESSAGE_TOO_BIG | | INET_ERROR_INCORRECT_STATE | CHIP_ERROR_INCORRECT_STATE | | INET_ERROR_MESSAGE_TOO_LONG | CHIP_ERROR_MESSAGE_TOO_LONG | | INET_ERROR_NO_CONNECTION_HANDLER | CHIP_ERROR_NO_CONNECTION_HANDLER | | INET_ERROR_NO_ENDPOINTS | CHIP_ERROR_ENDPOINT_POOL_FULL | | INET_ERROR_NOT_IMPLEMENTED | CHIP_ERROR_NOT_IMPLEMENTED | | INET_ERROR_NOT_SUPPORTED | CHIP_ERROR_UNSUPPORTED_CHIP_FEATURE | | INET_ERROR_NO_MEMORY | CHIP_ERROR_NO_MEMORY | | INET_ERROR_CONNECTION_ABORTED | CHIP_ERROR_CONNECTION_ABORTED | #### Testing Modified some unit tests to account for consolidated error codes. Built locally with `CHIP_ERROR` hardcoded to `int32_t`, `uint32_t`, `int16_t`, and `uint16_t` to shake out mistaken type assumptions. * Build fixes * Darwin * Doxygen * Fixes * Change default CHIP_CONFIG_ERROR_TYPE back to `int32_t`. * Fix CHIP_ERROR_INBOUND_MESSAGE_TOO_BIG message text. * C++-style casts. * fix: CHIPError.h uses stdint.h * zap * fix for Mbed merge * Throw exception instead of return 0 for get-fabricid in case of error (#7884) * Implement User Directed Commissioning - Phase 1 (#8034) * Updated CHIP Certs Implementation to Use Spans instaed of Pointer/Len Pairs. (#7599) Specifically, added the following FixedSpan types: - CertificateKeyId - P256ECDSASignatureSpan - P256PublicKeySpan Also redefined mString member in the ChipRDN structure to be ByteSpan. * Zap use const expr for clusters commands attributes (#7946) * Remove duplicated command ids and attribute ids definitions from the encoder-src.zapt template Add ids/Commands.zapt template Update template to use Commands.h and Clusters.h * Fix XML definitions typos for attributes name * Add ids/Commands.h to the gen folder of src/app/common * Update log messages for session expiry (#8017) * Update log messages for session expiry * update format specifier * Remove client-command-macro.h-aa80d825 from examples/bridge-app/bridge-common/gen (#8026) * Fix Ble endpoint pool FULL on macOS controller (#7806) * * Move naming qpg6100 to qpg (#7936) * Removal Env overrides sdk root and target IC * fix build error in TCP.cpp (#8072) Include <limits> to satisfy the proper use of std::numeric_limits. * Add lighting example for Mbed OS (#8048) * Add back structs, bitmaps and enums of the Messaging cluster into ami… (#8061) * Add back structs, bitmaps and enums of the Messaging cluster into ami.xml * Update gen/ folders * Deprecated ASN1Writer::Finalize() Method. (#8056) * Split KeyValueStoreManager.java into interface and impl, and add Set() in JNI. (#8046) * [Test] Add Test_TC_DM_3_1 (#8067) * Add Test_TC_DM_3_1 to src/app/tests/suites with all tests disabled since the attributes are not present into commissioning.xml * Update generated tests * Followup #7873 - Replace emberAfPutInt8uInResp(ZCL_DEFAULT_RESPONSE_COMMAND_ID) by emberAfPutInt32uInResp(ZCL_DEFAULT_RESPONSE_COMMAND_ID) in src/app/util/util.cpp (#8060) * Remove call-command-handler.cpp from src/controller/data_model/gen/ and from src/darwin/Framework/CHIP.xcodeproj/project.pbxproj (#8021) * Add PID to Darwin/Linux Log Lines (#7657) * Add PID to Darwin/Linux Log Lines Problem: - Debugging test failures that involve multiple instances of applications is difficult when the log lines don't indicate which process/application they're coming from. Solution: - Added PID to the log lines on Darwin & Linux minimally to aid in debugging. Testing: - Ran chip-tool on both platforms. * Restyled by clang-format Co-authored-by: Restyled.io <commits@restyled.io> * Update Darwin framework to use GetConnectedDevice (#8011) * Update Darwin framework to use GetConnectedDevice * address review comments * Add a string circular buffer. (#7475) * Add a string circular buffer. * Update src/lib/support/StringCircularBuffer.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/lib/support/StringCircularBuffer.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/lib/support/StringCircularBuffer.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Resolve comments * Resolve comments * Resolve comments * Resolve comments Co-authored-by: Justin Wood <woody@apple.com> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * [lighting-app] Enable optional Basic Cluster attributes (#8083) * [lighting-app] Enable optional Basic Cluster attributes Enable optional Basic Cluster attributes as requested by Chaintanya, to verify a proper behaviour of the Python controller. * Re-gen code * Add GenerateEventPathList and test (#8014) Summary of Changes: -- Add GenerateEventPathList function in ReadClinet -- Add one event path test and two event path test -- Fix im e2e cirque test in chip_im_responder from PR 7634 since cirque test is not enabled * Have a single loopback transport implementation for tests. (#8045) We have multiple, some with different bells and whistles. Should have one shared thing. Unfortunately, some consumers want to drive things off the loopback (like resending reliable messages) that other consumers can't know about because they are at lower layers of the stack. We just use a virtual hook for that for now. * Don't treat a resolve as done in chip-device-ctrl until we have a CASE connection. (#8012) This ensures that following commands will work instead of racing the CASE connection setup. * Regenerating * Restyled by whitespace * Restyled by google-java-format * Regenerating Co-authored-by: Justin Wood <woody@apple.com> Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Song Guo <songguo@google.com> Co-authored-by: C Freeman <cecille@google.com> Co-authored-by: Vivien Nicolas <vnicolas@apple.com> Co-authored-by: Damian Królik <66667989+Damian-Nordic@users.noreply.github.com> Co-authored-by: chrisdecenzo <61757564+chrisdecenzo@users.noreply.github.com> Co-authored-by: rgoliver <rgoliver@google.com> Co-authored-by: Wang Qixiang <43193572+wqx6@users.noreply.github.com> Co-authored-by: Kevin Schoedel <67607049+kpschoedel@users.noreply.github.com> Co-authored-by: Yufeng Wang <yufengwang@google.com> Co-authored-by: Evgeny Margolis <emargolis@google.com> Co-authored-by: Pankaj Garg <pgarg2@apple.com> Co-authored-by: krypton36 <joshuavillasenor@me.com> Co-authored-by: Timothy Maes <timothy.maes@qorvo.com> Co-authored-by: CodeChronos <1197535+CodeChronos928@users.noreply.github.com> Co-authored-by: Vincent Coubard <vincent.coubard@arm.com> Co-authored-by: Austin Hsieh <77706079+austinh0@users.noreply.github.com> Co-authored-by: Jerry Johns <johnsj@google.com> Co-authored-by: Zang MingJie <zealot0630@gmail.com> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> Co-authored-by: yunhanw-google <yunhanw@google.com>

… Pairs. (project-chip#7599) Specifically, added the following FixedSpan types: - CertificateKeyId - P256ECDSASignatureSpan - P256PublicKeySpan Also redefined mString member in the ChipRDN structure to be ByteSpan.

* add electrical measurement cluster to controller-clusters.zap Only a selection of the optional clusters is enabled. mandatory: - measurement type optional: - total active power - rms voltage - rms voltage min - rms voltage max - rms current - rms current min - rms current max - active power - active power min - active power max * add electrical measurement cluster to zap_cluster_list.py * add electrical measurement cluster to all-clusters-app * add electrical measurement cluster to all-cluster-app/esp32 * add app helpers for electrical measurement cluster * fix all cluster app build * regen all * Regenerating * Restyled by whitespace * Restyled by clang-format * Regenerating * Restyled by whitespace * Restyled by google-java-format * [fix] Wrong callback passed to WriteAttribute in Python[TE4] (project-chip#8019) * Fix callback typr * Run codegen * Mdns: _chip* -> _matter*, remove 0's on subtypes (project-chip#7805) * Mdns: _chip* i-> _matter*, remove 0's on subtypes The second ballot changed the format of the subtypes as well as fixed the service name prefix from _chip* to _matter*. NOTE FOR DEVs: Updating past this change will require updating the devices and controllers as otherwise they will be unable to find each other. * Darwin - use local kLocalDomain var. It includes a . and the one in the ServiceNaming doesn't. * Trying again for Darwin. * Fix host name. * Fix small error on merge * Use a dedicated chip-types.xml file into src/app/zap-templates/zcl (project-chip#7873) * Update chip-types.xml * Update gen/ folders * Revert "Mark UDP socket as ready for write in send msg. (project-chip#7927)" (project-chip#8027) Turns out the code causes that subsequent select()-s never wait so another solution for the original issue must be prepared. This reverts commit 8c55523. * [ZAP] Add isAnalog instead of isDiscreteType to account for string types (project-chip#7821) * Mdns: separate query responders for advertisers (project-chip#7615) * Mdns: separate query responders for advertisers The current setup uses a single query responder for commissionable and operational and all the records are cleared together and added in a large group. This makes it challenging to run commissionable and operational at the same time since they can't be cleared individually and because there are duplicate records between operational and commissionable. This commit changes the code to use one query responder per advertisement type and gets the ResponseSender to loop through the query responders to filter for answers. * Apply suggestions from code review Co-authored-by: chrisdecenzo <61757564+chrisdecenzo@users.noreply.github.com> * Restyled by clang-format * Fix tests - they were not testing right. * Restyled by clang-format * Update number of responders Represents 5 multi-admin fabrics for operational, commissionable and commissioner. * Whoops - broke a test with my last "minor" change. * Lighten the stack load for the failing test. Co-authored-by: chrisdecenzo <61757564+chrisdecenzo@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io> * [nrfconnect] Stop using cooperative threads (project-chip#8025) nRF Connect platform used cooperative threads, that is threads that cannot be preempted, to workaround some synchronization issues in the past, but it's no longer needed and is risky. The latter was revealed by project-chip#7927, which caused that `select()` never waits (needs to be fixed in another PR). Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no> * IPV6-only test app for esp32 (examples/ipv6only-app) (project-chip#7289) Adds RPCs that conform to NDM/GDM WiFi capabilities. Disables IPV4 DHCP client. Assigns link-local IPV6 address. Starts a UDP echo server on an IPV6 UDP socket. Test: Ran on M5Stack and verified it scanned and connected to wifi, after connected verified it echoed UDP messages. * [ESP32] fix compile error for persistent-storage app (project-chip#7940) * [ESP32] fix compile error for persistent-storage app * add CI for all ESP examples * Consolidate error types (project-chip#7916) * Consolidate error types #### Problem CHIP currently has `CHIP_ERROR`, `INET_ERROR`, `BLE_ERROR`, `ASN1_ERROR`, `System::Error`. Since they're all integers underneath, there is no type checking, and existing code routinely treats them as interchangeable. There is also existing code that uses `int` and `int32_t`. Each also has a `…_NO_ERROR` code which is independently configurable, but existing code assumes they are equal, and there is exising code that assumes the C convention that the value is 0. #### Change overview Fixes project-chip#7688 Unify chip errors This change is largely a mechanical replacement of type and some error code names, with a few cleanups of weak typing. Consolidated error types to one, `CHIP_ERROR`. Removed configurability of `CHIP_NO_ERROR`; it must be 0. Added `CHIP_ERROR_FORMAT` to replace hardcoded `PRI…32` in `printf()` format strings. Added `CHIP_ERROR_SENTINEL` to replace the use of `CHIP_ERROR_MAX` as a sentinel. Renamed or consolidated the following errors, which have the same meaning. Merely similar codes are left alone. This change contains compatibility defintitions to avoid breaking PRs in flight, which will be removed in a followup. | before | after | |:---------------------------------------|:------------------------------------| | ASN1_ERROR | CHIP_ERROR | | ASN1_NO_ERROR | CHIP_NO_ERROR | | BLE_ERROR | CHIP_ERROR | | BLE_NO_ERROR | CHIP_NO_ERROR | | BLE_ERROR_BAD_ARGS | CHIP_ERROR_INVALID_ARGUMENT | | BLE_ERROR_INCORRECT_STATE | CHIP_ERROR_INCORRECT_STATE | | BLE_ERROR_MESSAGE_INCOMPLETE | CHIP_ERROR_MESSAGE_INCOMPLETE | | BLE_ERROR_NOT_IMPLEMENTED | CHIP_ERROR_NOT_IMPLEMENTED | | BLE_ERROR_NO_ENDPOINTS | CHIP_ERROR_ENDPOINT_POOL_FULL | | BLE_ERROR_NO_MEMORY | CHIP_ERROR_NO_MEMORY | | BLE_ERROR_OUTBOUND_MESSAGE_TOO_BIG | CHIP_ERROR_OUTBOUND_MESSAGE_TOO_BIG | | BLE_ERROR_RECEIVED_MESSAGE_TOO_BIG | CHIP_ERROR_INBOUND_MESSAGE_TOO_BIG | | CHIP_SYSTEM_NO_ERROR | CHIP_NO_ERROR | | CHIP_SYSTEM_ERROR_ACCESS_DENIED | CHIP_ERROR_ACCESS_DENIED | | CHIP_SYSTEM_ERROR_BAD_ARGS | CHIP_ERROR_INVALID_ARGUMENT | | CHIP_SYSTEM_ERROR_NOT_SUPPORTED | CHIP_ERROR_UNSUPPORTED_CHIP_FEATURE | | CHIP_SYSTEM_ERROR_NO_MEMORY | CHIP_ERROR_NO_MEMORY | | CHIP_SYSTEM_ERROR_REAL_TIME_NOT_SYNCED | CHIP_ERROR_REAL_TIME_NOT_SYNCED | | CHIP_SYSTEM_ERROR_UNEXPECTED_EVENT | CHIP_ERROR_UNEXPECTED_EVENT | | CHIP_SYSTEM_ERROR_UNEXPECTED_STATE | CHIP_ERROR_INCORRECT_STATE | | INET_ERROR | CHIP_ERROR | | INET_NO_ERROR | CHIP_NO_ERROR | | INET_ERROR_BAD_ARGS | CHIP_ERROR_INVALID_ARGUMENT | | INET_ERROR_INBOUND_MESSAGE_TOO_BIG | CHIP_ERROR_INBOUND_MESSAGE_TOO_BIG | | INET_ERROR_INCORRECT_STATE | CHIP_ERROR_INCORRECT_STATE | | INET_ERROR_MESSAGE_TOO_LONG | CHIP_ERROR_MESSAGE_TOO_LONG | | INET_ERROR_NO_CONNECTION_HANDLER | CHIP_ERROR_NO_CONNECTION_HANDLER | | INET_ERROR_NO_ENDPOINTS | CHIP_ERROR_ENDPOINT_POOL_FULL | | INET_ERROR_NOT_IMPLEMENTED | CHIP_ERROR_NOT_IMPLEMENTED | | INET_ERROR_NOT_SUPPORTED | CHIP_ERROR_UNSUPPORTED_CHIP_FEATURE | | INET_ERROR_NO_MEMORY | CHIP_ERROR_NO_MEMORY | | INET_ERROR_CONNECTION_ABORTED | CHIP_ERROR_CONNECTION_ABORTED | #### Testing Modified some unit tests to account for consolidated error codes. Built locally with `CHIP_ERROR` hardcoded to `int32_t`, `uint32_t`, `int16_t`, and `uint16_t` to shake out mistaken type assumptions. * Build fixes * Darwin * Doxygen * Fixes * Change default CHIP_CONFIG_ERROR_TYPE back to `int32_t`. * Fix CHIP_ERROR_INBOUND_MESSAGE_TOO_BIG message text. * C++-style casts. * fix: CHIPError.h uses stdint.h * zap * fix for Mbed merge * Throw exception instead of return 0 for get-fabricid in case of error (project-chip#7884) * Implement User Directed Commissioning - Phase 1 (project-chip#8034) * Updated CHIP Certs Implementation to Use Spans instaed of Pointer/Len Pairs. (project-chip#7599) Specifically, added the following FixedSpan types: - CertificateKeyId - P256ECDSASignatureSpan - P256PublicKeySpan Also redefined mString member in the ChipRDN structure to be ByteSpan. * Zap use const expr for clusters commands attributes (project-chip#7946) * Remove duplicated command ids and attribute ids definitions from the encoder-src.zapt template Add ids/Commands.zapt template Update template to use Commands.h and Clusters.h * Fix XML definitions typos for attributes name * Add ids/Commands.h to the gen folder of src/app/common * Update log messages for session expiry (project-chip#8017) * Update log messages for session expiry * update format specifier * Remove client-command-macro.h-aa80d825 from examples/bridge-app/bridge-common/gen (project-chip#8026) * Fix Ble endpoint pool FULL on macOS controller (project-chip#7806) * * Move naming qpg6100 to qpg (project-chip#7936) * Removal Env overrides sdk root and target IC * fix build error in TCP.cpp (project-chip#8072) Include <limits> to satisfy the proper use of std::numeric_limits. * Add lighting example for Mbed OS (project-chip#8048) * Add back structs, bitmaps and enums of the Messaging cluster into ami… (project-chip#8061) * Add back structs, bitmaps and enums of the Messaging cluster into ami.xml * Update gen/ folders * Deprecated ASN1Writer::Finalize() Method. (project-chip#8056) * Split KeyValueStoreManager.java into interface and impl, and add Set() in JNI. (project-chip#8046) * [Test] Add Test_TC_DM_3_1 (project-chip#8067) * Add Test_TC_DM_3_1 to src/app/tests/suites with all tests disabled since the attributes are not present into commissioning.xml * Update generated tests * Followup project-chip#7873 - Replace emberAfPutInt8uInResp(ZCL_DEFAULT_RESPONSE_COMMAND_ID) by emberAfPutInt32uInResp(ZCL_DEFAULT_RESPONSE_COMMAND_ID) in src/app/util/util.cpp (project-chip#8060) * Remove call-command-handler.cpp from src/controller/data_model/gen/ and from src/darwin/Framework/CHIP.xcodeproj/project.pbxproj (project-chip#8021) * Add PID to Darwin/Linux Log Lines (project-chip#7657) * Add PID to Darwin/Linux Log Lines Problem: - Debugging test failures that involve multiple instances of applications is difficult when the log lines don't indicate which process/application they're coming from. Solution: - Added PID to the log lines on Darwin & Linux minimally to aid in debugging. Testing: - Ran chip-tool on both platforms. * Restyled by clang-format Co-authored-by: Restyled.io <commits@restyled.io> * Update Darwin framework to use GetConnectedDevice (project-chip#8011) * Update Darwin framework to use GetConnectedDevice * address review comments * Add a string circular buffer. (project-chip#7475) * Add a string circular buffer. * Update src/lib/support/StringCircularBuffer.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/lib/support/StringCircularBuffer.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/lib/support/StringCircularBuffer.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Resolve comments * Resolve comments * Resolve comments * Resolve comments Co-authored-by: Justin Wood <woody@apple.com> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * [lighting-app] Enable optional Basic Cluster attributes (project-chip#8083) * [lighting-app] Enable optional Basic Cluster attributes Enable optional Basic Cluster attributes as requested by Chaintanya, to verify a proper behaviour of the Python controller. * Re-gen code * Add GenerateEventPathList and test (project-chip#8014) Summary of Changes: -- Add GenerateEventPathList function in ReadClinet -- Add one event path test and two event path test -- Fix im e2e cirque test in chip_im_responder from PR 7634 since cirque test is not enabled * Have a single loopback transport implementation for tests. (project-chip#8045) We have multiple, some with different bells and whistles. Should have one shared thing. Unfortunately, some consumers want to drive things off the loopback (like resending reliable messages) that other consumers can't know about because they are at lower layers of the stack. We just use a virtual hook for that for now. * Don't treat a resolve as done in chip-device-ctrl until we have a CASE connection. (project-chip#8012) This ensures that following commands will work instead of racing the CASE connection setup. * Regenerating * Restyled by whitespace * Restyled by google-java-format * Regenerating Co-authored-by: Justin Wood <woody@apple.com> Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Song Guo <songguo@google.com> Co-authored-by: C Freeman <cecille@google.com> Co-authored-by: Vivien Nicolas <vnicolas@apple.com> Co-authored-by: Damian Królik <66667989+Damian-Nordic@users.noreply.github.com> Co-authored-by: chrisdecenzo <61757564+chrisdecenzo@users.noreply.github.com> Co-authored-by: rgoliver <rgoliver@google.com> Co-authored-by: Wang Qixiang <43193572+wqx6@users.noreply.github.com> Co-authored-by: Kevin Schoedel <67607049+kpschoedel@users.noreply.github.com> Co-authored-by: Yufeng Wang <yufengwang@google.com> Co-authored-by: Evgeny Margolis <emargolis@google.com> Co-authored-by: Pankaj Garg <pgarg2@apple.com> Co-authored-by: krypton36 <joshuavillasenor@me.com> Co-authored-by: Timothy Maes <timothy.maes@qorvo.com> Co-authored-by: CodeChronos <1197535+CodeChronos928@users.noreply.github.com> Co-authored-by: Vincent Coubard <vincent.coubard@arm.com> Co-authored-by: Austin Hsieh <77706079+austinh0@users.noreply.github.com> Co-authored-by: Jerry Johns <johnsj@google.com> Co-authored-by: Zang MingJie <zealot0630@gmail.com> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> Co-authored-by: yunhanw-google <yunhanw@google.com>

boring-cyborg bot added the transport label Jun 14, 2021

pullapprove bot requested review from andy31415, bzbarsky-apple, chrisdecenzo, Damian-Nordic, hawk248, jepenven-silabs and msandstedt June 14, 2021 15:06

pullapprove bot added the review - pending label Jun 14, 2021

msandstedt approved these changes Jun 14, 2021

View reviewed changes

saurabhst approved these changes Jun 14, 2021

View reviewed changes

woody-apple approved these changes Jun 15, 2021

View reviewed changes

emargolis force-pushed the feature/emargolis/chip-cert-use-spans branch from 7cfaa44 to e4f93b7 Compare June 15, 2021 18:37

mspang reviewed Jun 15, 2021

View reviewed changes

src/credentials/CHIPCert.h Outdated Show resolved Hide resolved

src/credentials/CHIPCert.h Outdated Show resolved Hide resolved

mspang requested changes Jun 15, 2021

View reviewed changes

emargolis requested a review from mspang June 15, 2021 19:20

bzbarsky-apple reviewed Jun 16, 2021

View reviewed changes

woody-apple force-pushed the feature/emargolis/chip-cert-use-spans branch from e4f93b7 to 9cbe214 Compare June 16, 2021 06:06

emargolis force-pushed the feature/emargolis/chip-cert-use-spans branch from 9cbe214 to 059a1f5 Compare June 16, 2021 13:53

boring-cyborg bot added controller crypto lib labels Jun 16, 2021

emargolis requested a review from bzbarsky-apple June 16, 2021 13:53

pullapprove bot requested a review from bhaskar-apple June 16, 2021 13:54

woody-apple force-pushed the feature/emargolis/chip-cert-use-spans branch from 059a1f5 to 9343149 Compare June 17, 2021 01:48

bzbarsky-apple approved these changes Jun 17, 2021

View reviewed changes

woody-apple added the has conflicts label Jun 21, 2021

emargolis force-pushed the feature/emargolis/chip-cert-use-spans branch from 9343149 to 36cabff Compare June 21, 2021 23:02

emargolis force-pushed the feature/emargolis/chip-cert-use-spans branch from 36cabff to 92e830e Compare June 23, 2021 00:07

mspang requested changes Jun 24, 2021

View reviewed changes

src/credentials/CHIPCert.h Outdated Show resolved Hide resolved

emargolis force-pushed the feature/emargolis/chip-cert-use-spans branch from 2aa280c to 94668f5 Compare June 26, 2021 08:52

mspang approved these changes Jun 30, 2021

View reviewed changes

src/credentials/CHIPCert.h Outdated Show resolved Hide resolved

mspang added the technical review - DONE label Jun 30, 2021

pullapprove bot added review - approved technical review - DONE and removed review - pending technical review - DONE labels Jun 30, 2021

Updated CHIP Certs Implementation to Use Spans instaed of Pointer/Len…

088320b

… Pairs. Specifically, added the following FixedSpan types: - CertificateKeyId - P256ECDSASignatureSpan - P256PublicKeySpan Also redefined mString member in the ChipRDN structure to be ByteSpan.

emargolis force-pushed the feature/emargolis/chip-cert-use-spans branch from 94668f5 to 088320b Compare June 30, 2021 21:44

msandstedt merged commit 08b5650 into project-chip:master Jul 1, 2021

emargolis mentioned this pull request Jul 21, 2021

Review and consider replacing some data pointer/len pairs with ByteSpan and Fixe... #7458

Closed

emargolis deleted the feature/emargolis/chip-cert-use-spans branch December 14, 2021 10:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated CHIP Certs to Use Spans Instead of Pointer/Len Pairs #7599

Updated CHIP Certs to Use Spans Instead of Pointer/Len Pairs #7599

emargolis commented Jun 14, 2021 •

edited by mspang

Loading

woody-apple commented Jun 15, 2021

mspang left a comment

woody-apple commented Jun 16, 2021

woody-apple commented Jun 17, 2021

woody-apple commented Jun 21, 2021

woody-apple commented Jun 22, 2021

emargolis commented Jun 26, 2021

github-actions bot commented Jun 26, 2021

github-actions bot commented Jun 26, 2021

github-actions bot commented Jun 26, 2021

emargolis commented Jun 29, 2021

mspang commented Jun 30, 2021

emargolis commented Jun 30, 2021

Updated CHIP Certs to Use Spans Instead of Pointer/Len Pairs #7599

Updated CHIP Certs to Use Spans Instead of Pointer/Len Pairs #7599

Conversation

emargolis commented Jun 14, 2021 • edited by mspang Loading

Problem

Change overview

Testing

woody-apple commented Jun 15, 2021

mspang left a comment

Choose a reason for hiding this comment

woody-apple commented Jun 16, 2021

woody-apple commented Jun 17, 2021

woody-apple commented Jun 21, 2021

woody-apple commented Jun 22, 2021

emargolis commented Jun 26, 2021

github-actions bot commented Jun 26, 2021

github-actions bot commented Jun 26, 2021

github-actions bot commented Jun 26, 2021

emargolis commented Jun 29, 2021

mspang commented Jun 30, 2021

emargolis commented Jun 30, 2021

emargolis commented Jun 14, 2021 •

edited by mspang

Loading