Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve get last report data path api in cluster state cache #23431

Merged
merged 1 commit into from
Nov 17, 2022
Merged

improve get last report data path api in cluster state cache #23431

merged 1 commit into from
Nov 17, 2022

Conversation

yunhanw-google
Copy link
Contributor

https://github.com/project-chip/connectedhomeip/pull/22851/files#diff-fa9b920825db40167f8aaa6d9a9f746b8e7c50823eefbc629b234e10f84b51c7R486
Refactor GetLastReportDataPath a little bit so that it would fail when the path is not valid concrete cluster path, and update the corresponding logic in UpdateClusterDataVersion in AndroidCallback.

@yunhanw-google yunhanw-google marked this pull request as ready for review November 2, 2022 07:19
@github-actions github-actions bot added the app label Nov 2, 2022
@github-actions
Copy link

github-actions bot commented Nov 2, 2022 •
edited
Loading

PR #23431: Size comparison from 887822a to de3e4a6

Increases (5 builds for cc13x2_26x2, nrfconnect, psoc6, telink)
platform target config section 887822a de3e4a6 change % change
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 642111 642119 8 0.0
.text 562768 562776 8 0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 805330 805334 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 26899491 26899492 1 0.0
telink light-switch-app tlsr9518adk80d text 554266 554268 2 0.0
ota-requestor-app tlsr9518adk80d text 565284 565288 4 0.0
Decreases (2 builds for esp32, psoc6)
platform target config section 887822a de3e4a6 change % change
esp32 all-clusters-app c3devkit (read only) 1223970 1223968 -2 -0.0
.flash.text 1223970 1223968 -2 -0.0
psoc6 light cy8ckit_062s2_43012 .debug_info 22097475 22097474 -1 -0.0
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 887822a de3e4a6 change % change
bl602 lighting-app bl602 (read/write) 1390518 1390518 0 0.0
.bss 90745 90745 0 0.0
.data 9936 9936 0 0.0
.text 1069814 1069814 0 0.0
bl602+rpc (read/write) 1435974 1435974 0 0.0
.bss 98177 98177 0 0.0
.data 10320 10320 0 0.0
.text 1101416 1101416 0 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1189323 1189323 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67134 67134 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4280 4280 0 0.0
.debug_abbrev 1509373 1509373 0 0.0
.debug_aranges 132040 132040 0 0.0
.debug_frame 484428 484428 0 0.0
.debug_info 37964828 37964828 0 0.0
.debug_line 5257208 5257208 0 0.0
.debug_loc 3366388 3366388 0 0.0
.debug_ranges 358064 358064 0 0.0
.debug_str 3451542 3451542 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116616 116616 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 565954 565954 0 0.0
.symtab 171968 171968 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
957780 957780 0 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1285251 1285251 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75166 75166 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4816 4816 0 0.0
.debug_abbrev 1646772 1646772 0 0.0
.debug_aranges 139544 139544 0 0.0
.debug_frame 509800 509800 0 0.0
.debug_info 41877796 41877796 0 0.0
.debug_line 5632788 5632788 0 0.0
.debug_loc 3559215 3559215 0 0.0
.debug_ranges 380864 380864 0 0.0
.debug_str 3847670 3847670 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130024 130024 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 625127 625127 0 0.0
.symtab 189776 189776 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1031486 1031486 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 677871 677871 0 0.0
(read/write) 173688 173688 0 0.0
.bss 81252 81252 0 0.0
.data 3380 3380 0 0.0
.rodata 89887 89887 0 0.0
.text 587672 587672 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 642111 642119 8 0.0
(read/write) 158020 158020 0 0.0
.bss 80524 80524 0 0.0
.data 3380 3380 0 0.0
.rodata 79023 79023 0 0.0
.text 562768 562776 8 0.0
lock-ftd LP_CC2652R7 (read only) 676379 676379 0 0.0
(read/write) 172316 172316 0 0.0
.bss 78476 78476 0 0.0
.data 3304 3304 0 0.0
.rodata 77411 77411 0 0.0
.text 598488 598488 0 0.0
lock-mtd LP_CC2652R7 (read only) 660167 660167 0 0.0
(read/write) 184216 184216 0 0.0
.bss 74164 74164 0 0.0
.data 3304 3304 0 0.0
.rodata 103263 103263 0 0.0
.text 556424 556424 0 0.0
pump-app LP_CC2652R7 (read only) 688635 688635 0 0.0
(read/write) 160796 160796 0 0.0
.bss 78444 78444 0 0.0
.data 3296 3296 0 0.0
.rodata 90859 90859 0 0.0
.text 597292 597292 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672911 672911 0 0.0
(read/write) 176616 176616 0 0.0
.bss 78540 78540 0 0.0
.data 3292 3292 0 0.0
.rodata 86407 86407 0 0.0
.text 586024 586024 0 0.0
shell LP_CC2652R7 (read only) 668890 668890 0 0.0
(read/write) 184988 184988 0 0.0
.bss 83572 83572 0 0.0
.data 3376 3376 0 0.0
.rodata 86594 86594 0 0.0
.text 581980 581980 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588542 588542 0 0.0
.app_xip_area 465128 465128 0 0.0
.bss 65832 65832 0 0.0
.data 760 760 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592590 592590 0 0.0
.app_xip_area 463880 463880 0 0.0
.bss 71120 71120 0 0.0
.data 768 768 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 544474 544474 0 0.0
.app_xip_area 426140 426140 0 0.0
.bss 60800 60800 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974732 974732 0 0.0
.bss 152276 152276 0 0.0
.data 2248 2248 0 0.0
.text 820188 820188 0 0.0
BRD4161A+rs911x (read/write) 1034672 1034672 0 0.0
.bss 186744 186744 0 0.0
.data 2092 2092 0 0.0
.text 845812 845812 0 0.0
BRD4187C (read/write) 1146720 1146720 0 0.0
.bss 138664 138664 0 0.0
.data 2596 2596 0 0.0
.text 980864 980864 0 0.0
lock-app BRD4161A+wf200 (read/write) 1160424 1160424 0 0.0
.bss 158272 158272 0 0.0
.data 2100 2100 0 0.0
.text 1000032 1000032 0 0.0
window-app BRD4187C (read/write) 1139940 1139940 0 0.0
.bss 140080 140080 0 0.0
.data 2620 2620 0 0.0
.text 972644 972644 0 0.0
esp32 all-clusters-app c3devkit (read only) 1223970 1223968 -2 -0.0
(read/write) 1788470 1788470 0 0.0
.dram0.bss 76960 76960 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 258024 258024 0 0.0
.flash.text 1223970 1223968 -2 -0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1234039 1234039 0 0.0
(read/write) 564396 564396 0 0.0
.dram0.bss 82336 82336 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 315096 315096 0 0.0
.flash.text 1228655 1228655 0 0.0
.iram0.text 123939 123939 0 0.0
k32w contact k32w0+release (read/write) 661676 661676 0 0.0
.bss 77040 77040 0 0.0
.data 2104 2104 0 0.0
.text 563420 563420 0 0.0
light k32w0+release (read/write) 672008 672008 0 0.0
.bss 74840 74840 0 0.0
.data 2060 2060 0 0.0
.text 592380 592380 0 0.0
lock k32w0+release (read/write) 633484 633484 0 0.0
.bss 75600 75600 0 0.0
.data 2080 2080 0 0.0
.text 553076 553076 0 0.0
linux all-clusters-app debug (read only) 3086657 3086657 0 0.0
(read/write) 158360 158360 0 0.0
.bss 62464 62464 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 87016 87016 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1200 1200 0 0.0
.rodata 281419 281419 0 0.0
.text 2620850 2620850 0 0.0
all-clusters-minimal-app debug (read only) 2912449 2912449 0 0.0
(read/write) 149792 149792 0 0.0
.bss 61664 61664 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 79384 79384 0 0.0
.dynamic 608 608 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 1176 1176 0 0.0
.rodata 280907 280907 0 0.0
.text 2450098 2450098 0 0.0
bridge-app debug+rpc (read only) 2412801 2412801 0 0.0
(read/write) 129560 129560 0 0.0
.bss 51008 51008 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 68680 68680 0 0.0
.dynamic 608 608 0 0.0
.got 4600 4600 0 0.0
.init 27 27 0 0.0
.init_array 848 848 0 0.0
.rodata 211232 211232 0 0.0
.text 2034018 2034018 0 0.0
chip-tool debug (read only) 11081345 11081345 0 0.0
(read/write) 658440 658440 0 0.0
.bss 25944 25944 0 0.0
.data 2754 2754 0 0.0
.data.rel.ro 623080 623080 0 0.0
.dynamic 608 608 0 0.0
.got 5216 5216 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 592221 592221 0 0.0
.text 8965204 8965204 0 0.0
chip-tool-ipv6only arm64 (read only) 10436396 10436396 0 0.0
(read/write) 706465 706465 0 0.0
.bss 33953 33953 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 650720 650720 0 0.0
.dynamic 560 560 0 0.0
.got 13928 13928 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 518220 518220 0 0.0
.text 8262340 8262340 0 0.0
lighting-app debug+rpc (read only) 2640233 2640233 0 0.0
(read/write) 132248 132248 0 0.0
.bss 49984 49984 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 73800 73800 0 0.0
.dynamic 608 608 0 0.0
.got 4600 4600 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 228096 228096 0 0.0
.text 2236162 2236162 0 0.0
lock-app debug (read only) 2602241 2602241 0 0.0
(read/write) 127296 127296 0 0.0
.bss 48416 48416 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 70728 70728 0 0.0
.dynamic 608 608 0 0.0
.got 4672 4672 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 244328 244328 0 0.0
.text 2186306 2186306 0 0.0
ota-provider-app debug (read only) 2398777 2398777 0 0.0
(read/write) 120824 120824 0 0.0
.bss 47936 47936 0 0.0
.data 2128 2128 0 0.0
.data.rel.ro 64648 64648 0 0.0
.dynamic 608 608 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 216904 216904 0 0.0
.text 2013330 2013330 0 0.0
ota-requestor-app debug (read only) 2563961 2563961 0 0.0
(read/write) 129136 129136 0 0.0
.bss 50464 50464 0 0.0
.data 2496 2496 0 0.0
.data.rel.ro 69992 69992 0 0.0
.dynamic 608 608 0 0.0
.got 4688 4688 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 223952 223952 0 0.0
.text 2162370 2162370 0 0.0
shell debug (read only) 2626433 2626433 0 0.0
(read/write) 143016 143016 0 0.0
.bss 57864 57864 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78064 78064 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 240178 240178 0 0.0
.text 2226610 2226610 0 0.0
thermostat-no-ble arm64 (read only) 2392844 2392844 0 0.0
(read/write) 143665 143665 0 0.0
.bss 55377 55377 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77280 77280 0 0.0
.dynamic 560 560 0 0.0
.got 5184 5184 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 144548 144548 0 0.0
.text 2005296 2005296 0 0.0
tv-app debug (read only) 3236713 3236713 0 0.0
(read/write) 261752 261752 0 0.0
.bss 170552 170552 0 0.0
.data 4256 4256 0 0.0
.data.rel.ro 80272 80272 0 0.0
.dynamic 608 608 0 0.0
.got 4976 4976 0 0.0
.init 27 27 0 0.0
.init_array 1080 1080 0 0.0
.rodata 268184 268184 0 0.0
.text 2775186 2775186 0 0.0
tv-casting-app debug (read only) 5585641 5585641 0 0.0
(read/write) 161896 161896 0 0.0
.bss 52120 52120 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 101224 101224 0 0.0
.dynamic 608 608 0 0.0
.got 4896 4896 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 355961 355961 0 0.0
.text 4954226 4954226 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452768 2452768 0 0.0
.bss 215028 215028 0 0.0
.data 5872 5872 0 0.0
.text 1415412 1415412 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1188191 1188191 0 0.0
bss 145301 145301 0 0.0
rodata 144836 144836 0 0.0
text 816996 816996 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1167475 1167475 0 0.0
bss 144528 144528 0 0.0
rodata 136576 136576 0 0.0
text 805330 805334 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841952 841952 0 0.0
(read/write) 1745940 1745940 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188728 188728 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1231262 1231262 0 0.0
.debug_aranges 110712 110712 0 0.0
.debug_frame 371204 371204 0 0.0
.debug_info 26899491 26899492 1 0.0
.debug_line 3673871 3673871 0 0.0
.debug_loc 3588816 3588816 0 0.0
.debug_ranges 337960 337960 0 0.0
.debug_str 3435299 3435299 0 0.0
.heap 841952 841952 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 570460 570460 0 0.0
.symtab 421744 421744 0 0.0
.text 1546160 1546160 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842688 842688 0 0.0
(read/write) 1688548 1688548 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187992 187992 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1223105 1223105 0 0.0
.debug_aranges 110184 110184 0 0.0
.debug_frame 374284 374284 0 0.0
.debug_info 26636121 26636121 0 0.0
.debug_line 3694663 3694663 0 0.0
.debug_loc 3576453 3576453 0 0.0
.debug_ranges 336576 336576 0 0.0
.debug_str 3424320 3424320 0 0.0
.heap 842688 842688 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 534549 534549 0 0.0
.symtab 408176 408176 0 0.0
.text 1489504 1489504 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850872 850872 0 0.0
(read/write) 1607004 1607004 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180016 180016 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1057613 1057613 0 0.0
.debug_aranges 102384 102384 0 0.0
.debug_frame 344600 344600 0 0.0
.debug_info 22097475 22097474 -1 -0.0
.debug_line 3264197 3264197 0 0.0
.debug_loc 3274179 3274179 0 0.0
.debug_ranges 301872 301872 0 0.0
.debug_str 3229759 3229759 0 0.0
.heap 850872 850872 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 470874 470874 0 0.0
.symtab 376560 376560 0 0.0
.text 1416144 1416144 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845880 845880 0 0.0
(read/write) 1640780 1640780 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184992 184992 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1059619 1059619 0 0.0
.debug_aranges 102784 102784 0 0.0
.debug_frame 346472 346472 0 0.0
.debug_info 22330842 22330842 0 0.0
.debug_line 3261187 3261187 0 0.0
.debug_loc 3301773 3301773 0 0.0
.debug_ranges 303816 303816 0 0.0
.debug_str 3249234 3249234 0 0.0
.heap 845880 845880 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473277 473277 0 0.0
.symtab 378240 378240 0 0.0
.text 1444928 1444928 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1149968 1149968 0 0.0
.bss 110612 110612 0 0.0
.data 848 848 0 0.0
.text 597068 597068 0 0.0
lock-app qpg6105+debug (read/write) 1114760 1114760 0 0.0
.bss 106388 106388 0 0.0
.data 836 836 0 0.0
.text 561856 561856 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 790820 790820 0 0.0
bss 72480 72480 0 0.0
noinit 43520 43520 0 0.0
text 554266 554268 2 0.0
lighting-app tlsr9518adk80d (read/write) 806068 806068 0 0.0
bss 73240 73240 0 0.0
noinit 43520 43520 0 0.0
text 566414 566414 0 0.0
ota-requestor-app tlsr9518adk80d (read/write) 804952 804952 0 0.0
bss 74052 74052 0 0.0
noinit 43520 43520 0 0.0
text 565284 565288 4 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Nov 17, 2022
View reviewed changes
src/app/ClusterStateCache.cpp Outdated Show resolved Hide resolved
@yunhanw-google
improve get last report data path api in cluster cache
5398027 
-- Return not found error if the last report data path is not concrete cluster path
-- Add doxygen
@yunhanw-google yunhanw-google force-pushed the feature/improve_get_last_report_path branch from de3e4a6 to 5398027 Compare November 17, 2022 04:52
@yunhanw-google yunhanw-google enabled auto-merge (squash) November 17, 2022 04:53
@github-actions
Copy link

github-actions bot commented Nov 17, 2022 •
edited
Loading

PR #23431: Size comparison from cf45410 to 5398027

Increases (7 builds for bl702, esp32, psoc6, telink)
platform target config section cf45410 5398027 change % change
bl702 lighting-app bl702 (read/write) 1195687 1195703 16 0.0
.debug_info 39163596 39163597 1 0.0
.text 956000 956002 2 0.0
bl702+rpc .debug_info 43432797 43432798 1 0.0
.text 1029698 1029700 2 0.0
esp32 all-clusters-app m5stack (read/write) 562500 562508 8 0.0
.flash.rodata 313480 313488 8 0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26763962 26763964 2 0.0
telink all-clusters-app tlsr9518adk80d text 649054 649056 2 0.0
lighting-app tlsr9518adk80d text 624466 624468 2 0.0
ota-requestor-app tlsr9518adk80d text 565882 565884 2 0.0
Decreases (4 builds for bl602, esp32, psoc6, telink)
platform target config section cf45410 5398027 change % change
bl602 lighting-app bl602 .text 1059742 1059740 -2 -0.0
esp32 all-clusters-app c3devkit (read only) 1213488 1213486 -2 -0.0
.flash.text 1213488 1213486 -2 -0.0
psoc6 light cy8ckit_062s2_43012 .debug_info 22229174 22229173 -1 -0.0
telink light-switch-app tlsr9518adk80d text 554504 554502 -2 -0.0
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section cf45410 5398027 change % change
bl602 lighting-app bl602 (read/write) 1375890 1375890 0 0.0
.bss 90041 90041 0 0.0
.data 9984 9984 0 0.0
.text 1059742 1059740 -2 -0.0
bl602+rpc (read/write) 1421714 1421714 0 0.0
.bss 98081 98081 0 0.0
.data 10376 10376 0 0.0
.text 1091236 1091236 0 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1195687 1195703 16 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67166 67166 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1524109 1524109 0 0.0
.debug_aranges 132328 132328 0 0.0
.debug_frame 485344 485344 0 0.0
.debug_info 39163596 39163597 1 0.0
.debug_line 5273272 5273272 0 0.0
.debug_loc 3368326 3368326 0 0.0
.debug_ranges 360440 360440 0 0.0
.debug_str 3463589 3463589 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116568 116568 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 566910 566910 0 0.0
.symtab 171888 171888 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
956000 956002 2 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1283843 1283843 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75214 75214 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4576 4576 0 0.0
.debug_abbrev 1668139 1668139 0 0.0
.debug_aranges 140392 140392 0 0.0
.debug_frame 512548 512548 0 0.0
.debug_info 43432797 43432798 1 0.0
.debug_line 5668641 5668641 0 0.0
.debug_loc 3562561 3562561 0 0.0
.debug_ranges 383464 383464 0 0.0
.debug_str 3860904 3860904 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130200 130200 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 627125 627125 0 0.0
.symtab 190000 190000 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1029698 1029700 2 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 678427 678427 0 0.0
(read/write) 173108 173108 0 0.0
.bss 81228 81228 0 0.0
.data 3380 3380 0 0.0
.rodata 89851 89851 0 0.0
.text 588264 588264 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 642723 642723 0 0.0
(read/write) 157996 157996 0 0.0
.bss 80500 80500 0 0.0
.data 3380 3380 0 0.0
.rodata 78987 78987 0 0.0
.text 563416 563416 0 0.0
lock-ftd LP_CC2652R7 (read only) 676559 676559 0 0.0
(read/write) 172544 172544 0 0.0
.bss 78884 78884 0 0.0
.data 3304 3304 0 0.0
.rodata 77271 77271 0 0.0
.text 598808 598808 0 0.0
lock-mtd LP_CC2652R7 (read only) 661115 661115 0 0.0
(read/write) 183244 183244 0 0.0
.bss 74140 74140 0 0.0
.data 3304 3304 0 0.0
.rodata 103315 103315 0 0.0
.text 557320 557320 0 0.0
pump-app LP_CC2652R7 (read only) 689055 689055 0 0.0
(read/write) 160784 160784 0 0.0
.bss 78852 78852 0 0.0
.data 3296 3296 0 0.0
.rodata 90767 90767 0 0.0
.text 597804 597804 0 0.0
pump-controller-app LP_CC2652R7 (read only) 673339 673339 0 0.0
(read/write) 176596 176596 0 0.0
.bss 78948 78948 0 0.0
.data 3292 3292 0 0.0
.rodata 86315 86315 0 0.0
.text 586544 586544 0 0.0
shell LP_CC2652R7 (read only) 669646 669646 0 0.0
(read/write) 184208 184208 0 0.0
.bss 83548 83548 0 0.0
.data 3376 3376 0 0.0
.rodata 86598 86598 0 0.0
.text 582732 582732 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 587494 587494 0 0.0
.app_xip_area 463704 463704 0 0.0
.bss 66208 66208 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 591602 591602 0 0.0
.app_xip_area 462516 462516 0 0.0
.bss 71496 71496 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 543978 543978 0 0.0
.app_xip_area 425708 425708 0 0.0
.bss 60736 60736 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974500 974500 0 0.0
.bss 152260 152260 0 0.0
.data 2168 2168 0 0.0
.text 820052 820052 0 0.0
BRD4161A+rs911x (read/write) 1035280 1035280 0 0.0
.bss 186736 186736 0 0.0
.data 2012 2012 0 0.0
.text 846508 846508 0 0.0
BRD4187C (read/write) 1147096 1147096 0 0.0
.bss 138656 138656 0 0.0
.data 2516 2516 0 0.0
.text 981328 981328 0 0.0
lock-app BRD4161A+wf200 (read/write) 1160480 1160480 0 0.0
.bss 158264 158264 0 0.0
.data 2020 2020 0 0.0
.text 1000172 1000172 0 0.0
window-app BRD4187C (read/write) 1140316 1140316 0 0.0
.bss 140072 140072 0 0.0
.data 2540 2540 0 0.0
.text 973108 973108 0 0.0
esp32 all-clusters-app c3devkit (read only) 1213488 1213486 -2 -0.0
(read/write) 1786542 1786542 0 0.0
.dram0.bss 76680 76680 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 256368 256368 0 0.0
.flash.text 1213488 1213486 -2 -0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1224347 1224347 0 0.0
(read/write) 562500 562508 8 0.0
.dram0.bss 82056 82056 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 313480 313488 8 0.0
.flash.text 1218963 1218963 0 0.0
.iram0.text 123939 123939 0 0.0
k32w contact k32w0+release (read/write) 662052 662052 0 0.0
.bss 77112 77112 0 0.0
.data 2104 2104 0 0.0
.text 563724 563724 0 0.0
light k32w0+release (read/write) 672112 672112 0 0.0
.bss 74912 74912 0 0.0
.data 2060 2060 0 0.0
.text 592412 592412 0 0.0
lock k32w0+release (read/write) 633612 633612 0 0.0
.bss 75672 75672 0 0.0
.data 2080 2080 0 0.0
.text 553132 553132 0 0.0
linux all-clusters-app debug (read only) 3077497 3077497 0 0.0
(read/write) 158472 158472 0 0.0
.bss 62464 62464 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 87144 87144 0 0.0
.dynamic 608 608 0 0.0
.got 4768 4768 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 281291 281291 0 0.0
.text 2611714 2611714 0 0.0
all-clusters-minimal-app debug (read only) 2903161 2903161 0 0.0
(read/write) 149872 149872 0 0.0
.bss 61664 61664 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 79512 79512 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 280747 280747 0 0.0
.text 2440962 2440962 0 0.0
bridge-app debug+rpc (read only) 2402113 2402113 0 0.0
(read/write) 129608 129608 0 0.0
.bss 51008 51008 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 68776 68776 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 210944 210944 0 0.0
.text 2023810 2023810 0 0.0
chip-tool debug (read only) 11071057 11071057 0 0.0
(read/write) 658464 658464 0 0.0
.bss 25912 25912 0 0.0
.data 2754 2754 0 0.0
.data.rel.ro 623200 623200 0 0.0
.dynamic 608 608 0 0.0
.got 5184 5184 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 592133 592133 0 0.0
.text 8955220 8955220 0 0.0
chip-tool-ipv6only arm64 (read only) 10424668 10424668 0 0.0
(read/write) 706529 706529 0 0.0
.bss 33905 33905 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 650832 650832 0 0.0
.dynamic 560 560 0 0.0
.got 13928 13928 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 518380 518380 0 0.0
.text 8250500 8250500 0 0.0
lighting-app debug+rpc (read only) 2633137 2633137 0 0.0
(read/write) 132456 132456 0 0.0
.bss 49984 49984 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 73992 73992 0 0.0
.dynamic 608 608 0 0.0
.got 4632 4632 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 227808 227808 0 0.0
.text 2228626 2228626 0 0.0
lock-app debug (read only) 2592393 2592393 0 0.0
(read/write) 127376 127376 0 0.0
.bss 48416 48416 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 70840 70840 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 244136 244136 0 0.0
.text 2176546 2176546 0 0.0
ota-provider-app debug (read only) 2388561 2388561 0 0.0
(read/write) 120904 120904 0 0.0
.bss 47936 47936 0 0.0
.data 2128 2128 0 0.0
.data.rel.ro 64760 64760 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 216616 216616 0 0.0
.text 2003394 2003394 0 0.0
ota-requestor-app debug (read only) 2553825 2553825 0 0.0
(read/write) 129248 129248 0 0.0
.bss 50464 50464 0 0.0
.data 2496 2496 0 0.0
.data.rel.ro 70120 70120 0 0.0
.dynamic 608 608 0 0.0
.got 4672 4672 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 223696 223696 0 0.0
.text 2152482 2152482 0 0.0
shell debug (read only) 2614657 2614657 0 0.0
(read/write) 142968 142968 0 0.0
.bss 57864 57864 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78040 78040 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 239474 239474 0 0.0
.text 2215666 2215666 0 0.0
thermostat-no-ble arm64 (read only) 2384076 2384076 0 0.0
(read/write) 143665 143665 0 0.0
.bss 55329 55329 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77256 77256 0 0.0
.dynamic 560 560 0 0.0
.got 5192 5192 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 144948 144948 0 0.0
.text 1995232 1995232 0 0.0
tv-app debug (read only) 3246737 3246737 0 0.0
(read/write) 261992 261992 0 0.0
.bss 170648 170648 0 0.0
.data 4256 4256 0 0.0
.data.rel.ro 80384 80384 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 268504 268504 0 0.0
.text 2784242 2784242 0 0.0
tv-casting-app debug (read only) 5572785 5572785 0 0.0
(read/write) 161880 161880 0 0.0
.bss 52120 52120 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 101216 101216 0 0.0
.dynamic 608 608 0 0.0
.got 4912 4912 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 355321 355321 0 0.0
.text 4941794 4941794 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452664 2452664 0 0.0
.bss 215012 215012 0 0.0
.data 5872 5872 0 0.0
.text 1415308 1415308 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1188159 1188159 0 0.0
bss 145285 145285 0 0.0
rodata 144516 144516 0 0.0
text 817284 817284 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1167587 1167587 0 0.0
bss 144512 144512 0 0.0
rodata 136304 136304 0 0.0
text 805834 805834 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841968 841968 0 0.0
(read/write) 1746780 1746780 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188712 188712 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1235857 1235857 0 0.0
.debug_aranges 110728 110728 0 0.0
.debug_frame 371396 371396 0 0.0
.debug_info 27027332 27027332 0 0.0
.debug_line 3687492 3687492 0 0.0
.debug_loc 3606214 3606214 0 0.0
.debug_ranges 339928 339928 0 0.0
.debug_str 3432484 3432484 0 0.0
.heap 841968 841968 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 570636 570636 0 0.0
.symtab 421600 421600 0 0.0
.text 1547016 1547016 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842704 842704 0 0.0
(read/write) 1689316 1689316 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187976 187976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1227700 1227700 0 0.0
.debug_aranges 110200 110200 0 0.0
.debug_frame 374476 374476 0 0.0
.debug_info 26763962 26763964 2 0.0
.debug_line 3708476 3708476 0 0.0
.debug_loc 3593820 3593820 0 0.0
.debug_ranges 338544 338544 0 0.0
.debug_str 3421504 3421504 0 0.0
.heap 842704 842704 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 534725 534725 0 0.0
.symtab 408032 408032 0 0.0
.text 1490288 1490288 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850888 850888 0 0.0
(read/write) 1607492 1607492 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180000 180000 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1062161 1062161 0 0.0
.debug_aranges 102400 102400 0 0.0
.debug_frame 344788 344788 0 0.0
.debug_info 22229174 22229173 -1 -0.0
.debug_line 3277603 3277603 0 0.0
.debug_loc 3291305 3291305 0 0.0
.debug_ranges 303824 303824 0 0.0
.debug_str 3227039 3227039 0 0.0
.heap 850888 850888 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 471050 471050 0 0.0
.symtab 376400 376400 0 0.0
.text 1416648 1416648 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845896 845896 0 0.0
(read/write) 1641500 1641500 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184976 184976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1064136 1064136 0 0.0
.debug_aranges 102800 102800 0 0.0
.debug_frame 346664 346664 0 0.0
.debug_info 22462797 22462797 0 0.0
.debug_line 3274723 3274723 0 0.0
.debug_loc 3319158 3319158 0 0.0
.debug_ranges 305784 305784 0 0.0
.debug_str 3246396 3246396 0 0.0
.heap 845896 845896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473453 473453 0 0.0
.symtab 378096 378096 0 0.0
.text 1445664 1445664 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1151104 1151104 0 0.0
.bss 111116 111116 0 0.0
.data 848 848 0 0.0
.text 598204 598204 0 0.0
lock-app qpg6105+debug (read/write) 1116800 1116800 0 0.0
.bss 106564 106564 0 0.0
.data 836 836 0 0.0
.text 563896 563896 0 0.0
telink all-clusters-app tlsr9518adk80d (read/write) 937728 937728 0 0.0
bss 81620 81620 0 0.0
noinit 43440 43440 0 0.0
text 649054 649056 2 0.0
all-clusters-minimal-app tlsr9518adk80d (read/write) 875720 875720 0 0.0
bss 80844 80844 0 0.0
noinit 43440 43440 0 0.0
text 613040 613040 0 0.0
light-switch-app tlsr9518adk80d (read/write) 791076 791076 0 0.0
bss 72468 72468 0 0.0
noinit 43520 43520 0 0.0
text 554504 554502 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 875300 875300 0 0.0
bss 82232 82232 0 0.0
noinit 43520 43520 0 0.0
text 624466 624468 2 0.0
ota-requestor-app tlsr9518adk80d (read/write) 805568 805568 0 0.0
bss 74040 74040 0 0.0
noinit 43520 43520 0 0.0
text 565882 565884 2 0.0

@yunhanw-google yunhanw-google merged commit c1bfd9d into project-chip:master Nov 17, 2022
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this pull request Nov 18, 2022
@yunhanw-google @adbridge
improve get last report data path api in cluster cache (project-chip#…
153e16a 
…23431)

-- Return not found error if the last report data path is not concrete cluster path
-- Add doxygen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yufengwangca yufengwangca yufengwangca approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yunhanw-google @yufengwangca @bzbarsky-apple