Skip to content

Commit

Permalink
Upload diagnostic logs on Darwin if the build+unit-test task fails. (#…
Browse files Browse the repository at this point in the history
…9891)

This might allow us some slightly better visibility into unit test
crashes on Darwin.
  • Loading branch information
bzbarsky-apple authored and pull[bot] committed Oct 1, 2021
1 parent f024f16 commit 1607492
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,9 @@ jobs:
submodules: true
- name: Setup Environment
run: brew install openssl pkg-config
- name: Try to ensure the directory for diagnostic log collection exists
run: |
mkdir -p ~/Library/Logs/DiagnosticReports || true
- name: Fix pkgconfig link
working-directory: /usr/local/lib/pkgconfig
run: |
Expand Down Expand Up @@ -292,6 +295,12 @@ jobs:
scripts/build/gn_build.sh
scripts/tests/gn_tests.sh
done
- name: Uploading diagnostic logs
uses: actions/upload-artifact@v2
if: ${{ failure() }} && ${{ !env.ACT }}
with:
name: crash-log-darwin
path: ~/Library/Logs/DiagnosticReports/
# TODO Log Upload https://github.com/project-chip/connectedhomeip/issues/2227
# TODO https://github.com/project-chip/connectedhomeip/issues/1512
# - name: Run Code Coverage
Expand Down

0 comments on commit 1607492

Please sign in to comment.