Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove not used OnDiscoveryExpiration callback #21496

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Remove not used OnDiscoveryExpiration callback #21496

merged 1 commit into from
Aug 2, 2022
+0 −7

Conversation

woody-apple
Copy link
Contributor

Problem

It seems that this callback definition is a leftover from PR #20007.

Change overview

  • removed not used callback definition

Testing

CI will test that.

@github-actions
Copy link

github-actions bot commented Aug 1, 2022 •
edited
Loading

PR #21496: Size comparison from 59ecf97 to 8529409

Increases (3 builds for bl602, esp32, k32w)
platform target config section 59ecf97 8529409 change % change
bl602 lighting-app bl602 (read/write) 1382250 1382258 8 0.0
.text 1052364 1052368 4 0.0
esp32 all-clusters-app c3devkit (read only) 1023870 1023872 2 0.0
.flash.text 1023870 1023872 2 0.0
k32w lock k32w0+release (read/write) 700608 700624 16 0.0
.text 625668 625684 16 0.0
Decreases (2 builds for bl602, nrfconnect)
platform target config section 59ecf97 8529409 change % change
bl602 lighting-app bl602+rpc .text 1084060 1084056 -4 -0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 804220 804216 -4 -0.0
Full report (30 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6)
platform target config section 59ecf97 8529409 change % change
bl602 lighting-app bl602 (read/write) 1382250 1382258 8 0.0
.bss 117626 117626 0 0.0
.data 4480 4480 0 0.0
.text 1052364 1052368 4 0.0
bl602+rpc (read/write) 1427682 1427682 0 0.0
.bss 125066 125066 0 0.0
.data 4600 4600 0 0.0
.text 1084060 1084056 -4 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 669139 669139 0 0.0
(read/write) 182220 182220 0 0.0
.bss 74252 74252 0 0.0
.data 3372 3372 0 0.0
.rodata 88283 88283 0 0.0
.text 580540 580540 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 634659 634659 0 0.0
(read/write) 157828 157828 0 0.0
.bss 73540 73540 0 0.0
.data 3372 3372 0 0.0
.rodata 77507 77507 0 0.0
.text 556828 556828 0 0.0
lock-ftd LP_CC2652R7 (read only) 671999 671999 0 0.0
(read/write) 169544 169544 0 0.0
.bss 71324 71324 0 0.0
.data 3296 3296 0 0.0
.rodata 76351 76351 0 0.0
.text 595168 595168 0 0.0
lock-mtd LP_CC2652R7 (read only) 654283 654283 0 0.0
(read/write) 182948 182948 0 0.0
.bss 67012 67012 0 0.0
.data 3296 3296 0 0.0
.rodata 101107 101107 0 0.0
.text 552696 552696 0 0.0
pump-app LP_CC2652R7 (read only) 681055 681055 0 0.0
(read/write) 161320 161320 0 0.0
.bss 71388 71388 0 0.0
.data 3296 3296 0 0.0
.rodata 88919 88919 0 0.0
.text 591652 591652 0 0.0
pump-controller-app LP_CC2652R7 (read only) 666631 666631 0 0.0
(read/write) 175880 175880 0 0.0
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84743 84743 0 0.0
.text 581408 581408 0 0.0
shell LP_CC2652R7 (read only) 661838 661838 0 0.0
(read/write) 185040 185040 0 0.0
.bss 76572 76572 0 0.0
.data 3376 3376 0 0.0
.rodata 85262 85262 0 0.0
.text 576260 576260 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583742 583742 0 0.0
.app_xip_area 460696 460696 0 0.0
.bss 65632 65632 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589654 589654 0 0.0
.app_xip_area 461880 461880 0 0.0
.bss 70360 70360 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589458 589458 0 0.0
.app_xip_area 467220 467220 0 0.0
.bss 64880 64880 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1088960 1088960 0 0.0
.bss 133268 133268 0 0.0
.data 2064 2064 0 0.0
.text 953608 953608 0 0.0
BRD4161A+rpc (read/write) 1143300 1143300 0 0.0
.bss 149948 149948 0 0.0
.data 2276 2276 0 0.0
.text 991056 991056 0 0.0
BRD4161A+rs911x (read/write) 974256 974256 0 0.0
.bss 161744 161744 0 0.0
.data 2048 2048 0 0.0
.text 810444 810444 0 0.0
lock-app BRD4161A+wf200 (read/write) 1129216 1129216 0 0.0
.bss 144376 144376 0 0.0
.data 2056 2056 0 0.0
.text 982764 982764 0 0.0
window-app BRD4161A (read/write) 1082252 1082252 0 0.0
.bss 134748 134748 0 0.0
.data 2092 2092 0 0.0
.text 945388 945388 0 0.0
esp32 all-clusters-app c3devkit (read only) 1023870 1023872 2 0.0
(read/write) 1486602 1486602 0 0.0
.dram0.bss 70312 70312 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216248 216248 0 0.0
.flash.text 1023870 1023872 2 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1077319 1077319 0 0.0
(read/write) 488624 488624 0 0.0
.dram0.bss 75824 75824 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246660 246660 0 0.0
.flash.text 1071935 1071935 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 643368 643368 0 0.0
.bss 69720 69720 0 0.0
.data 2044 2044 0 0.0
.text 568876 568876 0 0.0
lock k32w0+release (read/write) 700608 700624 16 0.0
.bss 70160 70160 0 0.0
.data 2052 2052 0 0.0
.text 625668 625684 16 0.0
linux chip-tool-ipv6only arm64 (read only) 9854044 9854044 0 0.0
(read/write) 676865 676865 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 622200 622200 0 0.0
.dynamic 560 560 0 0.0
.got 13536 13536 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 469468 469468 0 0.0
.text 7806564 7806564 0 0.0
thermostat-no-ble arm64 (read only) 2349308 2349308 0 0.0
(read/write) 141761 141761 0 0.0
.bss 55329 55329 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75976 75976 0 0.0
.dynamic 560 560 0 0.0
.got 5016 5016 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139316 139316 0 0.0
.text 1972480 1972480 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452344 2452344 0 0.0
.bss 214532 214532 0 0.0
.data 5872 5872 0 0.0
.text 1414988 1414988 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180071 1180071 0 0.0
bss 143204 143204 0 0.0
rodata 142928 142928 0 0.0
text 815060 815060 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159959 1159959 0 0.0
bss 142440 142440 0 0.0
rodata 134456 134456 0 0.0
text 804220 804216 -4 -0.0
p6 all-clusters-app default (read only) 881544 881544 0 0.0
(read/write) 1688300 1688300 0 0.0
.bss 149152 149152 0 0.0
.data 2648 2648 0 0.0
.text 1528112 1528112 0 0.0
all-clusters-minimal-app default (read only) 882272 882272 0 0.0
(read/write) 1632324 1632324 0 0.0
.bss 148424 148424 0 0.0
.data 2648 2648 0 0.0
.text 1472864 1472864 0 0.0
light-app default (read only) 890568 890568 0 0.0
(read/write) 1553348 1553348 0 0.0
.bss 140336 140336 0 0.0
.data 2440 2440 0 0.0
.text 1402184 1402184 0 0.0
lock-app default (read only) 886096 886096 0 0.0
(read/write) 1591012 1591012 0 0.0
.bss 144792 144792 0 0.0
.data 2456 2456 0 0.0
.text 1435376 1435376 0 0.0

@woody-apple woody-apple force-pushed the cherry-pick-65f9af5fd129931558e2c02702b941ca02384288 branch from 8529409 to cc93c15 Compare August 1, 2022 21:59
@github-actions
Copy link

github-actions bot commented Aug 1, 2022 •
edited
Loading

PR #21496: Size comparison from c5e7ab6 to cc93c15

Increases (1 build for bl602)
platform target config section c5e7ab6 cc93c15 change % change
bl602 lighting-app bl602+rpc .text 1084056 1084060 4 0.0
Full report (11 builds for bl602, esp32, mbed, nrfconnect, p6)
platform target config section c5e7ab6 cc93c15 change % change
bl602 lighting-app bl602 (read/write) 1382250 1382250 0 0.0
.bss 117626 117626 0 0.0
.data 4480 4480 0 0.0
.text 1052364 1052364 0 0.0
bl602+rpc (read/write) 1427682 1427682 0 0.0
.bss 125066 125066 0 0.0
.data 4600 4600 0 0.0
.text 1084056 1084060 4 0.0
esp32 all-clusters-app c3devkit (read only) 1024394 1024394 0 0.0
(read/write) 1487042 1487042 0 0.0
.dram0.bss 70336 70336 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216672 216672 0 0.0
.flash.text 1024394 1024394 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1077863 1077863 0 0.0
(read/write) 489064 489064 0 0.0
.dram0.bss 75840 75840 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 247084 247084 0 0.0
.flash.text 1072479 1072479 0 0.0
.iram0.text 123267 123267 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2453224 2453224 0 0.0
.bss 214548 214548 0 0.0
.data 5872 5872 0 0.0
.text 1415868 1415868 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180935 1180935 0 0.0
bss 143224 143224 0 0.0
rodata 143344 143344 0 0.0
text 815508 815508 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1160811 1160811 0 0.0
bss 142460 142460 0 0.0
rodata 134876 134876 0 0.0
text 804656 804656 0 0.0
p6 all-clusters-app default (read only) 881528 881528 0 0.0
(read/write) 1689268 1689268 0 0.0
.bss 149168 149168 0 0.0
.data 2648 2648 0 0.0
.text 1529064 1529064 0 0.0
all-clusters-minimal-app default (read only) 882248 882248 0 0.0
(read/write) 1633300 1633300 0 0.0
.bss 148448 148448 0 0.0
.data 2648 2648 0 0.0
.text 1473816 1473816 0 0.0
light-app default (read only) 890568 890568 0 0.0
(read/write) 1553348 1553348 0 0.0
.bss 140336 140336 0 0.0
.data 2440 2440 0 0.0
.text 1402184 1402184 0 0.0
lock-app default (read only) 886072 886072 0 0.0
(read/write) 1591988 1591988 0 0.0
.bss 144816 144816 0 0.0
.data 2456 2456 0 0.0
.text 1436328 1436328 0 0.0

@woody-apple woody-apple merged commit fa7686f into sve Aug 2, 2022
@woody-apple woody-apple deleted the cherry-pick-65f9af5fd129931558e2c02702b941ca02384288 branch August 2, 2022 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
sve cherry pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woody-apple @arkq