-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove not used OnDiscoveryExpiration callback #21496
Merged
woody-apple
merged 1 commit into
sve
from
cherry-pick-65f9af5fd129931558e2c02702b941ca02384288
Aug 2, 2022
Merged
Remove not used OnDiscoveryExpiration callback #21496
woody-apple
merged 1 commit into
sve
from
cherry-pick-65f9af5fd129931558e2c02702b941ca02384288
Aug 2, 2022
+0
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #21496: Size comparison from 59ecf97 to 8529409 Increases (3 builds for bl602, esp32, k32w)
Decreases (2 builds for bl602, nrfconnect)
Full report (30 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6)
|
It seems that this is a leftover from #20007.
woody-apple
force-pushed
the
cherry-pick-65f9af5fd129931558e2c02702b941ca02384288
branch
from
August 1, 2022 21:59
8529409
to
cc93c15
Compare
PR #21496: Size comparison from c5e7ab6 to cc93c15 Increases (1 build for bl602)
Full report (11 builds for bl602, esp32, mbed, nrfconnect, p6)
|
woody-apple
deleted the
cherry-pick-65f9af5fd129931558e2c02702b941ca02384288
branch
August 2, 2022 00:44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It seems that this callback definition is a leftover from PR #20007.
Change overview
Testing
CI will test that.