Stop duplicating advertisement timeout handling. #20007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commissioning window manager handles advertisement start/stop. We don't need per-advertisement-mechanism duplication of timeout timers. Specific changes: 1) Remove the "stop advertisement" timing from the (few) platform BLE managers that did it. 2) Remove CHIP_DEVICE_CONFIG_BLE_ADVERTISING_TIMEOUT altogether. 3) Remove commissioning advertisement timing from Dnssd.cpp. 4) Remove the Linux shell command for setting the "discovery timeout", because it's really not clear what it's supposed to do and how it should work. Fixes project-chip#16693
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple and
kpschoedel
pullapprove
bot
requested review from
msandstedt,
mspang,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
|
PR #20007: Size comparison from 9b3668c to 30c9ac7 Increases (6 builds for cc13x2_26x2)
Decreases (49 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (49 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
tcarmelveilleux
approved these changes
Jun 27, 2022
woody-apple
approved these changes
Jun 27, 2022
arkq
added a commit
to arkq/connectedhomeip
that referenced
this pull request
Aug 1, 2022
It seems that this is a leftover from project-chip#20007.
woody-apple
pushed a commit
that referenced
this pull request
Aug 1, 2022
It seems that this is a leftover from #20007.
github-actions bot
pushed a commit
that referenced
this pull request
Aug 1, 2022
It seems that this is a leftover from #20007.
woody-apple
pushed a commit
that referenced
this pull request
Aug 1, 2022
It seems that this is a leftover from #20007.
woody-apple
added a commit
that referenced
this pull request
Aug 2, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
It seems that this is a leftover from project-chip#20007.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commissioning window manager handles advertisement start/stop. We
don't need per-advertisement-mechanism duplication of timeout timers.
Specific changes:
that did it.
it's really not clear what it's supposed to do and how it should work.
Fixes #16693
Problem
Multiple disagreeing timers that are trying to time the same thing (e.g. some of the BLE implementations actually set the timer for the wrong time period in practice).
Change overview
Just have the one source of truth for commissioning advertising (the commissioning window manager) handle this.
Testing
Verified that if I enable extended discovery in all-clusters-app and start it uncommissioned, it advertises commissionable for the right time period over DNS-SD, then switches to the extended discovery advertising at the right point. And that if extended discovery is not enabled, it just stops advertising
_matterc._udpat all.