Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove not used OnDiscoveryExpiration callback #21486

Merged
merged 1 commit into from
Aug 1, 2022
Merged

Remove not used OnDiscoveryExpiration callback #21486

merged 1 commit into from
Aug 1, 2022

Conversation

arkq
Copy link
Contributor

@arkq arkq commented Aug 1, 2022

Problem

It seems that this callback definition is a leftover from PR #20007.

Change overview

  • removed not used callback definition

Testing

CI will test that.

@github-actions github-actions bot added the app label Aug 1, 2022
@github-actions
Copy link

github-actions bot commented Aug 1, 2022 •
edited
Loading

PR #21486: Size comparison from 17c8da6 to cd25ecb

Increases (2 builds for bl602, telink)
platform target config section 17c8da6 cd25ecb change % change
bl602 lighting-app bl602+rpc .text 1084272 1084276 4 0.0
telink light-switch-app tlsr9518adk80d text 569266 569268 2 0.0
Decreases (1 build for esp32)
platform target config section 17c8da6 cd25ecb change % change
esp32 all-clusters-app c3devkit (read only) 1023764 1023760 -4 -0.0
.flash.text 1023764 1023760 -4 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 17c8da6 cd25ecb change % change
bl602 lighting-app bl602 (read/write) 1382498 1382498 0 0.0
.bss 117626 117626 0 0.0
.data 4480 4480 0 0.0
.text 1052608 1052608 0 0.0
bl602+rpc (read/write) 1427898 1427898 0 0.0
.bss 125066 125066 0 0.0
.data 4600 4600 0 0.0
.text 1084272 1084276 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 669307 669307 0 0.0
(read/write) 182052 182052 0 0.0
.bss 74252 74252 0 0.0
.data 3372 3372 0 0.0
.rodata 88283 88283 0 0.0
.text 580708 580708 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 634827 634827 0 0.0
(read/write) 157828 157828 0 0.0
.bss 73540 73540 0 0.0
.data 3372 3372 0 0.0
.rodata 77507 77507 0 0.0
.text 556996 556996 0 0.0
lock-ftd LP_CC2652R7 (read only) 672295 672295 0 0.0
(read/write) 169248 169248 0 0.0
.bss 71324 71324 0 0.0
.data 3296 3296 0 0.0
.rodata 76351 76351 0 0.0
.text 595464 595464 0 0.0
lock-mtd LP_CC2652R7 (read only) 654563 654563 0 0.0
(read/write) 182668 182668 0 0.0
.bss 67012 67012 0 0.0
.data 3296 3296 0 0.0
.rodata 101107 101107 0 0.0
.text 552976 552976 0 0.0
pump-app LP_CC2652R7 (read only) 681359 681359 0 0.0
(read/write) 161016 161016 0 0.0
.bss 71388 71388 0 0.0
.data 3296 3296 0 0.0
.rodata 88919 88919 0 0.0
.text 591956 591956 0 0.0
pump-controller-app LP_CC2652R7 (read only) 666935 666935 0 0.0
(read/write) 175576 175576 0 0.0
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84743 84743 0 0.0
.text 581712 581712 0 0.0
shell LP_CC2652R7 (read only) 662030 662030 0 0.0
(read/write) 184848 184848 0 0.0
.bss 76572 76572 0 0.0
.data 3376 3376 0 0.0
.rodata 85262 85262 0 0.0
.text 576452 576452 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584046 584046 0 0.0
.app_xip_area 460856 460856 0 0.0
.bss 65632 65632 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589966 589966 0 0.0
.app_xip_area 462048 462048 0 0.0
.bss 70360 70360 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589754 589754 0 0.0
.app_xip_area 467372 467372 0 0.0
.bss 64880 64880 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1088976 1088976 0 0.0
.bss 133268 133268 0 0.0
.data 2064 2064 0 0.0
.text 953624 953624 0 0.0
BRD4161A+rpc (read/write) 1143284 1143284 0 0.0
.bss 149948 149948 0 0.0
.data 2276 2276 0 0.0
.text 991040 991040 0 0.0
BRD4161A+rs911x (read/write) 974960 974960 0 0.0
.bss 161744 161744 0 0.0
.data 2048 2048 0 0.0
.text 811148 811148 0 0.0
lock-app BRD4161A+wf200 (read/write) 1129576 1129576 0 0.0
.bss 144376 144376 0 0.0
.data 2056 2056 0 0.0
.text 983124 983124 0 0.0
window-app BRD4161A (read/write) 1082268 1082268 0 0.0
.bss 134748 134748 0 0.0
.data 2092 2092 0 0.0
.text 945404 945404 0 0.0
esp32 all-clusters-app c3devkit (read only) 1023764 1023760 -4 -0.0
(read/write) 1486602 1486602 0 0.0
.dram0.bss 70312 70312 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216248 216248 0 0.0
.flash.text 1023764 1023760 -4 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1077235 1077235 0 0.0
(read/write) 488624 488624 0 0.0
.dram0.bss 75824 75824 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246660 246660 0 0.0
.flash.text 1071851 1071851 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 643448 643448 0 0.0
.bss 69720 69720 0 0.0
.data 2044 2044 0 0.0
.text 568956 568956 0 0.0
lock k32w0+release (read/write) 700896 700896 0 0.0
.bss 70160 70160 0 0.0
.data 2052 2052 0 0.0
.text 625956 625956 0 0.0
linux all-clusters-app debug (read only) 3011161 3011161 0 0.0
(read/write) 155680 155680 0 0.0
.bss 61856 61856 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85384 85384 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 270859 270859 0 0.0
.text 2561442 2561442 0 0.0
all-clusters-minimal-app debug (read only) 2852897 2852897 0 0.0
(read/write) 147448 147448 0 0.0
.bss 61120 61120 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 77992 77992 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 270827 270827 0 0.0
.text 2405842 2405842 0 0.0
bridge-app debug+rpc (read only) 2360689 2360689 0 0.0
(read/write) 127576 127576 0 0.0
.bss 50592 50592 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67544 67544 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 202056 202056 0 0.0
.text 1995650 1995650 0 0.0
chip-tool debug (read only) 10495441 10495441 0 0.0
(read/write) 642424 642424 0 0.0
.bss 24856 24856 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 607800 607800 0 0.0
.dynamic 608 608 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 538165 538165 0 0.0
.text 8470564 8470564 0 0.0
chip-tool-ipv6only arm64 (read only) 9904356 9904356 0 0.0
(read/write) 690049 690049 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 635336 635336 0 0.0
.dynamic 560 560 0 0.0
.got 13592 13592 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 470212 470212 0 0.0
.text 7816660 7816660 0 0.0
lighting-app debug+rpc (read only) 2583145 2583145 0 0.0
(read/write) 130224 130224 0 0.0
.bss 49728 49728 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72456 72456 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 217712 217712 0 0.0
.text 2194386 2194386 0 0.0
lock-app debug (read only) 2569473 2569473 0 0.0
(read/write) 125528 125528 0 0.0
.bss 48224 48224 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69592 69592 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 234896 234896 0 0.0
.text 2167586 2167586 0 0.0
ota-provider-app debug (read only) 2351689 2351689 0 0.0
(read/write) 119040 119040 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63416 63416 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 208184 208184 0 0.0
.text 1979650 1979650 0 0.0
ota-requestor-app debug (read only) 2472297 2472297 0 0.0
(read/write) 126432 126432 0 0.0
.bss 50176 50176 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 68072 68072 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 211744 211744 0 0.0
.text 2088082 2088082 0 0.0
shell debug (read only) 2582801 2582801 0 0.0
(read/write) 141832 141832 0 0.0
.bss 57768 57768 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77008 77008 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 231890 231890 0 0.0
.text 2192706 2192706 0 0.0
thermostat-no-ble arm64 (read only) 2349916 2349916 0 0.0
(read/write) 141761 141761 0 0.0
.bss 55329 55329 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75976 75976 0 0.0
.dynamic 560 560 0 0.0
.got 5016 5016 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139316 139316 0 0.0
.text 1973088 1973088 0 0.0
tv-app debug (read only) 3154241 3154241 0 0.0
(read/write) 257736 257736 0 0.0
.bss 167352 167352 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79104 79104 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 255720 255720 0 0.0
.text 2708946 2708946 0 0.0
tv-casting-app debug (read only) 5389337 5389337 0 0.0
(read/write) 158720 158720 0 0.0
.bss 51384 51384 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98504 98504 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 339057 339057 0 0.0
.text 4783010 4783010 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452408 2452408 0 0.0
.bss 214532 214532 0 0.0
.data 5872 5872 0 0.0
.text 1415052 1415052 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1175611 1175611 0 0.0
bss 143204 143204 0 0.0
rodata 142204 142204 0 0.0
text 811344 811344 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1155515 1155515 0 0.0
bss 142440 142440 0 0.0
rodata 133732 133732 0 0.0
text 800504 800504 0 0.0
p6 all-clusters-app default (read only) 881544 881544 0 0.0
(read/write) 1688140 1688140 0 0.0
.bss 149152 149152 0 0.0
.data 2648 2648 0 0.0
.text 1527952 1527952 0 0.0
all-clusters-minimal-app default (read only) 882272 882272 0 0.0
(read/write) 1632164 1632164 0 0.0
.bss 148424 148424 0 0.0
.data 2648 2648 0 0.0
.text 1472704 1472704 0 0.0
light-app default (read only) 890568 890568 0 0.0
(read/write) 1553396 1553396 0 0.0
.bss 140336 140336 0 0.0
.data 2440 2440 0 0.0
.text 1402232 1402232 0 0.0
lock-app default (read only) 886096 886096 0 0.0
(read/write) 1591060 1591060 0 0.0
.bss 144792 144792 0 0.0
.data 2456 2456 0 0.0
.text 1435424 1435424 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805408 805408 0 0.0
bss 70976 70976 0 0.0
noinit 43488 43488 0 0.0
text 569266 569268 2 0.0
lighting-app tlsr9518adk80d (read/write) 825848 825848 0 0.0
bss 71820 71820 0 0.0
noinit 43488 43488 0 0.0
text 586156 586156 0 0.0

@woody-apple woody-apple added the sve label Aug 1, 2022
@woody-apple woody-apple merged commit 65f9af5 into project-chip:master Aug 1, 2022
github-actions bot pushed a commit that referenced this pull request Aug 1, 2022
@arkq @web-flow
Remove not used OnDiscoveryExpiration callback (#21486)
8529409 
It seems that this is a leftover from #20007.
@arkq arkq deleted the dns-timeout-cleanup branch August 1, 2022 21:11
woody-apple pushed a commit that referenced this pull request Aug 1, 2022
@arkq @woody-apple
Remove not used OnDiscoveryExpiration callback (#21486)
cc93c15 
It seems that this is a leftover from #20007.
woody-apple added a commit that referenced this pull request Aug 2, 2022
@woody-apple @arkq
Remove not used OnDiscoveryExpiration callback (#21486) (#21496)
fa7686f 
It seems that this is a leftover from #20007.

Co-authored-by: Arkadiusz Bokowy <a.bokowy@samsung.com>
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@arkq @isiu-apple
Remove not used OnDiscoveryExpiration callback (project-chip#21486)
2040fed 
It seems that this is a leftover from project-chip#20007.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msandstedt msandstedt msandstedt approved these changes

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app review - approved sve
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arkq @msandstedt @Damian-Nordic @woody-apple