Skip to content

Commit

Permalink
Fix NetworkCommissioning Cluster issues (#32156)
Browse files Browse the repository at this point in the history
* Fix NetworkCommissioning Cluster issues

This PR addresses several NetworkCommissioning issues
which are all inter-related:

- Attributes are never reported on change.
- ScanNetworks used to modify attributes that should not be modified
- LastNetworkStatus was not set where required
- Thread network scanning did not report error on SSID field provided
- All ConstraintErrors actually were reported as InvalidCommand
- Lacking results of directed scanning did not report NetworkNotFound

- Fixes #32024
- Fixes #32022
- Fixes #32021
- Fixes #32019
- Fixes #32018
- Fixes #31870

Testing done:
- TC-CNET-4.4 pass on ESP32 and Linux
- Commissioning works on ESP32 and Linux
- Manual testing of all attribute changes validated with chip-repl
  - Automated test beyond TC-CNET-4.4 coming as a follow-up

* Restyled by clang-format

* Fix a Release call missing

* Fix one Release too many

* Apply review comments

* Restyled by clang-format

---------

Co-authored-by: Restyled.io <commits@restyled.io>
  • Loading branch information
2 people authored and pull[bot] committed May 3, 2024
1 parent e23a9c6 commit 59e3cc5
Show file tree
Hide file tree
Showing 7 changed files with 492 additions and 55 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1770,6 +1770,7 @@ endpoint 0 {
ram attribute lastNetworkingStatus;
ram attribute lastNetworkID;
ram attribute lastConnectErrorValue;
callback attribute supportedWiFiBands;
callback attribute generatedCommandList;
callback attribute acceptedCommandList;
callback attribute eventList;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1452,6 +1452,22 @@
"maxInterval": 65534,
"reportableChange": 0
},
{
"name": "SupportedWiFiBands",
"code": 8,
"mfgCode": null,
"side": "server",
"type": "array",
"included": 1,
"storageOption": "External",
"singleton": 0,
"bounded": 0,
"defaultValue": null,
"reportable": 1,
"minInterval": 1,
"maxInterval": 65534,
"reportableChange": 0
},
{
"name": "GeneratedCommandList",
"code": 65528,
Expand Down
Loading

0 comments on commit 59e3cc5

Please sign in to comment.