Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug][NetworkCommissioning] All command constraint errors lead to InvalidCommand instead of ConstraintError #32018

Closed
tcarmelveilleux opened this issue Feb 8, 2024 · 0 comments · Fixed by #32156
Closed

[Bug][NetworkCommissioning] All command constraint errors lead to InvalidCommand instead of ConstraintError #32018

tcarmelveilleux opened this issue Feb 8, 2024 · 0 comments · Fixed by #32156
Assignees
@tcarmelveilleux
Labels
bug Something isn't working commissioning Involves placing devices on the network, initial setup NetworkCommissioning issues spec Mismatch between spec and implementation utility-cluster Work for Utility Clusters
Milestone
1.3 SVE

Comments

@tcarmelveilleux
Copy link
Contributor

  • In NetworkCommissioning cluster, code inspection showed that ConstraintError is almost never used and most cases return InvalidCommand or Failure instead, which is not DM spec compliant.
  • Affects 1.0 through 1.3 up to fix.
  • Likely was not caught because of insufficient error coverage in cert test cases.
@tcarmelveilleux tcarmelveilleux added bug Something isn't working utility-cluster Work for Utility Clusters commissioning Involves placing devices on the network, initial setup labels Feb 8, 2024
@tcarmelveilleux tcarmelveilleux added this to the 1.3 SVE milestone Feb 8, 2024
@tcarmelveilleux tcarmelveilleux self-assigned this Feb 8, 2024
@tcarmelveilleux tcarmelveilleux added spec Mismatch between spec and implementation NetworkCommissioning issues labels Feb 8, 2024
tcarmelveilleux added a commit to tcarmelveilleux/connectedhomeip that referenced this issue Feb 15, 2024
@tcarmelveilleux
Fix NetworkCommissioning Cluster issues
4fbe075 
This PR addresses several NetworkCommissioning issues
which are all inter-related:

- Attributes are never reported on change.
- ScanNetworks used to modify attributes that should not be modified
- LastNetworkStatus was not set where required
- Thread network scanning did not report error on SSID field provided
- All ConstraintErrors actually were reported as InvalidCommand
- Lacking results of directed scanning did not report NetworkNotFound

- Fixes project-chip#32024
- Fixes project-chip#32022
- Fixes project-chip#32021
- Fixes project-chip#32019
- Fixes project-chip#32018
- Fixes project-chip#31870

Testing done:
- TC-CNET-4.4 pass on ESP32 and Linux
- Commissioning works on ESP32 and Linux
- Manual testing of all attribute changes validated with chip-repl
  - Automated test beyond TC-CNET-4.4 coming as a follow-up
@tcarmelveilleux tcarmelveilleux mentioned this issue Feb 15, 2024
Merged
@mergify mergify bot closed this as completed in #32156 Feb 16, 2024
@mergify mergify bot closed this as completed in a04f478 Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tcarmelveilleux tcarmelveilleux

Labels
bug Something isn't working commissioning Involves placing devices on the network, initial setup NetworkCommissioning issues spec Mismatch between spec and implementation utility-cluster Work for Utility Clusters
Projects
[Certification] Blockers
Archived in project
[Enhancements] Spec/XML Alignment
Archived in project
Milestone
1.3 SVE
Development

Successfully merging a pull request may close this issue.

Fix NetworkCommissioning Cluster issues tcarmelveilleux/connectedhomeip
1 participant
@tcarmelveilleux