[Bug] [NetworkCommissioning] All non-fixed attributes are not reported on update #32024
Assignees
Labels
bug
Something isn't working
commissioning
Involves placing devices on the network, initial setup
NetworkCommissioning issues
spec
Mismatch between spec and implementation
utility-cluster
Work for Utility Clusters
Milestone
Comments
tcarmelveilleux
added
bug
tcarmelveilleux
added a commit
to tcarmelveilleux/connectedhomeip
that referenced
this issue
Feb 15, 2024
This PR addresses several NetworkCommissioning issues which are all inter-related: - Attributes are never reported on change. - ScanNetworks used to modify attributes that should not be modified - LastNetworkStatus was not set where required - Thread network scanning did not report error on SSID field provided - All ConstraintErrors actually were reported as InvalidCommand - Lacking results of directed scanning did not report NetworkNotFound - Fixes project-chip#32024 - Fixes project-chip#32022 - Fixes project-chip#32021 - Fixes project-chip#32019 - Fixes project-chip#32018 - Fixes project-chip#31870 Testing done: - TC-CNET-4.4 pass on ESP32 and Linux - Commissioning works on ESP32 and Linux - Manual testing of all attribute changes validated with chip-repl - Automated test beyond TC-CNET-4.4 coming as a follow-up
mergify bot
pushed a commit
that referenced
this issue
Feb 16, 2024
* Fix NetworkCommissioning Cluster issues This PR addresses several NetworkCommissioning issues which are all inter-related: - Attributes are never reported on change. - ScanNetworks used to modify attributes that should not be modified - LastNetworkStatus was not set where required - Thread network scanning did not report error on SSID field provided - All ConstraintErrors actually were reported as InvalidCommand - Lacking results of directed scanning did not report NetworkNotFound - Fixes #32024 - Fixes #32022 - Fixes #32021 - Fixes #32019 - Fixes #32018 - Fixes #31870 Testing done: - TC-CNET-4.4 pass on ESP32 and Linux - Commissioning works on ESP32 and Linux - Manual testing of all attribute changes validated with chip-repl - Automated test beyond TC-CNET-4.4 coming as a follow-up * Restyled by clang-format * Fix a Release call missing * Fix one Release too many * Apply review comments * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It was found that the NetworkCommissioning cluster never reports on changes to any of the read-only attributes, preventing clients from detecting changes.
These are:
Affects 1.0 through 1.3 up to fix.
Likely was not caught because of insufficient error coverage in cert test cases.
The text was updated successfully, but these errors were encountered: