Skip to content

Clarify when to not dismiss dialogs by clicking outside #3754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ericwbailey merged 2 commits into from
Sep 25, 2023
Merged

Clarify when to not dismiss dialogs by clicking outside #3754

ericwbailey merged 2 commits into from
Sep 25, 2023

Conversation

@ericwbailey
Copy link
Contributor

@ericwbailey ericwbailey commented Sep 19, 2023

Addresses a conversation in Slack.

Changelog

New

Adds a new paragraph about not using click-to-dismiss for dialogs that perform data manipulation actions.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan

Testing & Reviewing

Copy tweak, with no functional changes.

@ericwbailey ericwbailey requested review from a team and mperrotti September 19, 2023 21:54
@changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4c52127

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2023 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 100.74 KB (0%)
dist/browser.umd.js 101.32 KB (0%)

@ericwbailey ericwbailey temporarily deployed to github-pages September 19, 2023 22:01 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3754 September 19, 2023 22:02 Inactive
@ericwbailey ericwbailey added this pull request to the merge queue Sep 25, 2023
Merged via the queue into main with commit ba6c074 Sep 25, 2023
@ericwbailey ericwbailey deleted the clarify-dialog-dismissal branch September 25, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshblack joshblack joshblack approved these changes

@mperrotti mperrotti Awaiting requested review from mperrotti

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ericwbailey @joshblack