Skip to content

Commit 4c52127

Browse files
authored
Merge branch 'main' into clarify-dialog-dismissal
2 parents 64d6e61 + 4bcc98e commit 4c52127

11 files changed

+70
-61
lines changed

.changeset/brown-seahorses-melt.md

Lines changed: 0 additions & 7 deletions
This file was deleted.

.changeset/cuddly-rice-press.md

Lines changed: 0 additions & 7 deletions
This file was deleted.

.changeset/friendly-shirts-protect.md

Lines changed: 0 additions & 7 deletions
This file was deleted.

.changeset/nasty-jobs-itch.md

Lines changed: 0 additions & 7 deletions
This file was deleted.

.changeset/polite-hairs-switch.md

Lines changed: 0 additions & 7 deletions
This file was deleted.

.changeset/tough-pillows-glow.md

Lines changed: 0 additions & 7 deletions
This file was deleted.

.changeset/two-seals-prove.md

Lines changed: 0 additions & 7 deletions
This file was deleted.

.changeset/wild-snakes-talk.md

Lines changed: 0 additions & 7 deletions
This file was deleted.

.github/pull_request_template.md

Lines changed: 31 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,42 @@
1-
Describe your changes here.
1+
<!-- Provide the GitHub issue that this issue closes. Start typing the number or name of the issue after the # below. -->
22

3-
Closes # (type the issue number after # if applicable; otherwise remove this line)
3+
Closes #
44

5-
### Screenshots
5+
<!-- Provide an overview of the changes, including before/after screenshots, videos, or graphs when helpful -->
66

7-
Please provide before/after screenshots for any visual changes
7+
### Changelog
8+
9+
<!-- Under the headings below, list out relevant API changes that this Pull Request introduces -->
10+
11+
#### New
12+
13+
<!-- List of things added in this PR -->
14+
15+
#### Changed
16+
17+
<!-- List of things changed in this PR -->
18+
19+
#### Removed
20+
21+
<!-- List of things removed in this PR -->
22+
23+
### Rollout strategy
24+
25+
<!-- How do you recommend this change to be rolled out? Refer to [contributor docs on Versioning](https://github.com/primer/react/blob/main/contributor-docs/versioning.md) for details. -->
26+
27+
- [ ] Patch release
28+
- [ ] Minor release
29+
- [ ] Major release; if selected, include a written rollout or migration plan
30+
31+
### Testing & Reviewing
32+
33+
<!-- Describe any specific details to help reviewers test or review this Pull Request -->
834

935
### Merge checklist
1036

1137
- [ ] Added/updated tests
1238
- [ ] Added/updated documentation
39+
- [ ] Added/updated previews (Storybook)
1340
- [ ] Changes are [SSR compatible](https://github.com/primer/react/blob/main/contributor-docs/CONTRIBUTING.md#ssr-compatibility)
1441
- [ ] Tested in Chrome
1542
- [ ] Tested in Firefox

CHANGELOG.md

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,43 @@
11
# @primer/components
22

3+
## 35.30.0
4+
5+
### Minor Changes
6+
7+
- [#3714](https://github.com/primer/react/pull/3714) [`88340269`](https://github.com/primer/react/commit/883402697efa8c9ff5c434753d4af36737b65e4b) Thanks [@iansan5653](https://github.com/iansan5653)! - Add support for controlling which side `ActionMenu` renders on (via a `side` prop on `ActionMenu.Overlay`)
8+
9+
<!-- Changed components: ActionMenu -->
10+
11+
- [#3715](https://github.com/primer/react/pull/3715) [`1f889281`](https://github.com/primer/react/commit/1f88928117acf86a3acd75c405b0064f080a66e3) Thanks [@joshblack](https://github.com/joshblack)! - Add support for leadingVisual and trailingVisual props to Button
12+
13+
<!-- Changed components: Button -->
14+
15+
- [#3739](https://github.com/primer/react/pull/3739) [`b90e5476`](https://github.com/primer/react/commit/b90e547639a7a906ef21cbf1a1c702c3d92210bc) Thanks [@joshblack](https://github.com/joshblack)! - Add the Column type and createColumnHelper function to easily define columns for DataTable
16+
17+
<!-- Changed components: DataTable -->
18+
19+
- [#3719](https://github.com/primer/react/pull/3719) [`500e529d`](https://github.com/primer/react/commit/500e529df47ae5def4bf5cedc55fc099251c25a1) Thanks [@joshblack](https://github.com/joshblack)! - The UnderlineNav, FilterList, and FilteredSearch components will be deprecated in v36 and have been moved to the deprecated entrypoint. To use the new UnderlineNav, migrate to the component available in drafts.
20+
21+
<!-- Changed components: FilterList, FilteredSearch, UnderlineNav -->
22+
23+
- [#3732](https://github.com/primer/react/pull/3732) [`8928acc3`](https://github.com/primer/react/commit/8928acc38fa32e5d752c57cb80070e5368c66314) Thanks [@joshblack](https://github.com/joshblack)! - Add default `type="button"` to `IconButton` component
24+
25+
<!-- Changed components: IconButton -->
26+
27+
### Patch Changes
28+
29+
- [#3661](https://github.com/primer/react/pull/3661) [`25693b08`](https://github.com/primer/react/commit/25693b08e8f2c89af1199c2f9d4fe38777f8a70b) Thanks [@joshblack](https://github.com/joshblack)! - Update the `children` prop for `Button` to be optional
30+
31+
<!-- Changed components: Button, IconButton -->
32+
33+
- [#3737](https://github.com/primer/react/pull/3737) [`a93eca21`](https://github.com/primer/react/commit/a93eca218043a3009ac0d6768e818fe3e15bb6c9) Thanks [@joshblack](https://github.com/joshblack)! - Restore default main landmark in PageLayout.Content
34+
35+
<!-- Changed components: PageLayout, SplitPageLayout -->
36+
37+
- [#3722](https://github.com/primer/react/pull/3722) [`0baa5a7f`](https://github.com/primer/react/commit/0baa5a7f6a009e6a7c77cd380f9b9ad93fdfd7cd) Thanks [@mattcosta7](https://github.com/mattcosta7)! - use isomorphic layout effects only
38+
39+
<!-- Changed components: InlineAutocomplete, MarkdownEditor -->
40+
341
## 35.29.0
442

543
### Minor Changes

0 commit comments

Comments
 (0)