Skip to content

Commit ba6c074

Browse files
authored
Clarify not dismissing dialogs by clicking outside (#3754)
1 parent 2a742ce commit ba6c074

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

docs/content/drafts/Dialog.mdx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ The dialog component is the Primer implementation of the ARIA design pattern [Di
2222

2323
**Dialogs are modal**. Dialogs can be dismissed by clicking on the close button, by interacting with another button in the overlay, or by clicking outside of the overlay.
2424

25+
Dialogs should not be dismissed by clicking outside the dialog's content area if used to add, update, or remove information. This would be the equivalent of a cancel action and may cause accidental data loss.
26+
2527
**(Coming soon) Make sure larger dialogs remain mobile-friendly**. Even large dialogs need to be responsive. A dialog's width and height will be readjusted depending on the screen size and should never exceed the available space. Use responsive solutions to adjust the UI so they behave well on smaller screens.
2628

2729
**(Coming soon) Simple and small dialogs can remain as-is on mobile**. As more elements are added to it, mobile-specific style variations such as **Bottom sheet** and **Full-screen** should be considered.

0 commit comments

Comments
 (0)