-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PageHeader API #2272
PageHeader API #2272
Conversation
|
size-limit report 📦
|
|
||
### With Context Actions and Breadcrumbs | ||
|
||
<PageHeader> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example and the following examples don't have the jsx live
codefence args. Is this intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope! it was a mistake. Will fix this 👍
Closing this as I've already opened a PR for primer repo |
This PR documents
PageHeader
proposed API. The implementation PR will be #2265 where the goal is to get the same api as documented here working inside storybooks. I will modify implementation based on feedback here. This PR needs to be merged first before implementation PR.Link to PageHeader API in figma - https://www.figma.com/file/Ee0OrXuOLXMDqUW83EnDHP/PageHeader-(FY23-Q1)?node-id=2%3A80694
This is the proposed anatomy that seems most complete to me
Here are the corresponding figma shots for the three API examples. Together I think this gives us a decent look at the API.
Default
With Context Actions and Breadcrumbs
With a description and local navigation
I'm looking for specific feedback on -
PageHeader.ContextNav
will only be visible in narrow mode.Stack
component. I feel like my usecase needs this component. It's not developed yet. I'm planning on making it. WDYT?