PageHeader: Initial implementation #2265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 35542f8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Closed
pksjce
force-pushed
the
pk/page-header
branch
from
e992254
to
6335f97
Compare
size-limit report 📦
|
|
Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days. |
broccolinisoup
added
skip changeset
broccolinisoup
force-pushed
the
pk/page-header
branch
from
6335f97
to
1a5e9d3
Compare
broccolinisoup
force-pushed
the
pk/page-header
branch
from
848bbfc
to
22320e0
Compare
broccolinisoup
force-pushed
the
pk/page-header
branch
from
22320e0
to
5d1380c
Compare
broccolinisoup
force-pushed
the
pk/page-header
branch
from
d858962
to
e6a7c3d
Compare
broccolinisoup
changed the title
vdepizzol
reviewed
Nov 23, 2022
vdepizzol
reviewed
Nov 23, 2022
This reverts commit 27c003f.
* use rem instead of primitives for now * unitless line-height * manage min touch target size with line-height: 2.75 * Remove the padding around the root PageHeader component to prevent misalignment with its sibligns - it will be up to consumers to manage the spacing around * Add padding to the stories
broccolinisoup
force-pushed
the
pk/page-header
branch
from
a20914b
to
6629315
Compare
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PageHeader component's initial implementation.
Related issues:
Figma specs for reference :
Tasks
hiddenprop with the provided default values (Default values varies depending on the viewport)Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.