Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PageHeader: Initial implementation #2265

Merged
merged 27 commits into from
Dec 9, 2022
Merged

PageHeader: Initial implementation #2265

merged 27 commits into from
Dec 9, 2022

Commits on Dec 8, 2022

  1. Add PageHeader component

    @pksjce @broccolinisoup
    pksjce authored and broccolinisoup committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    3c6c646 View commit details
    Browse the repository at this point in the history

  2. Use styled system array props

    @pksjce @broccolinisoup
    pksjce authored and broccolinisoup committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    349748e View commit details
    Browse the repository at this point in the history

  3. wip

    @broccolinisoup
    broccolinisoup committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    2e8af50 View commit details
    Browse the repository at this point in the history

  4. initial working implementation - not polished at all

    @broccolinisoup
    broccolinisoup committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    4a337de View commit details
    Browse the repository at this point in the history

  5. Add controls

    @broccolinisoup
    broccolinisoup committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    4e52c61 View commit details
    Browse the repository at this point in the history

  6. update stories

    @broccolinisoup
    broccolinisoup committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    61d1e82 View commit details
    Browse the repository at this point in the history

  7. fix linting

    @broccolinisoup
    broccolinisoup committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    6d042c6 View commit details
    Browse the repository at this point in the history

  8. address code review feedback

    @broccolinisoup
    broccolinisoup committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    548de17 View commit details
    Browse the repository at this point in the history

  9. make ParentLink polymorphic and use as and aria-label

    @broccolinisoup
    broccolinisoup committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    b5f5e00 View commit details
    Browse the repository at this point in the history

  10. story examples and features

    @broccolinisoup
    broccolinisoup committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    5bc99a7 View commit details
    Browse the repository at this point in the history

  11. add changeset and delete comment out code

    @broccolinisoup
    broccolinisoup committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    bdb0520 View commit details
    Browse the repository at this point in the history

  12. do not export viewports as a story

    @broccolinisoup
    broccolinisoup committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    6542584 View commit details
    Browse the repository at this point in the history

  13. rename prop visible->hidden

    @broccolinisoup
    broccolinisoup committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    70d387f View commit details
    Browse the repository at this point in the history

  14. remove defaultValues in storybook - get feedback first

    @broccolinisoup
    broccolinisoup committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    518a028 View commit details
    Browse the repository at this point in the history

  15. use theme preval & some rem update & prettier

    @broccolinisoup
    broccolinisoup committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    fe0e696 View commit details
    Browse the repository at this point in the history

  16. prettier lint fix

    @broccolinisoup
    broccolinisoup committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    58725ae View commit details
    Browse the repository at this point in the history

  17. try using media query instead of hook

    @broccolinisoup
    broccolinisoup committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    389bfac View commit details
    Browse the repository at this point in the history

  18. Revert "try using media query instead of hook" 

    This reverts commit 27c003f.
    @broccolinisoup
    broccolinisoup committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    db61db7 View commit details
    Browse the repository at this point in the history

  19. Spacing adjustments 

    * use rem instead of primitives for now
* unitless line-height
* manage min touch target size with line-height: 2.75
* Remove the padding around the root PageHeader component to prevent misalignment with its sibligns - it will be up to consumers to manage the spacing around
* Add padding to the stories
    @broccolinisoup
    broccolinisoup committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    c86f362 View commit details
    Browse the repository at this point in the history

  20. align items to top when the title is multi line

    @broccolinisoup
    broccolinisoup committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    1139bb1 View commit details
    Browse the repository at this point in the history

  21. move variant to the parent and provide context & code review feedback

    @broccolinisoup
    broccolinisoup committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    03c6834 View commit details
    Browse the repository at this point in the history

  22. remove todo for feature stories

    @broccolinisoup
    broccolinisoup committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    65834a7 View commit details
    Browse the repository at this point in the history

  23. move Box

    @broccolinisoup
    broccolinisoup committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    d855974 View commit details
    Browse the repository at this point in the history

  24. remove line-height for min touch size and add a comment

    @broccolinisoup
    broccolinisoup committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    6629315 View commit details
    Browse the repository at this point in the history

  25. Merge branch 'main' into pk/page-header

    @broccolinisoup
    broccolinisoup authored Dec 8, 2022
    Configuration menu
    Copy the full SHA
    f1ca9ea View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2022

  1. add unit tests and snapshot

    @broccolinisoup
    broccolinisoup committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    4e77758 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into pk/page-header

    @broccolinisoup
    broccolinisoup authored Dec 9, 2022
    Configuration menu
    Copy the full SHA
    35542f8 View commit details
    Browse the repository at this point in the history