Skip to content

Commit

Permalink
Parent link must have an href
Browse files Browse the repository at this point in the history
  • Loading branch information
pksjce committed Aug 30, 2022
1 parent beebaef commit 4737924
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions docs/content/PageHeader.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import {PageHeader} from '@primer/react'
{/* Visible only in narrow viewport*/}
<PageHeader.ContextNav>
{/* Always renders with a backbutton and is left aligned*/}
<PageHeader.ParentLink>Code</PageHeader.ParentLink>
<PageHeader.ParentLink href="/code">Code</PageHeader.ParentLink>
</PageHeader.ContextNav>
{/* Visible in all viewports */}
<PageHeader.TitleArea>
Expand All @@ -45,7 +45,7 @@ import {PageHeader} from '@primer/react'
{/* Visible only in narrow viewport only*/}
<PageHeader.ContextNav>
{/* Always renders with a backbutton and is left aligned*/}
<PageHeader.ParentLink>Files</PageHeader.ParentLink>
<PageHeader.ParentLink href="files">Files</PageHeader.ParentLink>
{/* These are right aligned*/}
<PageHeader.ContextNavActions>
{/* Should these buttons be normal sized?*/}
Expand Down Expand Up @@ -75,7 +75,7 @@ import {PageHeader} from '@primer/react'

<PageHeader>
<PageHeader.ContextNav>
<PageHeader.ParentLink>Pull requests</PageHeader.ParentLink>
<PageHeader.ParentLink href="prs">Pull requests</PageHeader.ParentLink>
</PageHeader.ContextNav>
<PageHeader.TitleArea>
<PageHeader.Title>PageLayout component/Layout beta + storybook</PageHeader.Title>
Expand Down

0 comments on commit 4737924

Please sign in to comment.