[Native] Fix error java.lang.OutOfMemoryError: Compressed class space
#21825
Conversation
|
@amitkdutta can you take a look at this change? Looks reasonable to me, but I want to double-check. |
| @@ -57,8 +57,8 @@ executors: | |||
| - image: prestocpp/prestocpp-avx-centos:root-20230613 | |||
| resource_class: 2xlarge | |||
| environment: | |||
| MAVEN_OPTS: "-Xmx4G -XX:+ExitOnOutOfMemoryError" | |||
| MAVEN_INSTALL_OPTS: "-Xmx2G -XX:+ExitOnOutOfMemoryError" | |||
| MAVEN_OPTS: "-Xmx4G -XX:+ExitOnOutOfMemoryError -XX:CompressedClassSpaceSize=3g" | |||
There was a problem hiding this comment.
Small recommendation: I see that we are using machine size as 2xlarge (which is 32 GB memory) we can either increase Xmx for both MAVEN_OPTS and MAVEN_FINAL_OPTS or if we don't need such large machines we can plan to shift to smaller resource class probably to save costs.
If there are certain suites that require larger machine size, we can also segregate different suites to use different executors to optimize costs.
There was a problem hiding this comment.
Thanks for the suggestion @imjalpreet. @majetideepak could you please confirm if I can increase Xmx to 8G in MAVEN_OPTS and MAVEN_FINAL_OPTS in this PR?
There was a problem hiding this comment.
We have to remember that Prestissimo workers also run on the same node and they require memory. I would prefer to limit the JVM memory to only the required since we know the memory is held up by the JVM until GC runs which is not in our control.
pramodsatya
force-pushed
the
fix_oom_err
branch
from
f2b4ad2
to
48c53ca
Compare
Description
The following error was seen when adding presto native e2e tests for window aggregate functions in #20625 :
This error is fixed by increasing the compressed class space size to 3gb in the CircleCI config for
linux-presto-e2e-tests.Test Plan
The CircleCI job
linux-presto-e2e-testswas verified to be passing with this fix: https://app.circleci.com/pipelines/github/prestodb/presto/11583/workflows/b23f1755-3811-49fd-844e-748dc2212080/jobs/43847 .