Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Native] Fix error java.lang.OutOfMemoryError: Compressed class space #21825

Merged
merged 1 commit into from
Jan 31, 2024
Merged

[Native] Fix error java.lang.OutOfMemoryError: Compressed class space #21825

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .circleci/continue_config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ executors:
- image: public.ecr.aws/oss-presto/prestocpp:root-20240129
resource_class: 2xlarge
environment:
MAVEN_OPTS: "-Xmx4G -XX:+ExitOnOutOfMemoryError"
MAVEN_INSTALL_OPTS: "-Xmx2G -XX:+ExitOnOutOfMemoryError"
MAVEN_OPTS: "-Xmx4G -XX:+ExitOnOutOfMemoryError -XX:CompressedClassSpaceSize=3g"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small recommendation: I see that we are using machine size as 2xlarge (which is 32 GB memory) we can either increase Xmx for both MAVEN_OPTS and MAVEN_FINAL_OPTS or if we don't need such large machines we can plan to shift to smaller resource class probably to save costs.

If there are certain suites that require larger machine size, we can also segregate different suites to use different executors to optimize costs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion @imjalpreet. @majetideepak could you please confirm if I can increase Xmx to 8G in MAVEN_OPTS and MAVEN_FINAL_OPTS in this PR?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to remember that Prestissimo workers also run on the same node and they require memory. I would prefer to limit the JVM memory to only the required since we know the memory is held up by the JVM until GC runs which is not in our control.

MAVEN_INSTALL_OPTS: "-Xmx2G -XX:+ExitOnOutOfMemoryError -XX:CompressedClassSpaceSize=3g"
MAVEN_FAST_INSTALL: "-B -V --quiet -T C1 -DskipTests -Dair.check.skip-all -Dmaven.javadoc.skip=true"
MAVEN_TEST: "-B -Dair.check.skip-all -Dmaven.javadoc.skip=true -DLogTestDurationListener.enabled=true --fail-at-end"
check:
Expand Down
Loading