[native] Advance Velox #21901

aditi-pandit · 2024-02-11T22:07:38Z

== NO RELEASE NOTE ==

aditi-pandit · 2024-02-11T22:10:33Z

@majetideepak

aditi-pandit · 2024-02-13T06:05:41Z

@pramodsatya : The linux-presto-e2e-tests is failing with the following error. Shouldn't it be fixed by #21825 ? Can you take a look ?

[ERROR] java.lang.OutOfMemoryError: Compressed class space
[ERROR] Terminating due to java.lang.OutOfMemoryError: Compressed class space
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 59, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[WARNING] Corrupted channel by directly writing to native stream in forked JVM 1. See FAQ web page and the dump file /root/project/presto-native-execution/target/surefire-reports/2024-02-12T16-33-39_340-jvmRun1.dumpstream
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 08:57 min (Wall Clock)
[INFO] Finished at: 2024-02-12T16:42:32-06:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M7:test (default-test) on project presto-native-execution: 
[ERROR] 
[ERROR] Please refer to /root/project/presto-native-execution/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] ExecutionException The forked VM terminated without properly saying goodbye. VM crash or System.exit called?
[ERROR] Command was /bin/sh -c cd '/root/project/presto-native-execution' && '/usr/lib/jvm/java-1.8.0-openjdk-1.8.0.362.b08-3.el8.x86_64/jre/bin/java' '-Dfile.encoding=UTF-8' '-Xmx4g' '-Xms4g' '-XX:+ExitOnOutOfMemoryError' '-XX:+HeapDumpOnOutOfMemoryError' '-XX:-OmitStackTraceInFastThrow' '-jar' '/root/project/presto-native-execution/target/surefire/surefirebooter-20240212163340700_39.jar' '/root/project/presto-native-execution/target/surefire' '2024-02-12T16-33-39_340-jvmRun1' 'surefire-20240212163340700_37tmp' 'surefire_2-20240212163340700_38tmp'
[ERROR] Error occurred in starting fork, check output in log
[ERROR] Process Exit Code: 3
[ERROR] Crashed tests:
[ERROR] com.facebook.presto.nativeworker.TestPrestoNativeWindowQueries
[ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: ExecutionException The forked VM terminated without properly saying goodbye. VM crash or System.exit called?
[ERROR] Command was /bin/sh -c cd '/root/project/presto-native-execution' && '/usr/lib/jvm/java-1.8.0-openjdk-1.8.0.362.b08-3.el8.x86_64/jre/bin/java' '-Dfile.encoding=UTF-8' '-Xmx4g' '-Xms4g' '-XX:+ExitOnOutOfMemoryError' '-XX:+HeapDumpOnOutOfMemoryError' '-XX:-OmitStackTraceInFastThrow' '-jar' '/root/project/presto-native-execution/target/surefire/surefirebooter-20240212163340700_39.jar' '/root/project/presto-native-execution/target/surefire' '2024-02-12T16-33-39_340-jvmRun1' 'surefire-20240212163340700_37tmp' 'surefire_2-20240212163340700_38tmp'
[ERROR] Error occurred in starting fork, check output in log
[ERROR] Process Exit Code: 3
[ERROR] Crashed tests:
[ERROR] com.facebook.presto.nativeworker.TestPrestoNativeWindowQueries
[ERROR]         at org.apache.maven.plugin.surefire.booterclient.ForkStarter.awaitResultsDone(ForkStarter.java:513)
[ERROR]         at org.apache.maven.plugin.surefire.booterclient.ForkStarter.runSuitesForkPerTestSet(ForkStarter.java:460)
[ERROR]         at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:327)
[ERROR]         at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:269)
[ERROR]         at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1334)
[ERROR]         at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1167)
[ERROR]         at org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:931)
[ERROR]         at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137)
[ERROR]         at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
[ERROR]         at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154)
[ERROR]         at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146)
[ERROR]         at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
[ERROR]         at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call(MultiThreadedBuilder.java:200)
[ERROR]         at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call(MultiThreadedBuilder.java:196)
[ERROR]         at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[ERROR]         at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
[ERROR]         at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[ERROR]         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[ERROR]         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[ERROR]         at java.lang.Thread.run(Thread.java:750)
[ERROR] Caused by: org.apache.maven.surefire.booter.SurefireBooterForkException: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?
[ERROR] Command was /bin/sh -c cd '/root/project/presto-native-execution' && '/usr/lib/jvm/java-1.8.0-openjdk-1.8.0.362.b08-3.el8.x86_64/jre/bin/java' '-Dfile.encoding=UTF-8' '-Xmx4g' '-Xms4g' '-XX:+ExitOnOutOfMemoryError' '-XX:+HeapDumpOnOutOfMemoryError' '-XX:-OmitStackTraceInFastThrow' '-jar' '/root/project/presto-native-execution/target/surefire/surefirebooter-20240212163340700_39.jar' '/root/project/presto-native-execution/target/surefire' '2024-02-12T16-33-39_340-jvmRun1' 'surefire-20240212163340700_37tmp' 'surefire_2-20240212163340700_38tmp'
[ERROR] Error occurred in starting fork, check output in log
[ERROR] Process Exit Code: 3
[ERROR] Crashed tests:
[ERROR] com.facebook.presto.nativeworker.TestPrestoNativeWindowQueries
[ERROR]         at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:714)
[ERROR]         at org.apache.maven.plugin.surefire.booterclient.ForkStarter.lambda$runSuitesForkPerTestSet$7(ForkStarter.java:449)
[ERROR]         ... 4 more
[ERROR] -> [Help 1]
[ERROR]

pramodsatya · 2024-02-13T18:32:04Z

@pramodsatya : The linux-presto-e2e-tests is failing with the following error. Shouldn't it be fixed by #21825 ? Can you take a look ?

[ERROR] java.lang.OutOfMemoryError: Compressed class space
[ERROR] Terminating due to java.lang.OutOfMemoryError: Compressed class space
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 59, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[WARNING] Corrupted channel by directly writing to native stream in forked JVM 1. See FAQ web page and the dump file /root/project/presto-native-execution/target/surefire-reports/2024-02-12T16-33-39_340-jvmRun1.dumpstream
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 08:57 min (Wall Clock)
[INFO] Finished at: 2024-02-12T16:42:32-06:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M7:test (default-test) on project presto-native-execution: 
[ERROR] 
[ERROR] Please refer to /root/project/presto-native-execution/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] ExecutionException The forked VM terminated without properly saying goodbye. VM crash or System.exit called?
[ERROR] Command was /bin/sh -c cd '/root/project/presto-native-execution' && '/usr/lib/jvm/java-1.8.0-openjdk-1.8.0.362.b08-3.el8.x86_64/jre/bin/java' '-Dfile.encoding=UTF-8' '-Xmx4g' '-Xms4g' '-XX:+ExitOnOutOfMemoryError' '-XX:+HeapDumpOnOutOfMemoryError' '-XX:-OmitStackTraceInFastThrow' '-jar' '/root/project/presto-native-execution/target/surefire/surefirebooter-20240212163340700_39.jar' '/root/project/presto-native-execution/target/surefire' '2024-02-12T16-33-39_340-jvmRun1' 'surefire-20240212163340700_37tmp' 'surefire_2-20240212163340700_38tmp'
[ERROR] Error occurred in starting fork, check output in log
[ERROR] Process Exit Code: 3
[ERROR] Crashed tests:
[ERROR] com.facebook.presto.nativeworker.TestPrestoNativeWindowQueries
[ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: ExecutionException The forked VM terminated without properly saying goodbye. VM crash or System.exit called?
[ERROR] Command was /bin/sh -c cd '/root/project/presto-native-execution' && '/usr/lib/jvm/java-1.8.0-openjdk-1.8.0.362.b08-3.el8.x86_64/jre/bin/java' '-Dfile.encoding=UTF-8' '-Xmx4g' '-Xms4g' '-XX:+ExitOnOutOfMemoryError' '-XX:+HeapDumpOnOutOfMemoryError' '-XX:-OmitStackTraceInFastThrow' '-jar' '/root/project/presto-native-execution/target/surefire/surefirebooter-20240212163340700_39.jar' '/root/project/presto-native-execution/target/surefire' '2024-02-12T16-33-39_340-jvmRun1' 'surefire-20240212163340700_37tmp' 'surefire_2-20240212163340700_38tmp'
[ERROR] Error occurred in starting fork, check output in log
[ERROR] Process Exit Code: 3
[ERROR] Crashed tests:
[ERROR] com.facebook.presto.nativeworker.TestPrestoNativeWindowQueries
[ERROR]         at org.apache.maven.plugin.surefire.booterclient.ForkStarter.awaitResultsDone(ForkStarter.java:513)
[ERROR]         at org.apache.maven.plugin.surefire.booterclient.ForkStarter.runSuitesForkPerTestSet(ForkStarter.java:460)
[ERROR]         at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:327)
[ERROR]         at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:269)
[ERROR]         at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1334)
[ERROR]         at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1167)
[ERROR]         at org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:931)
[ERROR]         at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137)
[ERROR]         at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
[ERROR]         at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154)
[ERROR]         at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146)
[ERROR]         at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
[ERROR]         at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call(MultiThreadedBuilder.java:200)
[ERROR]         at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call(MultiThreadedBuilder.java:196)
[ERROR]         at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[ERROR]         at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
[ERROR]         at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[ERROR]         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[ERROR]         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[ERROR]         at java.lang.Thread.run(Thread.java:750)
[ERROR] Caused by: org.apache.maven.surefire.booter.SurefireBooterForkException: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?
[ERROR] Command was /bin/sh -c cd '/root/project/presto-native-execution' && '/usr/lib/jvm/java-1.8.0-openjdk-1.8.0.362.b08-3.el8.x86_64/jre/bin/java' '-Dfile.encoding=UTF-8' '-Xmx4g' '-Xms4g' '-XX:+ExitOnOutOfMemoryError' '-XX:+HeapDumpOnOutOfMemoryError' '-XX:-OmitStackTraceInFastThrow' '-jar' '/root/project/presto-native-execution/target/surefire/surefirebooter-20240212163340700_39.jar' '/root/project/presto-native-execution/target/surefire' '2024-02-12T16-33-39_340-jvmRun1' 'surefire-20240212163340700_37tmp' 'surefire_2-20240212163340700_38tmp'
[ERROR] Error occurred in starting fork, check output in log
[ERROR] Process Exit Code: 3
[ERROR] Crashed tests:
[ERROR] com.facebook.presto.nativeworker.TestPrestoNativeWindowQueries
[ERROR]         at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:714)
[ERROR]         at org.apache.maven.plugin.surefire.booterclient.ForkStarter.lambda$runSuitesForkPerTestSet$7(ForkStarter.java:449)
[ERROR]         ... 4 more
[ERROR] -> [Help 1]
[ERROR]

Thanks for sharing @aditi-pandit, it looks like the jvm option -XX:CompressedClassSpaceSize=3g is not set in the command that runs on the forked VM. Could you please try updating the maven surefire plugin config in presto-native-execution/pom.xml with:

                 <configuration>
                     <forkCount>1</forkCount>
                     <reuseForks>false</reuseForks>
+                    <argLine>-Xms4g -Xmx4g -XX:CompressedClassSpaceSize=3g</argLine>
                     <excludedGroups>remote-function,textfile_reader</excludedGroups>
                     <systemPropertyVariables>
                         <PRESTO_SERVER>/root/project/build/debug/presto_cpp/main/presto_server</PRESTO_SERVER>

majetideepak · 2024-02-20T03:01:37Z

@aditi-pandit the critical bug fix in the description should be in here 0bc6f91
Can you update the description?

aditi-pandit · 2024-02-20T23:12:13Z

@majetideepak : TaskManager.cpp needed a code change for the change in the API introduced by facebookincubator/velox@9c79ef9

Please can you review again.

majetideepak

Thanks, Aditi!
I see that the following API change on the Velox side requires a change here.

using DataAvailableCallback = std::function<void(
    std::vector<std::unique_ptr<folly::IOBuf>> pages,
    int64_t sequence,
    std::vector<int64_t> remainingBytes)>;

majetideepak · 2024-02-21T06:19:15Z

The CI test failed due to some timeout. I restarted it.

aditi-pandit requested a review from a team as a code owner February 11, 2024 22:07

aditi-pandit force-pushed the advance_velox branch from 17003bd to fba65a8 Compare February 11, 2024 22:08

majetideepak approved these changes Feb 12, 2024

View reviewed changes

kevinwilfong mentioned this pull request Feb 12, 2024

[native] Advance Velox version. #21898

Closed

aditi-pandit force-pushed the advance_velox branch from fba65a8 to 6a23f17 Compare February 12, 2024 22:06

aditi-pandit force-pushed the advance_velox branch 2 times, most recently from 75ea231 to c15c285 Compare February 15, 2024 00:38

aditi-pandit requested a review from a team as a code owner February 15, 2024 00:38

aditi-pandit requested a review from presto-oss February 15, 2024 00:38

aditi-pandit force-pushed the advance_velox branch from c15c285 to 9a7cce2 Compare February 15, 2024 00:41

aditi-pandit requested review from a team and removed request for a team and presto-oss February 15, 2024 00:41

aditi-pandit force-pushed the advance_velox branch 2 times, most recently from 95b33b3 to 2503bb2 Compare February 15, 2024 08:33

aditi-pandit mentioned this pull request Feb 15, 2024

[native] Rolling back commit 6eba1f7330de2879ca2f4012c8bbd9b1f7a5f727 #21924

Merged

aditi-pandit force-pushed the advance_velox branch 2 times, most recently from a5ab227 to ddd7c3b Compare February 19, 2024 23:07

[Native] Advance Velox

c6db108

aditi-pandit force-pushed the advance_velox branch from ddd7c3b to c6db108 Compare February 20, 2024 23:03

majetideepak approved these changes Feb 21, 2024

View reviewed changes

aditi-pandit merged commit 36575b0 into master Feb 21, 2024
59 checks passed

aditi-pandit deleted the advance_velox branch February 21, 2024 22:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[native] Advance Velox #21901

[native] Advance Velox #21901

aditi-pandit commented Feb 11, 2024 •

edited

Loading

aditi-pandit commented Feb 11, 2024

aditi-pandit commented Feb 13, 2024

pramodsatya commented Feb 13, 2024 •

edited

Loading

majetideepak commented Feb 20, 2024

aditi-pandit commented Feb 20, 2024

majetideepak left a comment

majetideepak commented Feb 21, 2024

[native] Advance Velox #21901

[native] Advance Velox #21901

Conversation

aditi-pandit commented Feb 11, 2024 • edited Loading

aditi-pandit commented Feb 11, 2024

aditi-pandit commented Feb 13, 2024

pramodsatya commented Feb 13, 2024 • edited Loading

majetideepak commented Feb 20, 2024

aditi-pandit commented Feb 20, 2024

majetideepak left a comment

Choose a reason for hiding this comment

majetideepak commented Feb 21, 2024

aditi-pandit commented Feb 11, 2024 •

edited

Loading

pramodsatya commented Feb 13, 2024 •

edited

Loading