Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Go version to 1.22 in dev containers config #3983

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sebhtml
Copy link

@sebhtml sebhtml commented Oct 15, 2024

Context

In the README, it is written that:

Prebid Server requires Go version 1.21 or newer.

However, in the Dev Containers configuration, Go 1.20 is configured:

  	"VARIANT": "1.20",

Consequence

A natural consequence of that is the following compile error is obtained when one opens the project with Dev Containers with Visual Studio Code (tested with VS Code 1.93.1):

could not import maps (no required module provides package "maps") compiler BrokenImport

Root Cause Analysis

The package "maps" does not exist in Go 1.20. See https://pkg.go.dev/maps?tab=versions
If there is a table with nothing on it and you ask someone to eat the apple that is on the table, there will be consequences.
(Feedback from the environment)

Solution

A no-brainer solution is to make the Dev Containers configuration congruent with the README file.

@SyntaxNode
Copy link
Contributor

Nice catch. @bsardo missed this when upgrading to Go 1.22. While we support 1.21, the dockerfile is building with 1.22.3. Do you think we should update the dev container to the same version?

@bsardo bsardo self-assigned this Oct 15, 2024
@bsardo
Copy link
Collaborator

bsardo commented Oct 16, 2024

Nice catch. @bsardo missed this when upgrading to Go 1.22. While we support 1.21, the dockerfile is building with 1.22.3. Do you think we should update the dev container to the same version?

Oops. Yes let's update this to 1.22.

@sebhtml
Copy link
Author

sebhtml commented Oct 16, 2024

Nice catch. @bsardo missed this when upgrading to Go 1.22. While we support 1.21, the dockerfile is building with 1.22.3. Do you think we should update the dev container to the same version?

Oops. Yes let's update this to 1.22.

Hello @bsardo

Should I update to 1.22 in Dev Containers and in the README ?

Thank you.

@bsardo
Copy link
Collaborator

bsardo commented Oct 17, 2024

Hello @bsardo
Should I update to 1.22 in Dev Containers and in the README ?

Hi @sebhtml, yes please. That would be great.

@sebhtml
Copy link
Author

sebhtml commented Oct 18, 2024

Hello @bsardo
Should I update to 1.22 in Dev Containers and in the README ?

Hi @sebhtml, yes please. That would be great.

Hello @bsardo,

It's done. See commit 5aae4cd .

Thank you.

@sebhtml sebhtml changed the title Dev: bump Go version to 1.21 in Dev Containers config Dev: bump Go version to 1.22 in Dev Containers config Oct 18, 2024
@bsardo bsardo changed the title Dev: bump Go version to 1.22 in Dev Containers config Bump Go version to 1.22 in dev containers config Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants