Refactor Bid Splitter Privacy Functions #3645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxNode
commented
Apr 26, 2024
gdpr/impl.go
Outdated
| pc, err := parseConsent(p.consent) | ||
| if err != nil { | ||
| return p.defaultPermissions(), err | ||
| return DenyAll |
There was a problem hiding this comment.
The error was always only interpreted this way, so codifying that behavior here.
There was a problem hiding this comment.
If an err always is treated as DenyAll, then what about line 80 below where an error becomes p.defaultPermissions()?
AlexBVolcy
reviewed
May 17, 2024
hhhjort
reviewed
Aug 12, 2024
| @@ -20,8 +20,8 @@ type Permissions interface { | |||
|
|
|||
| // Determines whether or not to send PI information to a bidder, or mask it out. | |||
| // | |||
| // If the consent string was nonsensical, the returned error will be an ErrorMalformedConsent. | |||
| AuctionActivitiesAllowed(ctx context.Context, bidderCoreName openrtb_ext.BidderName, bidder openrtb_ext.BidderName) (permissions AuctionPermissions, err error) | |||
| // If the consent string was nonsensical, the no permissions are granted. | |||
There was a problem hiding this comment.
typo, should be: the_n_ no permissions are granted
AlexBVolcy
reviewed
Aug 14, 2024
Comment on lines
+184
to
+186
| fetchBidsActivityAllowed := activities.Allow(privacy.ActivityFetchBids, scope, privacy.NewRequestFromBidRequest(*r)) | ||
| if !fetchBidsActivityAllowed { | ||
| return true |
There was a problem hiding this comment.
I was thinking you could just have the function call in the if statement like
if !activities.Allow(privacy.ActivityFetchBids, scope, privacy.NewRequestFromBidRequest(*r)) {
return true
}
As opposed to using the fetchBidsActivityAllowed variable. Or is that out of the scope of this PR?
bsardo
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.