-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sonobi: native and currency conversion support #3889
Sonobi: native and currency conversion support #3889
Conversation
349c343
to
4122f2f
Compare
Code coverage summaryNote:
sonobiRefer here for heat map coverage report
|
4122f2f
to
e42e7de
Compare
Code coverage summaryNote:
sonobiRefer here for heat map coverage report
|
e42e7de
to
944313d
Compare
Code coverage summaryNote:
sonobiRefer here for heat map coverage report
|
944313d
to
ab63a76
Compare
Code coverage summaryNote:
sonobiRefer here for heat map coverage report
|
ab63a76
to
64dc827
Compare
Code coverage summaryNote:
sonobiRefer here for heat map coverage report
|
64dc827
to
fc4db51
Compare
Code coverage summaryNote:
sonobiRefer here for heat map coverage report
|
Hi @bansawbanchee, now that the review process has started, please push new commits instead of rebasing and force pushing to save reviewers time. Thanks! |
Code coverage summaryNote:
sonobiRefer here for heat map coverage report
|
Code coverage summaryNote:
sonobiRefer here for heat map coverage report
|
iframe: | ||
url: "https://sync.go.sonobi.com/uc.html?gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&loc={{.RedirectURL}}" | ||
userMacro: "[UID]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code coverage summaryNote:
sonobiRefer here for heat map coverage report
|
Closed previous pull request. Put everything in one. Native and currency conversion support.
We were asked to use mtype for determining the mediatype. We currently do not support mtype from our server so I removed that function for now. Once we support it I will update our adapter.