PBJs Core (adserver.js) : remove unused code #8855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseywhitmire
changed the title
Closed
patmmccann
approved these changes
Aug 17, 2022
patmmccann
added
the
needs 2nd review
ChrisHuie
removed
the
needs 2nd review
ChrisHuie
changed the title
ChrisHuie
approved these changes
Aug 19, 2022
patmmccann
added a commit
that referenced
this pull request
Aug 21, 2022
* Readme: remove dead dev dependency and maintenance badges (#8849) * Readme: remove dead dev dependency badge and issue * Remove maintainability and add back issues * Prebid 7.11.0 release * Increment version to 7.12.0-pre * Adriver Bid and Id Modules: buyerid bug fix (#8768) * initial commit * adriver id submodule add * add id system tests, fix adriver bid adapter tests * adriver: fix buyerid * remarks fixing * removal of excess * delete custom parameter * bug fixes * handle native response privacy link (#8838) Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> * Criteo Bid Adapter - Add support for banner+native multiformat ad unit (#8842) Previously, the use of a native adunit was exclusive with the banner type. * Ras Bid Adapter: support for SlotSequence parameter (#8792) * add rasbidadapter pos param * Read pos off the adunit * rename conflicting pos parameter for clarity * Improve Digital adapter: refactor code to align with latest RAZR creative tags (#8827) * IX Bid Adapter: Native OpenRTB Request Support (#8853) * fix native click trackers to only fire on click * fix unit tests for ix * remove version for native requests * remove unnecessary request conversion Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> * Update Sonobi adapter with GVLID (#8860) * dgkeyword RTD provider: fix tests causing ID5 test failures (#8862) * Id5 id configurable fetch flow (#8784) Co-authored-by: Paweł Kowalski <pkowalski@id5.io> * NextMillenium Bid Adapter: Remove ortb2 referrerInfo (#8868) * remove ortb2, get device/site manually * updated tests * remove fallbacks * no need to craete variable if there is no fallback (return in place) * removed one test case Co-authored-by: Yakov Klein <yakovklein@Yakovs-MacBook-Air.local> * adserver.js : remove unused code (#8855) * Displayio Bid Adapter: custom render; fix eids payload (#8847) * Custom render; call pubmatic get user id function is removed * use refererInfo; remove call createEidsArray * VidCrunch LLC bidder (#8872) Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Co-authored-by: Prebid.js automated release <prebidjs-release@prebid.org> Co-authored-by: m-oranskaya <99481039+m-oranskaya@users.noreply.github.com> Co-authored-by: Love Sharma <sharmak.love@gmail.com> Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> Co-authored-by: Léonard Labat <le.labat@criteo.com> Co-authored-by: wsusrasp <106743463+wsusrasp@users.noreply.github.com> Co-authored-by: Catalin Ciocov <catalin.ciocov@gmail.com> Co-authored-by: Mike Miller <mike@solitaired.com> Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> Co-authored-by: Scott Menzer <scott@id5.io> Co-authored-by: Paweł Kowalski <pkowalski@id5.io> Co-authored-by: JacobKlein26 <42449375+JacobKlein26@users.noreply.github.com> Co-authored-by: Yakov Klein <yakovklein@Yakovs-MacBook-Air.local> Co-authored-by: caseywhitmire <60086994+caseywhitmire@users.noreply.github.com> Co-authored-by: philan15 <37775368+philan15@users.noreply.github.com> Co-authored-by: Gena <wertixvost@gmail.com>
patmmccann
added a commit
that referenced
this pull request
Aug 31, 2022
* Create codeql-analysis.yml * Update codeql-analysis.yml * Update instream.html * Update emx_digitalBidAdapter_spec.js * Update index.js * Update index.js * Update index.js * Merge master (#8873) * Readme: remove dead dev dependency and maintenance badges (#8849) * Readme: remove dead dev dependency badge and issue * Remove maintainability and add back issues * Prebid 7.11.0 release * Increment version to 7.12.0-pre * Adriver Bid and Id Modules: buyerid bug fix (#8768) * initial commit * adriver id submodule add * add id system tests, fix adriver bid adapter tests * adriver: fix buyerid * remarks fixing * removal of excess * delete custom parameter * bug fixes * handle native response privacy link (#8838) Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> * Criteo Bid Adapter - Add support for banner+native multiformat ad unit (#8842) Previously, the use of a native adunit was exclusive with the banner type. * Ras Bid Adapter: support for SlotSequence parameter (#8792) * add rasbidadapter pos param * Read pos off the adunit * rename conflicting pos parameter for clarity * Improve Digital adapter: refactor code to align with latest RAZR creative tags (#8827) * IX Bid Adapter: Native OpenRTB Request Support (#8853) * fix native click trackers to only fire on click * fix unit tests for ix * remove version for native requests * remove unnecessary request conversion Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> * Update Sonobi adapter with GVLID (#8860) * dgkeyword RTD provider: fix tests causing ID5 test failures (#8862) * Id5 id configurable fetch flow (#8784) Co-authored-by: Paweł Kowalski <pkowalski@id5.io> * NextMillenium Bid Adapter: Remove ortb2 referrerInfo (#8868) * remove ortb2, get device/site manually * updated tests * remove fallbacks * no need to craete variable if there is no fallback (return in place) * removed one test case Co-authored-by: Yakov Klein <yakovklein@Yakovs-MacBook-Air.local> * adserver.js : remove unused code (#8855) * Displayio Bid Adapter: custom render; fix eids payload (#8847) * Custom render; call pubmatic get user id function is removed * use refererInfo; remove call createEidsArray * VidCrunch LLC bidder (#8872) Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Co-authored-by: Prebid.js automated release <prebidjs-release@prebid.org> Co-authored-by: m-oranskaya <99481039+m-oranskaya@users.noreply.github.com> Co-authored-by: Love Sharma <sharmak.love@gmail.com> Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> Co-authored-by: Léonard Labat <le.labat@criteo.com> Co-authored-by: wsusrasp <106743463+wsusrasp@users.noreply.github.com> Co-authored-by: Catalin Ciocov <catalin.ciocov@gmail.com> Co-authored-by: Mike Miller <mike@solitaired.com> Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> Co-authored-by: Scott Menzer <scott@id5.io> Co-authored-by: Paweł Kowalski <pkowalski@id5.io> Co-authored-by: JacobKlein26 <42449375+JacobKlein26@users.noreply.github.com> Co-authored-by: Yakov Klein <yakovklein@Yakovs-MacBook-Air.local> Co-authored-by: caseywhitmire <60086994+caseywhitmire@users.noreply.github.com> Co-authored-by: philan15 <37775368+philan15@users.noreply.github.com> Co-authored-by: Gena <wertixvost@gmail.com> * Revert "Merge master (#8873)" (#8911) This reverts commit 07c5369. * Update code scan config * Update viewability * Sanitize JSON for adgeneration Co-authored-by: Patrick McCann <patmmccann@gmail.com> Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Co-authored-by: Prebid.js automated release <prebidjs-release@prebid.org> Co-authored-by: m-oranskaya <99481039+m-oranskaya@users.noreply.github.com> Co-authored-by: Love Sharma <sharmak.love@gmail.com> Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> Co-authored-by: Léonard Labat <le.labat@criteo.com> Co-authored-by: wsusrasp <106743463+wsusrasp@users.noreply.github.com> Co-authored-by: Catalin Ciocov <catalin.ciocov@gmail.com> Co-authored-by: Mike Miller <mike@solitaired.com> Co-authored-by: Scott Menzer <scott@id5.io> Co-authored-by: Paweł Kowalski <pkowalski@id5.io> Co-authored-by: JacobKlein26 <42449375+JacobKlein26@users.noreply.github.com> Co-authored-by: Yakov Klein <yakovklein@Yakovs-MacBook-Air.local> Co-authored-by: caseywhitmire <60086994+caseywhitmire@users.noreply.github.com> Co-authored-by: philan15 <37775368+philan15@users.noreply.github.com> Co-authored-by: Gena <wertixvost@gmail.com>
JacobKlein26
pushed a commit
to nextmillenniummedia/Prebid.js
that referenced
this pull request
Feb 9, 2023
JacobKlein26
added a commit
to nextmillenniummedia/Prebid.js
that referenced
this pull request
Feb 9, 2023
* Create codeql-analysis.yml * Update codeql-analysis.yml * Update instream.html * Update emx_digitalBidAdapter_spec.js * Update index.js * Update index.js * Update index.js * Merge master (prebid#8873) * Readme: remove dead dev dependency and maintenance badges (prebid#8849) * Readme: remove dead dev dependency badge and issue * Remove maintainability and add back issues * Prebid 7.11.0 release * Increment version to 7.12.0-pre * Adriver Bid and Id Modules: buyerid bug fix (prebid#8768) * initial commit * adriver id submodule add * add id system tests, fix adriver bid adapter tests * adriver: fix buyerid * remarks fixing * removal of excess * delete custom parameter * bug fixes * handle native response privacy link (prebid#8838) Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> * Criteo Bid Adapter - Add support for banner+native multiformat ad unit (prebid#8842) Previously, the use of a native adunit was exclusive with the banner type. * Ras Bid Adapter: support for SlotSequence parameter (prebid#8792) * add rasbidadapter pos param * Read pos off the adunit * rename conflicting pos parameter for clarity * Improve Digital adapter: refactor code to align with latest RAZR creative tags (prebid#8827) * IX Bid Adapter: Native OpenRTB Request Support (prebid#8853) * fix native click trackers to only fire on click * fix unit tests for ix * remove version for native requests * remove unnecessary request conversion Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> * Update Sonobi adapter with GVLID (prebid#8860) * dgkeyword RTD provider: fix tests causing ID5 test failures (prebid#8862) * Id5 id configurable fetch flow (prebid#8784) Co-authored-by: Paweł Kowalski <pkowalski@id5.io> * NextMillenium Bid Adapter: Remove ortb2 referrerInfo (prebid#8868) * remove ortb2, get device/site manually * updated tests * remove fallbacks * no need to craete variable if there is no fallback (return in place) * removed one test case Co-authored-by: Yakov Klein <yakovklein@Yakovs-MacBook-Air.local> * adserver.js : remove unused code (prebid#8855) * Displayio Bid Adapter: custom render; fix eids payload (prebid#8847) * Custom render; call pubmatic get user id function is removed * use refererInfo; remove call createEidsArray * VidCrunch LLC bidder (prebid#8872) Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Co-authored-by: Prebid.js automated release <prebidjs-release@prebid.org> Co-authored-by: m-oranskaya <99481039+m-oranskaya@users.noreply.github.com> Co-authored-by: Love Sharma <sharmak.love@gmail.com> Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> Co-authored-by: Léonard Labat <le.labat@criteo.com> Co-authored-by: wsusrasp <106743463+wsusrasp@users.noreply.github.com> Co-authored-by: Catalin Ciocov <catalin.ciocov@gmail.com> Co-authored-by: Mike Miller <mike@solitaired.com> Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> Co-authored-by: Scott Menzer <scott@id5.io> Co-authored-by: Paweł Kowalski <pkowalski@id5.io> Co-authored-by: JacobKlein26 <42449375+JacobKlein26@users.noreply.github.com> Co-authored-by: Yakov Klein <yakovklein@Yakovs-MacBook-Air.local> Co-authored-by: caseywhitmire <60086994+caseywhitmire@users.noreply.github.com> Co-authored-by: philan15 <37775368+philan15@users.noreply.github.com> Co-authored-by: Gena <wertixvost@gmail.com> * Revert "Merge master (prebid#8873)" (prebid#8911) This reverts commit 07c5369. * Update code scan config * Update viewability * Sanitize JSON for adgeneration Co-authored-by: Patrick McCann <patmmccann@gmail.com> Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Co-authored-by: Prebid.js automated release <prebidjs-release@prebid.org> Co-authored-by: m-oranskaya <99481039+m-oranskaya@users.noreply.github.com> Co-authored-by: Love Sharma <sharmak.love@gmail.com> Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> Co-authored-by: Léonard Labat <le.labat@criteo.com> Co-authored-by: wsusrasp <106743463+wsusrasp@users.noreply.github.com> Co-authored-by: Catalin Ciocov <catalin.ciocov@gmail.com> Co-authored-by: Mike Miller <mike@solitaired.com> Co-authored-by: Scott Menzer <scott@id5.io> Co-authored-by: Paweł Kowalski <pkowalski@id5.io> Co-authored-by: JacobKlein26 <42449375+JacobKlein26@users.noreply.github.com> Co-authored-by: Yakov Klein <yakovklein@Yakovs-MacBook-Air.local> Co-authored-by: caseywhitmire <60086994+caseywhitmire@users.noreply.github.com> Co-authored-by: philan15 <37775368+philan15@users.noreply.github.com> Co-authored-by: Gena <wertixvost@gmail.com>
8 tasks
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
May 23, 2023
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
May 23, 2023
* Create codeql-analysis.yml * Update codeql-analysis.yml * Update instream.html * Update emx_digitalBidAdapter_spec.js * Update index.js * Update index.js * Update index.js * Merge master (prebid#8873) * Readme: remove dead dev dependency and maintenance badges (prebid#8849) * Readme: remove dead dev dependency badge and issue * Remove maintainability and add back issues * Prebid 7.11.0 release * Increment version to 7.12.0-pre * Adriver Bid and Id Modules: buyerid bug fix (prebid#8768) * initial commit * adriver id submodule add * add id system tests, fix adriver bid adapter tests * adriver: fix buyerid * remarks fixing * removal of excess * delete custom parameter * bug fixes * handle native response privacy link (prebid#8838) Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> * Criteo Bid Adapter - Add support for banner+native multiformat ad unit (prebid#8842) Previously, the use of a native adunit was exclusive with the banner type. * Ras Bid Adapter: support for SlotSequence parameter (prebid#8792) * add rasbidadapter pos param * Read pos off the adunit * rename conflicting pos parameter for clarity * Improve Digital adapter: refactor code to align with latest RAZR creative tags (prebid#8827) * IX Bid Adapter: Native OpenRTB Request Support (prebid#8853) * fix native click trackers to only fire on click * fix unit tests for ix * remove version for native requests * remove unnecessary request conversion Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> * Update Sonobi adapter with GVLID (prebid#8860) * dgkeyword RTD provider: fix tests causing ID5 test failures (prebid#8862) * Id5 id configurable fetch flow (prebid#8784) Co-authored-by: Paweł Kowalski <pkowalski@id5.io> * NextMillenium Bid Adapter: Remove ortb2 referrerInfo (prebid#8868) * remove ortb2, get device/site manually * updated tests * remove fallbacks * no need to craete variable if there is no fallback (return in place) * removed one test case Co-authored-by: Yakov Klein <yakovklein@Yakovs-MacBook-Air.local> * adserver.js : remove unused code (prebid#8855) * Displayio Bid Adapter: custom render; fix eids payload (prebid#8847) * Custom render; call pubmatic get user id function is removed * use refererInfo; remove call createEidsArray * VidCrunch LLC bidder (prebid#8872) Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Co-authored-by: Prebid.js automated release <prebidjs-release@prebid.org> Co-authored-by: m-oranskaya <99481039+m-oranskaya@users.noreply.github.com> Co-authored-by: Love Sharma <sharmak.love@gmail.com> Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> Co-authored-by: Léonard Labat <le.labat@criteo.com> Co-authored-by: wsusrasp <106743463+wsusrasp@users.noreply.github.com> Co-authored-by: Catalin Ciocov <catalin.ciocov@gmail.com> Co-authored-by: Mike Miller <mike@solitaired.com> Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> Co-authored-by: Scott Menzer <scott@id5.io> Co-authored-by: Paweł Kowalski <pkowalski@id5.io> Co-authored-by: JacobKlein26 <42449375+JacobKlein26@users.noreply.github.com> Co-authored-by: Yakov Klein <yakovklein@Yakovs-MacBook-Air.local> Co-authored-by: caseywhitmire <60086994+caseywhitmire@users.noreply.github.com> Co-authored-by: philan15 <37775368+philan15@users.noreply.github.com> Co-authored-by: Gena <wertixvost@gmail.com> * Revert "Merge master (prebid#8873)" (prebid#8911) This reverts commit 07c5369. * Update code scan config * Update viewability * Sanitize JSON for adgeneration Co-authored-by: Patrick McCann <patmmccann@gmail.com> Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Co-authored-by: Prebid.js automated release <prebidjs-release@prebid.org> Co-authored-by: m-oranskaya <99481039+m-oranskaya@users.noreply.github.com> Co-authored-by: Love Sharma <sharmak.love@gmail.com> Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> Co-authored-by: Léonard Labat <le.labat@criteo.com> Co-authored-by: wsusrasp <106743463+wsusrasp@users.noreply.github.com> Co-authored-by: Catalin Ciocov <catalin.ciocov@gmail.com> Co-authored-by: Mike Miller <mike@solitaired.com> Co-authored-by: Scott Menzer <scott@id5.io> Co-authored-by: Paweł Kowalski <pkowalski@id5.io> Co-authored-by: JacobKlein26 <42449375+JacobKlein26@users.noreply.github.com> Co-authored-by: Yakov Klein <yakovklein@Yakovs-MacBook-Air.local> Co-authored-by: caseywhitmire <60086994+caseywhitmire@users.noreply.github.com> Co-authored-by: philan15 <37775368+philan15@users.noreply.github.com> Co-authored-by: Gena <wertixvost@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Removed unused code in adserver.js
Other information