Adriver Bid and Id Modules: buyerid bug fix #8768

m-oranskaya · 2022-08-02T14:27:26Z

Type of change

Bugfix

Description of change

Fixed bug with getting buyerid and fixing tests

Maintainer email: m.oranskaya@adriver.ru

Other information

Please add adriver to the generation page https://docs.prebid.org/download.html in the "User ID Modules" section.
Because during the last update, the adriverIdSystem module was added, but it was not added on the generation page

ChrisHuie · 2022-08-04T12:19:14Z

@m-oranskaya I will follow-up on the download page to add adriver

m-oranskaya · 2022-08-10T13:09:02Z

We think that error in the CircleCI tests is not related to our changes. Shall we do something else to get our changes approved?

osazos · 2022-08-10T20:18:46Z

Hi, why do you send id's from other modules ?
I don't think this behavior is expected here.
cc @patmmccann

(the CI error is not related to your changes, I confirm)

patmmccann · 2022-08-10T21:59:31Z

modules/adriverIdSystem.js

+        }
+        let sharedID = storage.getDataFromLocalStorage('_pubcid') || storage.getCookie('pubcid');
+        let unifiedID = storage.getCookie('__uid2_advertising_token');
+        let newUrl = url + '&custom=' + (universalVal ? '221=' + encodeURIComponent(universalVal) + ';' : '') + (sharedID ? '222=' + encodeURIComponent(sharedID) + ';' : '') + (unifiedID ? '223=' + encodeURIComponent(unifiedID) : '') + '&cid=' + (storage.getDataFromLocalStorage('adrcid') || storage.getCookie('adrcid'));


you can't do this

please see id module rules at https://docs.prebid.org/dev-docs/module-rules.html

m-oranskaya · 2022-08-16T10:41:32Z

We have made the necessary changes, is there anything else we need to do to get the Pull Request approved?

osazos · 2022-08-17T14:07:16Z

modules/adriverBidAdapter.js

@@ -99,22 +97,17 @@ export const spec = {
      });
    });

-    let userid = validBidRequests[0].userId;
    let adrcidCookie = storage.getDataFromLocalStorage('adrcid') || validBidRequests[0].userId.adrcid;


During my tests, I saw the fallback throw an error during the first auction, because the userId is not defined.

Please just update to something like : || validBidRequests[0].userId?.adrcid;

osazos

LGTM

m-oranskaya · 2022-08-18T15:39:18Z

Could you add our userId module to download page?

osazos · 2022-08-19T09:53:31Z

Could you add our userId module to download page?

@ChrisHuie ?

* Readme: remove dead dev dependency and maintenance badges (#8849) * Readme: remove dead dev dependency badge and issue * Remove maintainability and add back issues * Prebid 7.11.0 release * Increment version to 7.12.0-pre * Adriver Bid and Id Modules: buyerid bug fix (#8768) * initial commit * adriver id submodule add * add id system tests, fix adriver bid adapter tests * adriver: fix buyerid * remarks fixing * removal of excess * delete custom parameter * bug fixes * handle native response privacy link (#8838) Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> * Criteo Bid Adapter - Add support for banner+native multiformat ad unit (#8842) Previously, the use of a native adunit was exclusive with the banner type. * Ras Bid Adapter: support for SlotSequence parameter (#8792) * add rasbidadapter pos param * Read pos off the adunit * rename conflicting pos parameter for clarity * Improve Digital adapter: refactor code to align with latest RAZR creative tags (#8827) * IX Bid Adapter: Native OpenRTB Request Support (#8853) * fix native click trackers to only fire on click * fix unit tests for ix * remove version for native requests * remove unnecessary request conversion Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> * Update Sonobi adapter with GVLID (#8860) * dgkeyword RTD provider: fix tests causing ID5 test failures (#8862) * Id5 id configurable fetch flow (#8784) Co-authored-by: Paweł Kowalski <pkowalski@id5.io> * NextMillenium Bid Adapter: Remove ortb2 referrerInfo (#8868) * remove ortb2, get device/site manually * updated tests * remove fallbacks * no need to craete variable if there is no fallback (return in place) * removed one test case Co-authored-by: Yakov Klein <yakovklein@Yakovs-MacBook-Air.local> * adserver.js : remove unused code (#8855) * Displayio Bid Adapter: custom render; fix eids payload (#8847) * Custom render; call pubmatic get user id function is removed * use refererInfo; remove call createEidsArray * VidCrunch LLC bidder (#8872) Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Co-authored-by: Prebid.js automated release <prebidjs-release@prebid.org> Co-authored-by: m-oranskaya <99481039+m-oranskaya@users.noreply.github.com> Co-authored-by: Love Sharma <sharmak.love@gmail.com> Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> Co-authored-by: Léonard Labat <le.labat@criteo.com> Co-authored-by: wsusrasp <106743463+wsusrasp@users.noreply.github.com> Co-authored-by: Catalin Ciocov <catalin.ciocov@gmail.com> Co-authored-by: Mike Miller <mike@solitaired.com> Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> Co-authored-by: Scott Menzer <scott@id5.io> Co-authored-by: Paweł Kowalski <pkowalski@id5.io> Co-authored-by: JacobKlein26 <42449375+JacobKlein26@users.noreply.github.com> Co-authored-by: Yakov Klein <yakovklein@Yakovs-MacBook-Air.local> Co-authored-by: caseywhitmire <60086994+caseywhitmire@users.noreply.github.com> Co-authored-by: philan15 <37775368+philan15@users.noreply.github.com> Co-authored-by: Gena <wertixvost@gmail.com>

NikolaevAlexander · 2022-08-25T09:05:30Z

Please tell the approximate time when you will be able to add our module on https://docs.prebid.org/download.html in the "User ID Modules" section. It is very important for us. Several clients that use prebid are looking forward to being able to generate code.

* Create codeql-analysis.yml * Update codeql-analysis.yml * Update instream.html * Update emx_digitalBidAdapter_spec.js * Update index.js * Update index.js * Update index.js * Merge master (#8873) * Readme: remove dead dev dependency and maintenance badges (#8849) * Readme: remove dead dev dependency badge and issue * Remove maintainability and add back issues * Prebid 7.11.0 release * Increment version to 7.12.0-pre * Adriver Bid and Id Modules: buyerid bug fix (#8768) * initial commit * adriver id submodule add * add id system tests, fix adriver bid adapter tests * adriver: fix buyerid * remarks fixing * removal of excess * delete custom parameter * bug fixes * handle native response privacy link (#8838) Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> * Criteo Bid Adapter - Add support for banner+native multiformat ad unit (#8842) Previously, the use of a native adunit was exclusive with the banner type. * Ras Bid Adapter: support for SlotSequence parameter (#8792) * add rasbidadapter pos param * Read pos off the adunit * rename conflicting pos parameter for clarity * Improve Digital adapter: refactor code to align with latest RAZR creative tags (#8827) * IX Bid Adapter: Native OpenRTB Request Support (#8853) * fix native click trackers to only fire on click * fix unit tests for ix * remove version for native requests * remove unnecessary request conversion Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> * Update Sonobi adapter with GVLID (#8860) * dgkeyword RTD provider: fix tests causing ID5 test failures (#8862) * Id5 id configurable fetch flow (#8784) Co-authored-by: Paweł Kowalski <pkowalski@id5.io> * NextMillenium Bid Adapter: Remove ortb2 referrerInfo (#8868) * remove ortb2, get device/site manually * updated tests * remove fallbacks * no need to craete variable if there is no fallback (return in place) * removed one test case Co-authored-by: Yakov Klein <yakovklein@Yakovs-MacBook-Air.local> * adserver.js : remove unused code (#8855) * Displayio Bid Adapter: custom render; fix eids payload (#8847) * Custom render; call pubmatic get user id function is removed * use refererInfo; remove call createEidsArray * VidCrunch LLC bidder (#8872) Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Co-authored-by: Prebid.js automated release <prebidjs-release@prebid.org> Co-authored-by: m-oranskaya <99481039+m-oranskaya@users.noreply.github.com> Co-authored-by: Love Sharma <sharmak.love@gmail.com> Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> Co-authored-by: Léonard Labat <le.labat@criteo.com> Co-authored-by: wsusrasp <106743463+wsusrasp@users.noreply.github.com> Co-authored-by: Catalin Ciocov <catalin.ciocov@gmail.com> Co-authored-by: Mike Miller <mike@solitaired.com> Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> Co-authored-by: Scott Menzer <scott@id5.io> Co-authored-by: Paweł Kowalski <pkowalski@id5.io> Co-authored-by: JacobKlein26 <42449375+JacobKlein26@users.noreply.github.com> Co-authored-by: Yakov Klein <yakovklein@Yakovs-MacBook-Air.local> Co-authored-by: caseywhitmire <60086994+caseywhitmire@users.noreply.github.com> Co-authored-by: philan15 <37775368+philan15@users.noreply.github.com> Co-authored-by: Gena <wertixvost@gmail.com> * Revert "Merge master (#8873)" (#8911) This reverts commit 07c5369. * Update code scan config * Update viewability * Sanitize JSON for adgeneration Co-authored-by: Patrick McCann <patmmccann@gmail.com> Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Co-authored-by: Prebid.js automated release <prebidjs-release@prebid.org> Co-authored-by: m-oranskaya <99481039+m-oranskaya@users.noreply.github.com> Co-authored-by: Love Sharma <sharmak.love@gmail.com> Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> Co-authored-by: Léonard Labat <le.labat@criteo.com> Co-authored-by: wsusrasp <106743463+wsusrasp@users.noreply.github.com> Co-authored-by: Catalin Ciocov <catalin.ciocov@gmail.com> Co-authored-by: Mike Miller <mike@solitaired.com> Co-authored-by: Scott Menzer <scott@id5.io> Co-authored-by: Paweł Kowalski <pkowalski@id5.io> Co-authored-by: JacobKlein26 <42449375+JacobKlein26@users.noreply.github.com> Co-authored-by: Yakov Klein <yakovklein@Yakovs-MacBook-Air.local> Co-authored-by: caseywhitmire <60086994+caseywhitmire@users.noreply.github.com> Co-authored-by: philan15 <37775368+philan15@users.noreply.github.com> Co-authored-by: Gena <wertixvost@gmail.com>

Fix Adriver ID system test failures (https://app.circleci.com/pipelines/github/prebid/Prebid.js/13137/workflows/5e686ed9-e57e-47b3-9c4e-8beea10be321/jobs/24200). This was already done in prebid#8489, but prebid#8768 undid it.

Fix Adriver ID system test failures (https://app.circleci.com/pipelines/github/prebid/Prebid.js/13137/workflows/5e686ed9-e57e-47b3-9c4e-8beea10be321/jobs/24200). This was already done in #8489, but #8768 undid it.

NikolaevAlexander · 2022-12-14T08:15:47Z

Hello, @osazos, @ChrisHuie, @patmmccann !
It has been 4 months since these changes were made.
When you will be able to add our module on https://docs.prebid.org/download.html in the "User ID Modules" section?
It's very important for us and our customers to be able to download it from this page.
Is there any problem with it? What should we do to make it happen?

NikolaevAlexander · 2022-12-20T07:03:30Z

Hello, @osazos, @ChrisHuie, @patmmccann !
Please, help us with this problem!

osazos · 2022-12-21T05:58:20Z

Hi @NikolaevAlexander,

Actually you only have your bidAdapter documented.

You have to create a new PR in https://github.com/prebid/prebid.github.io to add your user id module.

add dev-docs/modules/userid-submodules/adriver.md
update download.md

Take a look at others modules files as example.

Sorry for the response delay.

NikolaevAlexander · 2022-12-22T08:20:51Z

Hi @osazos ! Thank you for the information.

* initial commit * adriver id submodule add * add id system tests, fix adriver bid adapter tests * adriver: fix buyerid * remarks fixing * removal of excess * delete custom parameter * bug fixes

* Create codeql-analysis.yml * Update codeql-analysis.yml * Update instream.html * Update emx_digitalBidAdapter_spec.js * Update index.js * Update index.js * Update index.js * Merge master (prebid#8873) * Readme: remove dead dev dependency and maintenance badges (prebid#8849) * Readme: remove dead dev dependency badge and issue * Remove maintainability and add back issues * Prebid 7.11.0 release * Increment version to 7.12.0-pre * Adriver Bid and Id Modules: buyerid bug fix (prebid#8768) * initial commit * adriver id submodule add * add id system tests, fix adriver bid adapter tests * adriver: fix buyerid * remarks fixing * removal of excess * delete custom parameter * bug fixes * handle native response privacy link (prebid#8838) Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> * Criteo Bid Adapter - Add support for banner+native multiformat ad unit (prebid#8842) Previously, the use of a native adunit was exclusive with the banner type. * Ras Bid Adapter: support for SlotSequence parameter (prebid#8792) * add rasbidadapter pos param * Read pos off the adunit * rename conflicting pos parameter for clarity * Improve Digital adapter: refactor code to align with latest RAZR creative tags (prebid#8827) * IX Bid Adapter: Native OpenRTB Request Support (prebid#8853) * fix native click trackers to only fire on click * fix unit tests for ix * remove version for native requests * remove unnecessary request conversion Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> * Update Sonobi adapter with GVLID (prebid#8860) * dgkeyword RTD provider: fix tests causing ID5 test failures (prebid#8862) * Id5 id configurable fetch flow (prebid#8784) Co-authored-by: Paweł Kowalski <pkowalski@id5.io> * NextMillenium Bid Adapter: Remove ortb2 referrerInfo (prebid#8868) * remove ortb2, get device/site manually * updated tests * remove fallbacks * no need to craete variable if there is no fallback (return in place) * removed one test case Co-authored-by: Yakov Klein <yakovklein@Yakovs-MacBook-Air.local> * adserver.js : remove unused code (prebid#8855) * Displayio Bid Adapter: custom render; fix eids payload (prebid#8847) * Custom render; call pubmatic get user id function is removed * use refererInfo; remove call createEidsArray * VidCrunch LLC bidder (prebid#8872) Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Co-authored-by: Prebid.js automated release <prebidjs-release@prebid.org> Co-authored-by: m-oranskaya <99481039+m-oranskaya@users.noreply.github.com> Co-authored-by: Love Sharma <sharmak.love@gmail.com> Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> Co-authored-by: Léonard Labat <le.labat@criteo.com> Co-authored-by: wsusrasp <106743463+wsusrasp@users.noreply.github.com> Co-authored-by: Catalin Ciocov <catalin.ciocov@gmail.com> Co-authored-by: Mike Miller <mike@solitaired.com> Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> Co-authored-by: Scott Menzer <scott@id5.io> Co-authored-by: Paweł Kowalski <pkowalski@id5.io> Co-authored-by: JacobKlein26 <42449375+JacobKlein26@users.noreply.github.com> Co-authored-by: Yakov Klein <yakovklein@Yakovs-MacBook-Air.local> Co-authored-by: caseywhitmire <60086994+caseywhitmire@users.noreply.github.com> Co-authored-by: philan15 <37775368+philan15@users.noreply.github.com> Co-authored-by: Gena <wertixvost@gmail.com> * Revert "Merge master (prebid#8873)" (prebid#8911) This reverts commit 07c5369. * Update code scan config * Update viewability * Sanitize JSON for adgeneration Co-authored-by: Patrick McCann <patmmccann@gmail.com> Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Co-authored-by: Prebid.js automated release <prebidjs-release@prebid.org> Co-authored-by: m-oranskaya <99481039+m-oranskaya@users.noreply.github.com> Co-authored-by: Love Sharma <sharmak.love@gmail.com> Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> Co-authored-by: Léonard Labat <le.labat@criteo.com> Co-authored-by: wsusrasp <106743463+wsusrasp@users.noreply.github.com> Co-authored-by: Catalin Ciocov <catalin.ciocov@gmail.com> Co-authored-by: Mike Miller <mike@solitaired.com> Co-authored-by: Scott Menzer <scott@id5.io> Co-authored-by: Paweł Kowalski <pkowalski@id5.io> Co-authored-by: JacobKlein26 <42449375+JacobKlein26@users.noreply.github.com> Co-authored-by: Yakov Klein <yakovklein@Yakovs-MacBook-Air.local> Co-authored-by: caseywhitmire <60086994+caseywhitmire@users.noreply.github.com> Co-authored-by: philan15 <37775368+philan15@users.noreply.github.com> Co-authored-by: Gena <wertixvost@gmail.com>

Fix Adriver ID system test failures (https://app.circleci.com/pipelines/github/prebid/Prebid.js/13137/workflows/5e686ed9-e57e-47b3-9c4e-8beea10be321/jobs/24200). This was already done in prebid#8489, but prebid#8768 undid it.

* initial commit * adriver id submodule add * add id system tests, fix adriver bid adapter tests * adriver: fix buyerid * remarks fixing * removal of excess * delete custom parameter * bug fixes

* Create codeql-analysis.yml * Update codeql-analysis.yml * Update instream.html * Update emx_digitalBidAdapter_spec.js * Update index.js * Update index.js * Update index.js * Merge master (prebid#8873) * Readme: remove dead dev dependency and maintenance badges (prebid#8849) * Readme: remove dead dev dependency badge and issue * Remove maintainability and add back issues * Prebid 7.11.0 release * Increment version to 7.12.0-pre * Adriver Bid and Id Modules: buyerid bug fix (prebid#8768) * initial commit * adriver id submodule add * add id system tests, fix adriver bid adapter tests * adriver: fix buyerid * remarks fixing * removal of excess * delete custom parameter * bug fixes * handle native response privacy link (prebid#8838) Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> * Criteo Bid Adapter - Add support for banner+native multiformat ad unit (prebid#8842) Previously, the use of a native adunit was exclusive with the banner type. * Ras Bid Adapter: support for SlotSequence parameter (prebid#8792) * add rasbidadapter pos param * Read pos off the adunit * rename conflicting pos parameter for clarity * Improve Digital adapter: refactor code to align with latest RAZR creative tags (prebid#8827) * IX Bid Adapter: Native OpenRTB Request Support (prebid#8853) * fix native click trackers to only fire on click * fix unit tests for ix * remove version for native requests * remove unnecessary request conversion Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> * Update Sonobi adapter with GVLID (prebid#8860) * dgkeyword RTD provider: fix tests causing ID5 test failures (prebid#8862) * Id5 id configurable fetch flow (prebid#8784) Co-authored-by: Paweł Kowalski <pkowalski@id5.io> * NextMillenium Bid Adapter: Remove ortb2 referrerInfo (prebid#8868) * remove ortb2, get device/site manually * updated tests * remove fallbacks * no need to craete variable if there is no fallback (return in place) * removed one test case Co-authored-by: Yakov Klein <yakovklein@Yakovs-MacBook-Air.local> * adserver.js : remove unused code (prebid#8855) * Displayio Bid Adapter: custom render; fix eids payload (prebid#8847) * Custom render; call pubmatic get user id function is removed * use refererInfo; remove call createEidsArray * VidCrunch LLC bidder (prebid#8872) Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Co-authored-by: Prebid.js automated release <prebidjs-release@prebid.org> Co-authored-by: m-oranskaya <99481039+m-oranskaya@users.noreply.github.com> Co-authored-by: Love Sharma <sharmak.love@gmail.com> Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> Co-authored-by: Léonard Labat <le.labat@criteo.com> Co-authored-by: wsusrasp <106743463+wsusrasp@users.noreply.github.com> Co-authored-by: Catalin Ciocov <catalin.ciocov@gmail.com> Co-authored-by: Mike Miller <mike@solitaired.com> Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> Co-authored-by: Scott Menzer <scott@id5.io> Co-authored-by: Paweł Kowalski <pkowalski@id5.io> Co-authored-by: JacobKlein26 <42449375+JacobKlein26@users.noreply.github.com> Co-authored-by: Yakov Klein <yakovklein@Yakovs-MacBook-Air.local> Co-authored-by: caseywhitmire <60086994+caseywhitmire@users.noreply.github.com> Co-authored-by: philan15 <37775368+philan15@users.noreply.github.com> Co-authored-by: Gena <wertixvost@gmail.com> * Revert "Merge master (prebid#8873)" (prebid#8911) This reverts commit 07c5369. * Update code scan config * Update viewability * Sanitize JSON for adgeneration Co-authored-by: Patrick McCann <patmmccann@gmail.com> Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Co-authored-by: Prebid.js automated release <prebidjs-release@prebid.org> Co-authored-by: m-oranskaya <99481039+m-oranskaya@users.noreply.github.com> Co-authored-by: Love Sharma <sharmak.love@gmail.com> Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> Co-authored-by: Léonard Labat <le.labat@criteo.com> Co-authored-by: wsusrasp <106743463+wsusrasp@users.noreply.github.com> Co-authored-by: Catalin Ciocov <catalin.ciocov@gmail.com> Co-authored-by: Mike Miller <mike@solitaired.com> Co-authored-by: Scott Menzer <scott@id5.io> Co-authored-by: Paweł Kowalski <pkowalski@id5.io> Co-authored-by: JacobKlein26 <42449375+JacobKlein26@users.noreply.github.com> Co-authored-by: Yakov Klein <yakovklein@Yakovs-MacBook-Air.local> Co-authored-by: caseywhitmire <60086994+caseywhitmire@users.noreply.github.com> Co-authored-by: philan15 <37775368+philan15@users.noreply.github.com> Co-authored-by: Gena <wertixvost@gmail.com>

Fix Adriver ID system test failures (https://app.circleci.com/pipelines/github/prebid/Prebid.js/13137/workflows/5e686ed9-e57e-47b3-9c4e-8beea10be321/jobs/24200). This was already done in prebid#8489, but prebid#8768 undid it.

m-oranskaya added 5 commits February 13, 2022 17:14

initial commit

20c8e5d

adriver id submodule add

f57fa61

add id system tests, fix adriver bid adapter tests

5c7cd92

Merge branch 'master' of https://github.com/prebid/Prebid.js

4064948

adriver: fix buyerid

b33b778

jsnellbaker requested a review from osazos August 2, 2022 15:29

jsnellbaker assigned osazos Aug 2, 2022

jsnellbaker added the bugfix label Aug 2, 2022

patmmccann changed the title ~~Adriver: buyerid bug fix~~ Adriver Bid and Id Modules: buyerid bug fix Aug 2, 2022

patmmccann reviewed Aug 10, 2022

View reviewed changes

m-oranskaya added 3 commits August 15, 2022 11:29

remarks fixing

ffb985d

removal of excess

266f8d1

delete custom parameter

b708da0

osazos reviewed Aug 17, 2022

View reviewed changes

bug fixes

b0bd0d9

osazos self-requested a review August 18, 2022 09:11

osazos approved these changes Aug 18, 2022

View reviewed changes

osazos merged commit 94d34d1 into prebid:master Aug 18, 2022

dgirardi mentioned this pull request Sep 9, 2022

Adriver ID system: fix spurious test failure #8978

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adriver Bid and Id Modules: buyerid bug fix #8768

Adriver Bid and Id Modules: buyerid bug fix #8768

m-oranskaya commented Aug 2, 2022 •

edited

Loading

ChrisHuie commented Aug 4, 2022

m-oranskaya commented Aug 10, 2022

osazos commented Aug 10, 2022 •

edited

Loading

patmmccann Aug 10, 2022

patmmccann Aug 11, 2022

m-oranskaya commented Aug 16, 2022

osazos Aug 17, 2022

osazos left a comment

m-oranskaya commented Aug 18, 2022

osazos commented Aug 19, 2022

NikolaevAlexander commented Aug 25, 2022

NikolaevAlexander commented Dec 14, 2022 •

edited

Loading

NikolaevAlexander commented Dec 20, 2022

osazos commented Dec 21, 2022

NikolaevAlexander commented Dec 22, 2022

Adriver Bid and Id Modules: buyerid bug fix #8768

Adriver Bid and Id Modules: buyerid bug fix #8768

Conversation

m-oranskaya commented Aug 2, 2022 • edited Loading

Type of change

Description of change

Other information

ChrisHuie commented Aug 4, 2022

m-oranskaya commented Aug 10, 2022

osazos commented Aug 10, 2022 • edited Loading

patmmccann Aug 10, 2022

Choose a reason for hiding this comment

patmmccann Aug 11, 2022

Choose a reason for hiding this comment

m-oranskaya commented Aug 16, 2022

osazos Aug 17, 2022

Choose a reason for hiding this comment

osazos left a comment

Choose a reason for hiding this comment

m-oranskaya commented Aug 18, 2022

osazos commented Aug 19, 2022

NikolaevAlexander commented Aug 25, 2022

NikolaevAlexander commented Dec 14, 2022 • edited Loading

NikolaevAlexander commented Dec 20, 2022

osazos commented Dec 21, 2022

NikolaevAlexander commented Dec 22, 2022

m-oranskaya commented Aug 2, 2022 •

edited

Loading

osazos commented Aug 10, 2022 •

edited

Loading

NikolaevAlexander commented Dec 14, 2022 •

edited

Loading