-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Displayio Bid Adapter: custom render; fix eids payload #8847
Displayio Bid Adapter: custom render; fix eids payload #8847
Conversation
modules/displayioBidAdapter.js
Outdated
domain: window.location.hostname, | ||
page: window.location.href, | ||
ref: refererInfo.referer, | ||
userids: deepAccess(bid, 'userId') ? createEidsArray(bid.userId) : {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you shouldn't need to import createEidsArray. The output of this function is already on the bid request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patmmccann Thank you for help! fixed
modules/displayioBidAdapter.js
Outdated
lang_content: document.documentElement.lang, | ||
lang: window.navigator.language, | ||
domain: window.location.hostname, | ||
page: window.location.href, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not refererInfo.page
* Readme: remove dead dev dependency and maintenance badges (#8849) * Readme: remove dead dev dependency badge and issue * Remove maintainability and add back issues * Prebid 7.11.0 release * Increment version to 7.12.0-pre * Adriver Bid and Id Modules: buyerid bug fix (#8768) * initial commit * adriver id submodule add * add id system tests, fix adriver bid adapter tests * adriver: fix buyerid * remarks fixing * removal of excess * delete custom parameter * bug fixes * handle native response privacy link (#8838) Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> * Criteo Bid Adapter - Add support for banner+native multiformat ad unit (#8842) Previously, the use of a native adunit was exclusive with the banner type. * Ras Bid Adapter: support for SlotSequence parameter (#8792) * add rasbidadapter pos param * Read pos off the adunit * rename conflicting pos parameter for clarity * Improve Digital adapter: refactor code to align with latest RAZR creative tags (#8827) * IX Bid Adapter: Native OpenRTB Request Support (#8853) * fix native click trackers to only fire on click * fix unit tests for ix * remove version for native requests * remove unnecessary request conversion Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> * Update Sonobi adapter with GVLID (#8860) * dgkeyword RTD provider: fix tests causing ID5 test failures (#8862) * Id5 id configurable fetch flow (#8784) Co-authored-by: Paweł Kowalski <pkowalski@id5.io> * NextMillenium Bid Adapter: Remove ortb2 referrerInfo (#8868) * remove ortb2, get device/site manually * updated tests * remove fallbacks * no need to craete variable if there is no fallback (return in place) * removed one test case Co-authored-by: Yakov Klein <yakovklein@Yakovs-MacBook-Air.local> * adserver.js : remove unused code (#8855) * Displayio Bid Adapter: custom render; fix eids payload (#8847) * Custom render; call pubmatic get user id function is removed * use refererInfo; remove call createEidsArray * VidCrunch LLC bidder (#8872) Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Co-authored-by: Prebid.js automated release <prebidjs-release@prebid.org> Co-authored-by: m-oranskaya <99481039+m-oranskaya@users.noreply.github.com> Co-authored-by: Love Sharma <sharmak.love@gmail.com> Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> Co-authored-by: Léonard Labat <le.labat@criteo.com> Co-authored-by: wsusrasp <106743463+wsusrasp@users.noreply.github.com> Co-authored-by: Catalin Ciocov <catalin.ciocov@gmail.com> Co-authored-by: Mike Miller <mike@solitaired.com> Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> Co-authored-by: Scott Menzer <scott@id5.io> Co-authored-by: Paweł Kowalski <pkowalski@id5.io> Co-authored-by: JacobKlein26 <42449375+JacobKlein26@users.noreply.github.com> Co-authored-by: Yakov Klein <yakovklein@Yakovs-MacBook-Air.local> Co-authored-by: caseywhitmire <60086994+caseywhitmire@users.noreply.github.com> Co-authored-by: philan15 <37775368+philan15@users.noreply.github.com> Co-authored-by: Gena <wertixvost@gmail.com>
* Create codeql-analysis.yml * Update codeql-analysis.yml * Update instream.html * Update emx_digitalBidAdapter_spec.js * Update index.js * Update index.js * Update index.js * Merge master (#8873) * Readme: remove dead dev dependency and maintenance badges (#8849) * Readme: remove dead dev dependency badge and issue * Remove maintainability and add back issues * Prebid 7.11.0 release * Increment version to 7.12.0-pre * Adriver Bid and Id Modules: buyerid bug fix (#8768) * initial commit * adriver id submodule add * add id system tests, fix adriver bid adapter tests * adriver: fix buyerid * remarks fixing * removal of excess * delete custom parameter * bug fixes * handle native response privacy link (#8838) Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> * Criteo Bid Adapter - Add support for banner+native multiformat ad unit (#8842) Previously, the use of a native adunit was exclusive with the banner type. * Ras Bid Adapter: support for SlotSequence parameter (#8792) * add rasbidadapter pos param * Read pos off the adunit * rename conflicting pos parameter for clarity * Improve Digital adapter: refactor code to align with latest RAZR creative tags (#8827) * IX Bid Adapter: Native OpenRTB Request Support (#8853) * fix native click trackers to only fire on click * fix unit tests for ix * remove version for native requests * remove unnecessary request conversion Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> * Update Sonobi adapter with GVLID (#8860) * dgkeyword RTD provider: fix tests causing ID5 test failures (#8862) * Id5 id configurable fetch flow (#8784) Co-authored-by: Paweł Kowalski <pkowalski@id5.io> * NextMillenium Bid Adapter: Remove ortb2 referrerInfo (#8868) * remove ortb2, get device/site manually * updated tests * remove fallbacks * no need to craete variable if there is no fallback (return in place) * removed one test case Co-authored-by: Yakov Klein <yakovklein@Yakovs-MacBook-Air.local> * adserver.js : remove unused code (#8855) * Displayio Bid Adapter: custom render; fix eids payload (#8847) * Custom render; call pubmatic get user id function is removed * use refererInfo; remove call createEidsArray * VidCrunch LLC bidder (#8872) Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Co-authored-by: Prebid.js automated release <prebidjs-release@prebid.org> Co-authored-by: m-oranskaya <99481039+m-oranskaya@users.noreply.github.com> Co-authored-by: Love Sharma <sharmak.love@gmail.com> Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> Co-authored-by: Léonard Labat <le.labat@criteo.com> Co-authored-by: wsusrasp <106743463+wsusrasp@users.noreply.github.com> Co-authored-by: Catalin Ciocov <catalin.ciocov@gmail.com> Co-authored-by: Mike Miller <mike@solitaired.com> Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> Co-authored-by: Scott Menzer <scott@id5.io> Co-authored-by: Paweł Kowalski <pkowalski@id5.io> Co-authored-by: JacobKlein26 <42449375+JacobKlein26@users.noreply.github.com> Co-authored-by: Yakov Klein <yakovklein@Yakovs-MacBook-Air.local> Co-authored-by: caseywhitmire <60086994+caseywhitmire@users.noreply.github.com> Co-authored-by: philan15 <37775368+philan15@users.noreply.github.com> Co-authored-by: Gena <wertixvost@gmail.com> * Revert "Merge master (#8873)" (#8911) This reverts commit 07c5369. * Update code scan config * Update viewability * Sanitize JSON for adgeneration Co-authored-by: Patrick McCann <patmmccann@gmail.com> Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Co-authored-by: Prebid.js automated release <prebidjs-release@prebid.org> Co-authored-by: m-oranskaya <99481039+m-oranskaya@users.noreply.github.com> Co-authored-by: Love Sharma <sharmak.love@gmail.com> Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> Co-authored-by: Léonard Labat <le.labat@criteo.com> Co-authored-by: wsusrasp <106743463+wsusrasp@users.noreply.github.com> Co-authored-by: Catalin Ciocov <catalin.ciocov@gmail.com> Co-authored-by: Mike Miller <mike@solitaired.com> Co-authored-by: Scott Menzer <scott@id5.io> Co-authored-by: Paweł Kowalski <pkowalski@id5.io> Co-authored-by: JacobKlein26 <42449375+JacobKlein26@users.noreply.github.com> Co-authored-by: Yakov Klein <yakovklein@Yakovs-MacBook-Air.local> Co-authored-by: caseywhitmire <60086994+caseywhitmire@users.noreply.github.com> Co-authored-by: philan15 <37775368+philan15@users.noreply.github.com> Co-authored-by: Gena <wertixvost@gmail.com>
* Custom render; call pubmatic get user id function is removed * use refererInfo; remove call createEidsArray
* Create codeql-analysis.yml * Update codeql-analysis.yml * Update instream.html * Update emx_digitalBidAdapter_spec.js * Update index.js * Update index.js * Update index.js * Merge master (prebid#8873) * Readme: remove dead dev dependency and maintenance badges (prebid#8849) * Readme: remove dead dev dependency badge and issue * Remove maintainability and add back issues * Prebid 7.11.0 release * Increment version to 7.12.0-pre * Adriver Bid and Id Modules: buyerid bug fix (prebid#8768) * initial commit * adriver id submodule add * add id system tests, fix adriver bid adapter tests * adriver: fix buyerid * remarks fixing * removal of excess * delete custom parameter * bug fixes * handle native response privacy link (prebid#8838) Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> * Criteo Bid Adapter - Add support for banner+native multiformat ad unit (prebid#8842) Previously, the use of a native adunit was exclusive with the banner type. * Ras Bid Adapter: support for SlotSequence parameter (prebid#8792) * add rasbidadapter pos param * Read pos off the adunit * rename conflicting pos parameter for clarity * Improve Digital adapter: refactor code to align with latest RAZR creative tags (prebid#8827) * IX Bid Adapter: Native OpenRTB Request Support (prebid#8853) * fix native click trackers to only fire on click * fix unit tests for ix * remove version for native requests * remove unnecessary request conversion Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> * Update Sonobi adapter with GVLID (prebid#8860) * dgkeyword RTD provider: fix tests causing ID5 test failures (prebid#8862) * Id5 id configurable fetch flow (prebid#8784) Co-authored-by: Paweł Kowalski <pkowalski@id5.io> * NextMillenium Bid Adapter: Remove ortb2 referrerInfo (prebid#8868) * remove ortb2, get device/site manually * updated tests * remove fallbacks * no need to craete variable if there is no fallback (return in place) * removed one test case Co-authored-by: Yakov Klein <yakovklein@Yakovs-MacBook-Air.local> * adserver.js : remove unused code (prebid#8855) * Displayio Bid Adapter: custom render; fix eids payload (prebid#8847) * Custom render; call pubmatic get user id function is removed * use refererInfo; remove call createEidsArray * VidCrunch LLC bidder (prebid#8872) Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Co-authored-by: Prebid.js automated release <prebidjs-release@prebid.org> Co-authored-by: m-oranskaya <99481039+m-oranskaya@users.noreply.github.com> Co-authored-by: Love Sharma <sharmak.love@gmail.com> Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> Co-authored-by: Léonard Labat <le.labat@criteo.com> Co-authored-by: wsusrasp <106743463+wsusrasp@users.noreply.github.com> Co-authored-by: Catalin Ciocov <catalin.ciocov@gmail.com> Co-authored-by: Mike Miller <mike@solitaired.com> Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> Co-authored-by: Scott Menzer <scott@id5.io> Co-authored-by: Paweł Kowalski <pkowalski@id5.io> Co-authored-by: JacobKlein26 <42449375+JacobKlein26@users.noreply.github.com> Co-authored-by: Yakov Klein <yakovklein@Yakovs-MacBook-Air.local> Co-authored-by: caseywhitmire <60086994+caseywhitmire@users.noreply.github.com> Co-authored-by: philan15 <37775368+philan15@users.noreply.github.com> Co-authored-by: Gena <wertixvost@gmail.com> * Revert "Merge master (prebid#8873)" (prebid#8911) This reverts commit 07c5369. * Update code scan config * Update viewability * Sanitize JSON for adgeneration Co-authored-by: Patrick McCann <patmmccann@gmail.com> Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Co-authored-by: Prebid.js automated release <prebidjs-release@prebid.org> Co-authored-by: m-oranskaya <99481039+m-oranskaya@users.noreply.github.com> Co-authored-by: Love Sharma <sharmak.love@gmail.com> Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> Co-authored-by: Léonard Labat <le.labat@criteo.com> Co-authored-by: wsusrasp <106743463+wsusrasp@users.noreply.github.com> Co-authored-by: Catalin Ciocov <catalin.ciocov@gmail.com> Co-authored-by: Mike Miller <mike@solitaired.com> Co-authored-by: Scott Menzer <scott@id5.io> Co-authored-by: Paweł Kowalski <pkowalski@id5.io> Co-authored-by: JacobKlein26 <42449375+JacobKlein26@users.noreply.github.com> Co-authored-by: Yakov Klein <yakovklein@Yakovs-MacBook-Air.local> Co-authored-by: caseywhitmire <60086994+caseywhitmire@users.noreply.github.com> Co-authored-by: philan15 <37775368+philan15@users.noreply.github.com> Co-authored-by: Gena <wertixvost@gmail.com>
* Custom render; call pubmatic get user id function is removed * use refererInfo; remove call createEidsArray
* Create codeql-analysis.yml * Update codeql-analysis.yml * Update instream.html * Update emx_digitalBidAdapter_spec.js * Update index.js * Update index.js * Update index.js * Merge master (prebid#8873) * Readme: remove dead dev dependency and maintenance badges (prebid#8849) * Readme: remove dead dev dependency badge and issue * Remove maintainability and add back issues * Prebid 7.11.0 release * Increment version to 7.12.0-pre * Adriver Bid and Id Modules: buyerid bug fix (prebid#8768) * initial commit * adriver id submodule add * add id system tests, fix adriver bid adapter tests * adriver: fix buyerid * remarks fixing * removal of excess * delete custom parameter * bug fixes * handle native response privacy link (prebid#8838) Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> * Criteo Bid Adapter - Add support for banner+native multiformat ad unit (prebid#8842) Previously, the use of a native adunit was exclusive with the banner type. * Ras Bid Adapter: support for SlotSequence parameter (prebid#8792) * add rasbidadapter pos param * Read pos off the adunit * rename conflicting pos parameter for clarity * Improve Digital adapter: refactor code to align with latest RAZR creative tags (prebid#8827) * IX Bid Adapter: Native OpenRTB Request Support (prebid#8853) * fix native click trackers to only fire on click * fix unit tests for ix * remove version for native requests * remove unnecessary request conversion Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> * Update Sonobi adapter with GVLID (prebid#8860) * dgkeyword RTD provider: fix tests causing ID5 test failures (prebid#8862) * Id5 id configurable fetch flow (prebid#8784) Co-authored-by: Paweł Kowalski <pkowalski@id5.io> * NextMillenium Bid Adapter: Remove ortb2 referrerInfo (prebid#8868) * remove ortb2, get device/site manually * updated tests * remove fallbacks * no need to craete variable if there is no fallback (return in place) * removed one test case Co-authored-by: Yakov Klein <yakovklein@Yakovs-MacBook-Air.local> * adserver.js : remove unused code (prebid#8855) * Displayio Bid Adapter: custom render; fix eids payload (prebid#8847) * Custom render; call pubmatic get user id function is removed * use refererInfo; remove call createEidsArray * VidCrunch LLC bidder (prebid#8872) Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Co-authored-by: Prebid.js automated release <prebidjs-release@prebid.org> Co-authored-by: m-oranskaya <99481039+m-oranskaya@users.noreply.github.com> Co-authored-by: Love Sharma <sharmak.love@gmail.com> Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> Co-authored-by: Léonard Labat <le.labat@criteo.com> Co-authored-by: wsusrasp <106743463+wsusrasp@users.noreply.github.com> Co-authored-by: Catalin Ciocov <catalin.ciocov@gmail.com> Co-authored-by: Mike Miller <mike@solitaired.com> Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> Co-authored-by: Scott Menzer <scott@id5.io> Co-authored-by: Paweł Kowalski <pkowalski@id5.io> Co-authored-by: JacobKlein26 <42449375+JacobKlein26@users.noreply.github.com> Co-authored-by: Yakov Klein <yakovklein@Yakovs-MacBook-Air.local> Co-authored-by: caseywhitmire <60086994+caseywhitmire@users.noreply.github.com> Co-authored-by: philan15 <37775368+philan15@users.noreply.github.com> Co-authored-by: Gena <wertixvost@gmail.com> * Revert "Merge master (prebid#8873)" (prebid#8911) This reverts commit 07c5369. * Update code scan config * Update viewability * Sanitize JSON for adgeneration Co-authored-by: Patrick McCann <patmmccann@gmail.com> Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Co-authored-by: Prebid.js automated release <prebidjs-release@prebid.org> Co-authored-by: m-oranskaya <99481039+m-oranskaya@users.noreply.github.com> Co-authored-by: Love Sharma <sharmak.love@gmail.com> Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> Co-authored-by: Léonard Labat <le.labat@criteo.com> Co-authored-by: wsusrasp <106743463+wsusrasp@users.noreply.github.com> Co-authored-by: Catalin Ciocov <catalin.ciocov@gmail.com> Co-authored-by: Mike Miller <mike@solitaired.com> Co-authored-by: Scott Menzer <scott@id5.io> Co-authored-by: Paweł Kowalski <pkowalski@id5.io> Co-authored-by: JacobKlein26 <42449375+JacobKlein26@users.noreply.github.com> Co-authored-by: Yakov Klein <yakovklein@Yakovs-MacBook-Air.local> Co-authored-by: caseywhitmire <60086994+caseywhitmire@users.noreply.github.com> Co-authored-by: philan15 <37775368+philan15@users.noreply.github.com> Co-authored-by: Gena <wertixvost@gmail.com>
Type of change
Description of change
Updated documentation: prebid/prebid.github.io#3961