Skip to content

V11 update 10 13 #4257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jan 16, 2024
Merged

V11 update 10 13 #4257

merged 18 commits into from
Jan 16, 2024

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Jan 16, 2024

Backport the 10.13 release line... The prettier bump included a lot of formatting fixes just like #3945

Copy link

github-actions bot commented Jan 16, 2024

📊 Tachometer Benchmark Results

Summary

duration

  • 03_update10th1k_x16: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • 07_create10k: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • filter_list: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • hydrate1k: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • many_updates: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • text_update: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • todo: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main

usedJSHeapSize

  • 03_update10th1k_x16: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • 07_create10k: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • filter_list: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • hydrate1k: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • many_updates: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • text_update: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • todo: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main

Results

03_update10th1k_x16

duration

VersionAvg timevs preact-mastervs preact-local
preact-master2.48ms - 2.59ms-faster ✔
92% - 92%
29.43ms - 30.18ms
preact-local31.97ms - 32.71msslower ❌
1146% - 1208%
29.43ms - 30.18ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.66ms - 3.66ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-local3.66ms - 3.67msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms
-
07_create10k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master902.00ms - 929.45ms-unsure 🔍
-1% - +2%
-5.75ms - +22.28ms
preact-local904.64ms - 910.28msunsure 🔍
-2% - +1%
-22.28ms - +5.75ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master26.68ms - 26.69ms-slower ❌
2% - 2%
0.40ms - 0.42ms
preact-local26.27ms - 26.28msfaster ✔
2% - 2%
0.40ms - 0.42ms
-
filter_list

duration

VersionAvg timevs preact-mastervs preact-local
preact-master123.21ms - 124.33ms-unsure 🔍
-1% - +0%
-1.46ms - +0.58ms
preact-local123.35ms - 125.07msunsure 🔍
-0% - +1%
-0.58ms - +1.46ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.68ms - 1.68ms-unsure 🔍
-0% - +1%
-0.00ms - +0.01ms
preact-local1.67ms - 1.68msunsure 🔍
-1% - +0%
-0.01ms - +0.00ms
-
hydrate1k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master61.93ms - 64.56ms-faster ✔
3% - 8%
1.66ms - 5.17ms
preact-local65.50ms - 67.82msslower ❌
3% - 8%
1.66ms - 5.17ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master10.81ms - 11.28ms-unsure 🔍
-3% - +3%
-0.38ms - +0.32ms
preact-local10.82ms - 11.33msunsure 🔍
-3% - +3%
-0.32ms - +0.38ms
-
many_updates

duration

VersionAvg timevs preact-mastervs preact-local
preact-master114.91ms - 118.80ms-unsure 🔍
-4% - +2%
-4.66ms - +2.46ms
preact-local114.97ms - 120.94msunsure 🔍
-2% - +4%
-2.46ms - +4.66ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master5.03ms - 5.05ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-local5.03ms - 5.05msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms
-
text_update

duration

VersionAvg timevs preact-mastervs preact-local
preact-master30.22ms - 31.13ms-unsure 🔍
-1% - +2%
-0.34ms - +0.63ms
preact-local30.37ms - 30.69msunsure 🔍
-2% - +1%
-0.63ms - +0.34ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.92ms - 0.93ms-unsure 🔍
-2% - +1%
-0.01ms - +0.01ms
preact-local0.92ms - 0.93msunsure 🔍
-1% - +2%
-0.01ms - +0.01ms
-
todo

duration

VersionAvg timevs preact-mastervs preact-local
preact-master20.51ms - 21.22ms-unsure 🔍
-1% - +3%
-0.18ms - +0.56ms
preact-local20.56ms - 20.80msunsure 🔍
-3% - +1%
-0.56ms - +0.18ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.95ms - 0.97ms-unsure 🔍
-1% - +0%
-0.01ms - +0.00ms
preact-local0.96ms - 0.96msunsure 🔍
-0% - +1%
-0.00ms - +0.01ms
-

tachometer-reporter-action v2 for Benchmarks

Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@JoviDeCroock
Copy link
Member Author

JoviDeCroock commented Jan 16, 2024

@marvinhagemeister @andrewiggins not sure what's going on here, all works fine locally atm

EDIT: apparently the added newline in mangle.json borked it

@JoviDeCroock JoviDeCroock force-pushed the v11-update-10-13 branch 4 times, most recently from f1d132d to 7098163 Compare January 16, 2024 12:02
@coveralls
Copy link

coveralls commented Jan 16, 2024

Coverage Status

coverage: 99.172% (-0.3%) from 99.433%
when pulling 11f039a on v11-update-10-13
into 36ef4e8 on v11.

@JoviDeCroock JoviDeCroock merged commit 4601cf3 into v11 Jan 16, 2024
@JoviDeCroock JoviDeCroock deleted the v11-update-10-13 branch January 16, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants