Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent memory leak with currentComponent by unsetting it in diffed #3908

Merged
merged 2 commits into from
Feb 21, 2023

Conversation

JoviDeCroock
Copy link
Member

fixes #3907

@coveralls
Copy link

coveralls commented Feb 21, 2023

Coverage Status

Coverage: 99.548%. Remained the same when pulling 36c70aa on prevent-memory-leak into cc88ae6 on master.

@github-actions
Copy link

github-actions bot commented Feb 21, 2023

Size Change: +9 B (0%)

Total Size: 54.2 kB

Filename Size Change
compat/dist/compat.js 3.88 kB +2 B (0%)
compat/dist/compat.module.js 3.82 kB +3 B (0%)
compat/dist/compat.umd.js 3.95 kB +4 B (0%)
ℹ️ View Unchanged
Filename Size Change
debug/dist/debug.js 3 kB 0 B
debug/dist/debug.module.js 3.01 kB 0 B
debug/dist/debug.umd.js 3.08 kB 0 B
devtools/dist/devtools.js 231 B 0 B
devtools/dist/devtools.module.js 240 B 0 B
devtools/dist/devtools.umd.js 314 B 0 B
dist/preact.js 4.24 kB 0 B
dist/preact.min.js 4.26 kB 0 B
dist/preact.min.module.js 4.26 kB 0 B
dist/preact.min.umd.js 4.29 kB 0 B
dist/preact.module.js 4.25 kB 0 B
dist/preact.umd.js 4.31 kB 0 B
hooks/dist/hooks.js 1.49 kB 0 B
hooks/dist/hooks.module.js 1.52 kB 0 B
hooks/dist/hooks.umd.js 1.57 kB 0 B
jsx-runtime/dist/jsxRuntime.js 360 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 326 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 441 B 0 B
test-utils/dist/testUtils.js 442 B 0 B
test-utils/dist/testUtils.module.js 444 B 0 B
test-utils/dist/testUtils.umd.js 526 B 0 B

compressed-size-action

@JoviDeCroock JoviDeCroock merged commit f409692 into master Feb 21, 2023
@JoviDeCroock JoviDeCroock deleted the prevent-memory-leak branch February 21, 2023 10:24
JoviDeCroock added a commit that referenced this pull request Jan 16, 2024
JoviDeCroock added a commit that referenced this pull request Jan 16, 2024
* backport #3911

* backport #3906

* backport #3837

* backport #3908

* backport #3904

* backport #3905

* backport #3898

* backport #3910

* backport #3948

* backport #3941

* backport #3945

* backport #3919

* backport #3922

* backport #3921

* backport #3903

* fix lint

* update more

* debug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preact-compat is 'pinning' render call's containerNode in static scope causing DOM leaks
3 participants