Trying a few compat optimizations #3903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JoviDeCroock
commented
Feb 18, 2023
JoviDeCroock
commented
- hoist regexes
- remove case insensitive regex
|
Size Change: +34 B (0%) Total Size: 54.1 kB
ℹ️ View Unchanged
|
marvinhagemeister
approved these changes
Feb 21, 2023
|
Oh also, do you have some way you are measuring these? It's on my list to build benchmarks for compat eventually lol (but that's a long ways away for now) |
|
@andrewiggins I measure these with importing compat during the rts benchmark |
andrewiggins
approved these changes
Feb 25, 2023
Co-authored-by: Andre Wiggins <459878+andrewiggins@users.noreply.github.com>
JoviDeCroock
force-pushed
the
compat-optimizations
branch
from
af8f791 to
876b2e2
Compare
developit
reviewed
Feb 26, 2023
compat/src/render.js
Outdated
Comment on lines
17
to
19
| const ON_BLUR = /^onblur$/; | ||
| const ON_FOCUS = /^onfocus$/; | ||
| const ON_INPUT = /^oninput$/; |
There was a problem hiding this comment.
Since we're lower-casing preemptively now, I bet we could get away with inlining these as straight equality checks (lowerCased === 'onfocus'). Should be faster than the regex.
There was a problem hiding this comment.
Good shout, the camel props one is still the one hurting perf the most 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.