Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[other]ME 추가로 인해 변경된 src/locales/ko/*.json #2

Merged
merged 19 commits into from
Sep 16, 2024

Conversation

sodaMelon
Copy link

@sodaMelon sodaMelon commented Sep 12, 2024

image
config.ts 말고 다른 것을 추출했습니다.

번역 완료 상태

  • battle.json
  • bgm-name.json
    - [ ] config.ts
  • dialogue.json
  • egg.json
  • modifier-type.json
  • mystery-encounter-message.json

@sodaMelon
Copy link
Author

@KimJeongSun @EnochG1 @returntoice
천천히 봐주세요~ #1 얘처럼 번역을해주셔도 되고
아니면 이런식으로 suggestion 쓸수 있게 올려주시면됩니당

Copy link

@KimJeongSun KimJeongSun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

대사는 github UI 에서 작업하기 너무 불편해서 나눌게요

src/locales/ko/battle.json Outdated Show resolved Hide resolved
src/locales/ko/egg.json Outdated Show resolved Hide resolved
src/locales/ko/mystery-encounter-messages.json Outdated Show resolved Hide resolved
@sodaMelon
Copy link
Author

For those who already started to translate MEs, 3 new entries have been added to mystery-encounter-messages.json and modifier-type.json, so allow me to ping you to be sure you wont miss them
<@&1258563150584872983>

@KimJeongSun
Copy link

트레이너 대사, 아이템 설명 및 UI 메시지 번역 초안 작성되었습니다.
트레이너 대사는 말뭉치에서 최대한 찾아서 사용했습니다. ( 일부 대사는 정말 번역이 별로지만, 그래도 본가 대사이니 유지했습니다. )
패배 시 대사는 대부분이 없어서 캐릭터에 맞춰서 새로 작성했습니다.
아이템 설명은 되도록 다른 아이템 대사와 통일감 있게 작성했습니다.
base stat 은 종족값, stats 는 능력치 로 번역했습니다 (공격, 특공 처럼 능력치 자체에는 번역이 따로 없어서, 임의로 능력치 라고 썼습니다 )
배경음악은 이미 미번역 항목들이 ME 전에도 쌓여있기도 하고 우선도가 낮아서, 하더라도 ME 이후에 진행하면 될것같습니다

확인하시고 의견주세요! 내일까지 확인해서 etc 에 대해 merge 진행하겠습니다

src/locales/ko/dialogue.json Outdated Show resolved Hide resolved
src/locales/ko/dialogue.json Outdated Show resolved Hide resolved
src/locales/ko/dialogue.json Outdated Show resolved Hide resolved
src/locales/ko/dialogue.json Outdated Show resolved Hide resolved
src/locales/ko/dialogue.json Outdated Show resolved Hide resolved
src/locales/ko/dialogue.json Outdated Show resolved Hide resolved
src/locales/ko/dialogue.json Outdated Show resolved Hide resolved
src/locales/ko/dialogue.json Outdated Show resolved Hide resolved
KimJeongSun and others added 6 commits September 16, 2024 10:01
Co-authored-by: returntoice <dieandbecome@gmail.com>
Co-authored-by: returntoice <dieandbecome@gmail.com>
Co-authored-by: returntoice <dieandbecome@gmail.com>
Co-authored-by: returntoice <dieandbecome@gmail.com>
Co-authored-by: returntoice <dieandbecome@gmail.com>
Co-authored-by: returntoice <dieandbecome@gmail.com>
KimJeongSun and others added 4 commits September 16, 2024 10:02
Co-authored-by: returntoice <dieandbecome@gmail.com>
Co-authored-by: returntoice <dieandbecome@gmail.com>
Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
@KimJeongSun
Copy link

requested changes 모두 반영해서 마무리합니다 ( 텍스트 테스트는 관련 이벤트에서 겸사겸사 진행하는걸로 할게요 )

@KimJeongSun KimJeongSun merged commit 184497b into mystery-encounters-translations Sep 16, 2024
@KimJeongSun KimJeongSun deleted the update-other branch September 17, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants