Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Localization] ME translations #4183

Merged
merged 812 commits into from
Sep 23, 2024
Merged

[Localization] ME translations #4183

merged 812 commits into from
Sep 23, 2024

Conversation

Adri1
Copy link
Contributor

@Adri1 Adri1 commented Sep 11, 2024 •
edited
Loading

What are the changes the user will see?

Translated ME

Completed languages:

  • German
  • Spanish - partial translation
  • French
  • Italian - superficial translation
  • Japanese - partial translation
  • Korean
  • Brazilian Portugese
  • Chinese (Simplified)
  • Chinese (Traditional)

Why am I making these changes?

To have ME translated

What are the changes from a developer perspective?

None

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?

@Adri1 Adri1 added the Localization Provides or updates translation efforts label Sep 11, 2024
@Adri1 Adri1 requested review from a team as code owners September 11, 2024 20:51
@Adri1 Adri1 marked this pull request as draft September 11, 2024 20:51
DanStevensonx
DanStevensonx reviewed Sep 11, 2024
View reviewed changes
Copy link

@DanStevensonx DanStevensonx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translated the battle.json before going to bed

src/locales/es/battle.json Outdated Show resolved Hide resolved
src/locales/es/battle.json Outdated Show resolved Hide resolved
src/locales/es/battle.json Outdated Show resolved Hide resolved
EnochG1
EnochG1 reviewed Sep 11, 2024
View reviewed changes
Copy link
Contributor

@EnochG1 EnochG1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial Korean

src/locales/ko/battle.json Outdated Show resolved Hide resolved
src/locales/ko/battle.json Outdated Show resolved Hide resolved
src/locales/ko/mystery-encounter-messages.json Outdated Show resolved Hide resolved
src/locales/ko/party-ui-handler.json Outdated Show resolved Hide resolved
EnochG1
EnochG1 reviewed Sep 11, 2024
View reviewed changes
src/locales/ko/trainer-titles.json Outdated Show resolved Hide resolved
src/locales/ko/trainer-names.json Outdated Show resolved Hide resolved
@sodaMelon
Copy link
Contributor

It seems like a lot of work to suggest each one here. 🤔
If someone have easy way, please share them

@Adri1
Copy link
Contributor Author

Adri1 commented Sep 12, 2024

It seems like a lot of work to suggest each one here. 🤔 If someone have easy way, please share them

Don't you have the power to make edits directliy from the File changed tab?
If not, maybe try to fork my branch and then, create PR to this branch with your translations

@sodaMelon
Copy link
Contributor

It seems like a lot of work to suggest each one here. 🤔 If someone have easy way, please share them

Don't you have the power to make edits directliy from the File changed tab? If not, maybe try to fork my branch and then, create PR to this branch with your translations

I made korean team repository for ME localization. When it's done, I'll make PR in your repository.

@sodaMelon
Copy link
Contributor

and here is reference for ME Events
it's better to check for story.

Chapybara-jp
Chapybara-jp reviewed Sep 12, 2024
View reviewed changes
src/locales/ja/battle.json Outdated Show resolved Hide resolved
src/locales/ja/bgm-name.json Outdated Show resolved Hide resolved
DanStevensonx
DanStevensonx reviewed Sep 12, 2024
View reviewed changes
Copy link

@DanStevensonx DanStevensonx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translated most from PokeCorpus, some of them weren't available so I had to translate them myself.

src/locales/es/dialogue.json Outdated Show resolved Hide resolved
NicusPulcis
NicusPulcis reviewed Sep 12, 2024
View reviewed changes
src/locales/it/battle.json Outdated Show resolved Hide resolved
src/locales/it/battle.json Outdated Show resolved Hide resolved
src/locales/it/battle.json Outdated Show resolved Hide resolved
src/locales/it/egg.json Outdated Show resolved Hide resolved
src/locales/it/modifier-type.json Outdated Show resolved Hide resolved
src/locales/it/modifier-type.json Outdated Show resolved Hide resolved
src/locales/it/mystery-encounter-messages.json Outdated Show resolved Hide resolved
src/locales/it/party-ui-handler.json Outdated Show resolved Hide resolved
src/locales/it/trainer-names.json Outdated Show resolved Hide resolved
src/locales/it/trainer-titles.json Outdated Show resolved Hide resolved
@NicusPulcis
Copy link
Contributor

added italian localizations for anything but dialogues

DanStevensonx
DanStevensonx reviewed Sep 12, 2024
View reviewed changes
Copy link

@DanStevensonx DanStevensonx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translated to Spanish, needs checking.

src/locales/es/egg.json Outdated Show resolved Hide resolved
src/locales/es/mystery-encounter-messages.json Outdated Show resolved Hide resolved
src/locales/es/mystery-encounters/a-trainers-test-dialogue.json Outdated Show resolved Hide resolved
DanStevensonx
DanStevensonx reviewed Sep 12, 2024
View reviewed changes
Copy link

@DanStevensonx DanStevensonx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translated to Spanish

src/locales/es/bgm-name.json Outdated Show resolved Hide resolved
src/locales/es/modifier-type.json Outdated Show resolved Hide resolved
src/locales/es/modifier-type.json Outdated Show resolved Hide resolved
Chapybara-jp
Chapybara-jp reviewed Sep 13, 2024
View reviewed changes
src/locales/ja/modifier-type.json Outdated Show resolved Hide resolved
src/locales/ja/modifier-type.json Outdated Show resolved Hide resolved
src/locales/ja/trainer-names.json Outdated Show resolved Hide resolved
src/locales/ja/egg.json Outdated Show resolved Hide resolved
src/locales/ja/trainer-titles.json Outdated Show resolved Hide resolved
@sodaMelon sodaMelon mentioned this pull request Sep 13, 2024
Merged
6 tasks
DanStevensonx
DanStevensonx reviewed Sep 13, 2024
View reviewed changes
Copy link

@DanStevensonx DanStevensonx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected a typo and translated one file to Spanish

src/locales/es/modifier-type.json Outdated Show resolved Hide resolved
src/locales/es/mystery-encounters/absolute-avarice-dialogue.json Outdated Show resolved Hide resolved
DanStevensonx
DanStevensonx reviewed Sep 13, 2024
View reviewed changes
Copy link

@DanStevensonx DanStevensonx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translated to Spanish

src/locales/es/mystery-encounters/an-offer-you-cant-refuse-dialogue.json Outdated Show resolved Hide resolved
src/locales/es/mystery-encounters/berries-abound-dialogue.json Outdated Show resolved Hide resolved
@40chyan
Copy link
Contributor

40chyan commented Sep 14, 2024

please create PR to this branch instead of making hundreds of suggestions, to make sure this PR won't be broken.

DanStevensonx
DanStevensonx reviewed Sep 14, 2024
View reviewed changes
Copy link

@DanStevensonx DanStevensonx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed a few translation things

src/locales/es/mystery-encounter-messages.json Outdated Show resolved Hide resolved
src/locales/es/mystery-encounters/berries-abound-dialogue.json Outdated Show resolved Hide resolved
src/locales/es/mystery-encounters/an-offer-you-cant-refuse-dialogue.json Outdated Show resolved Hide resolved
@Adri1 Adri1 marked this pull request as draft September 23, 2024 17:35
@Adri1 Adri1 marked this pull request as ready for review September 23, 2024 17:50
CodeTappert
CodeTappert previously approved these changes Sep 23, 2024
View reviewed changes
@Adri1 Adri1 mentioned this pull request Sep 23, 2024
Closed
13 tasks
flx-sta
flx-sta approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@flx-sta flx-sta left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll trust the translators on this one

@CodeTappert CodeTappert merged commit f32e10d into pagefaultgames:beta Sep 23, 2024
14 checks passed
@Adri1 Adri1 mentioned this pull request Sep 23, 2024
Draft
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeTappert CodeTappert CodeTappert approved these changes

@flx-sta flx-sta flx-sta approved these changes

@josericardo-fo josericardo-fo josericardo-fo approved these changes

@SangaraSorama SangaraSorama SangaraSorama approved these changes

@EnochG1 EnochG1 Awaiting requested review from EnochG1

@40chyan 40chyan Awaiting requested review from 40chyan

@KimJeongSun KimJeongSun Awaiting requested review from KimJeongSun

@sodaMelon sodaMelon Awaiting requested review from sodaMelon

@DanStevensonx DanStevensonx Awaiting requested review from DanStevensonx

@Chapybara-jp Chapybara-jp Awaiting requested review from Chapybara-jp

@protimita protimita Awaiting requested review from protimita

@returntoice returntoice Awaiting requested review from returntoice

@NicusPulcis NicusPulcis Awaiting requested review from NicusPulcis

Assignees
No one assigned
Labels
Localization Provides or updates translation efforts Mystery Encounter Mystery Encounters and related work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.