Nested and standard component folder structure test#191
Merged
Marc-Andre-Rivet merged 11 commits intodevfrom Apr 22, 2020
Merged
Nested and standard component folder structure test#191Marc-Andre-Rivet merged 11 commits intodevfrom
Marc-Andre-Rivet merged 11 commits intodevfrom
Conversation
2 tasks
| pip install -e git+https://github.com/plotly/dash.git#egg=dash[testing] | ||
| git clone --depth 1 https://github.com/plotly/dash.git dash-main | ||
| cd dash-main && pip install -e .[dev,testing] --progress-bar off && cd .. | ||
| cd dash-main/\@plotly/dash-generator-test-component-nested && npm ci && npm run build && sudo R CMD INSTALL . && cd ../../.. |
Contributor
Author
There was a problem hiding this comment.
Using git clone and local pip install as we now also need to build the test components
| dashr.start_server(app) | ||
|
|
||
| assert dashr.wait_for_element("#standard").text == "Standard" | ||
| assert dashr.wait_for_element("#nested").text == "Nested" No newline at end of file |
Contributor
Author
There was a problem hiding this comment.
Same test as in Python: Both the nested and standard components load as expected.
Contributor
|
LGTM! 💃 |
rpkyle
approved these changes
Apr 22, 2020
rpkyle
added a commit
that referenced
this pull request
May 6, 2020
* Add unit tests for index customization (#176) * Send status code of 1 when unit tests fail (#177) * Support for arbitrary file extensions (#186) * Add assortment of unit tests to Dash for R (#179) * Nested and standard components test (#191) * Support inline clientside callbacks in Dash for R (#140) * Speed up CI, use image from plotly * Update to dash-renderer 1.4.1 Co-authored-by: HammadTheOne <hammadkhan@plotly.com> Co-authored-by: Marc-André Rivet <marc-andre.rivet@plotly.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to plotly/dash#1203, related to original community PR plotly/dash#1125.