-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide support for arbitrary file extensions within Dash for R component libraries #186
Conversation
4f2be45
to
1a21232
Compare
This PR is currently on hold until minor edits are made within Dash related to handling of component library assets, as noted in plotly/dash#1186. |
- test arbitrary extension + snapshots
@@ -37,7 +37,7 @@ jobs: | |||
command: | | |||
python -m venv venv | |||
. venv/bin/activate | |||
git clone --depth 1 https://github.com/plotly/dash.git dash-main | |||
git clone -b 481-arbitrary-extensions --depth 1 https://github.com/plotly/dash.git dash-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Temporary, for (1) the modified standard test component, (2) the modified generator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃
* Add unit tests for index customization (#176) * Send status code of 1 when unit tests fail (#177) * Support for arbitrary file extensions (#186) * Add assortment of unit tests to Dash for R (#179) * Nested and standard components test (#191) * Support inline clientside callbacks in Dash for R (#140) * Speed up CI, use image from plotly * Update to dash-renderer 1.4.1 Co-authored-by: HammadTheOne <hammadkhan@plotly.com> Co-authored-by: Marc-André Rivet <marc-andre.rivet@plotly.com>
This PR proposes to address #185, which implements functionality found in plotly/dash#481. In particular, the internal
get_mimetype
function should now handle both.map
and.js.map
, and usesguess_mimetype
from themime
package for extensions other than.js
,.css
and.map
/.js.map
.This feature will require edits to Dash's package generator; a PR proposing those changes is in process.
If the extension is unknown, Dash for R will assume
application/octet-stream
instead. Other features this PR would provide:_dash-component-suites
handlerresource$type
values via themime
package