Provide support for arbitrary file extensions within Dash for R component libraries #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 16, 2020 21:59
rpkyle
added
enhancement
parity
rpkyle
force-pushed
the
185-arbitrary-extensions
branch
from
4f2be45
to
1a21232
Compare
5 tasks
|
This PR is currently on hold until minor edits are made within Dash related to handling of component library assets, as noted in plotly/dash#1186. |
- test arbitrary extension + snapshots
| @@ -37,7 +37,7 @@ jobs: | |||
| command: | | |||
| python -m venv venv | |||
| . venv/bin/activate | |||
| git clone --depth 1 https://github.com/plotly/dash.git dash-main | |||
| git clone -b 481-arbitrary-extensions --depth 1 https://github.com/plotly/dash.git dash-main | |||
There was a problem hiding this comment.
Temporary, for (1) the modified standard test component, (2) the modified generator
Merged
rpkyle
added a commit
that referenced
this pull request
May 6, 2020
* Add unit tests for index customization (#176) * Send status code of 1 when unit tests fail (#177) * Support for arbitrary file extensions (#186) * Add assortment of unit tests to Dash for R (#179) * Nested and standard components test (#191) * Support inline clientside callbacks in Dash for R (#140) * Speed up CI, use image from plotly * Update to dash-renderer 1.4.1 Co-authored-by: HammadTheOne <hammadkhan@plotly.com> Co-authored-by: Marc-André Rivet <marc-andre.rivet@plotly.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to address #185, which implements functionality found in plotly/dash#481. In particular, the internal
get_mimetypefunction should now handle both.mapand.js.map, and usesguess_mimetypefrom themimepackage for extensions other than.js,.cssand.map/.js.map.This feature will require edits to Dash's package generator; a PR proposing those changes is in process.
If the extension is unknown, Dash for R will assume
application/octet-streaminstead. Other features this PR would provide:_dash-component-suiteshandlerresource$typevalues via themimepackage