Support inline clientside callbacks in Dash for R#140
Merged
Conversation
alexcjohnson
reviewed
Nov 5, 2019
alexcjohnson
reviewed
Nov 5, 2019
alexcjohnson
reviewed
Nov 5, 2019
rpkyle
commented
Nov 5, 2019
rpkyle
force-pushed
the
135-clientside-inline
branch
from
e8012a7 to
ae9395e
Compare
HammadTheOne
reviewed
Apr 8, 2020
alexcjohnson
approved these changes
Apr 8, 2020
Collaborator
alexcjohnson
left a comment
alexcjohnson
left a comment
There was a problem hiding this comment.
Looks great. 💃
Still waiting for that trailing whitespace hook 🙄
This reverts commit ae9395e.
| output('output-clientside', 'children'), | ||
| params=list(input('input', 'value')), | ||
| " | ||
| function (value) { |
added 3 commits
April 21, 2020 20:48
Merged
rpkyle
added a commit
that referenced
this pull request
May 6, 2020
* Add unit tests for index customization (#176) * Send status code of 1 when unit tests fail (#177) * Support for arbitrary file extensions (#186) * Add assortment of unit tests to Dash for R (#179) * Nested and standard components test (#191) * Support inline clientside callbacks in Dash for R (#140) * Speed up CI, use image from plotly * Update to dash-renderer 1.4.1 Co-authored-by: HammadTheOne <hammadkhan@plotly.com> Co-authored-by: Marc-André Rivet <marc-andre.rivet@plotly.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes to allow passing JavaScript-functions-as-strings within callbacks in Dash for R, addressing #135. This implementation fixes the
namespaceas_dashprivate_, and usesoutput$idfor the function name, as in Python.To do:
@Marc-Andre-Rivet @HammadTheOne