Replace remaining rgb Color references with semantic Color assets #1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…; fixes from previous commits
… assets also modified CHNAGELOG to reflect branch changes
# Conflicts: # Nos/Assets/Colors.xcassets/big-action-button-gradient-bottom.colorset/Contents.json
lingoslinger
requested review from
mplorentz,
martindsq and
joshuatbrown
as code owners
lingoslinger
changed the title
…nos into 1375-replace-rgb
martindsq
approved these changes
Aug 19, 2024
|
@lingoslinger Appreciate it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues covered
#1375 (ongoing work)
Description
Replaced remaining rgb Color references with semantically named colors in Colors.xcassets
How to test