Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace remaining rgb Color references with semantic Color assets #1414

Merged
merged 13 commits into from
Aug 20, 2024
Merged

Replace remaining rgb Color references with semantic Color assets #1414

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
013715f
Merge branch 'main' into 1375-replace-white-opacity
lingoslinger Aug 15, 2024
e70c48f
replaced hard coded values in BigActionButton with semantic Color assets
lingoslinger Aug 15, 2024
9ebe6df
replaced hard coded values in BioSheetView with semantic Color assets…
lingoslinger Aug 15, 2024
9d75107
bumped changelog to reflect work done
lingoslinger Aug 15, 2024
2b02d62
replaced hard coded rgb values in ActionBanner with semantic Color as…
lingoslinger Aug 16, 2024
6650acb
replaced hard coded rgb values in BigActionButton with semantic Color…
lingoslinger Aug 16, 2024
93de000
changed name of colorset per PR comments
lingoslinger Aug 16, 2024
686fc9b
CHANGELOG edited per PR comments
lingoslinger Aug 16, 2024
e3b4d32
Merge branch 'main' into 1375-replace-white-opacity
lingoslinger Aug 16, 2024
1e9ef01
removed unnecessary color group
lingoslinger Aug 16, 2024
bd25915
Merge branch '1375-replace-white-opacity' into 1375-replace-rgb
lingoslinger Aug 16, 2024
ba655d7
reverted CHANGELOG per PR comments
lingoslinger Aug 19, 2024
a575737
Merge branch '1375-replace-white-opacity' of github.com:lingoslinger/…
lingoslinger Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
replaced hard coded rgb values in ActionBanner with semantic Color as… 
…sets
  • Loading branch information
@lingoslinger
lingoslinger committed Aug 16, 2024
commit 2b02d62bb9c8bb917e0a3989b642890e8c2ef136
20 changes: 20 additions & 0 deletions Nos/Assets/Colors.xcassets/action-banner-background-gradient-bottom.colorset/Contents.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
{
"colors" : [
{
"color" : {
"color-space" : "srgb",
"components" : {
"alpha" : "1.000",
"blue" : "0xFF",
"green" : "0xFF",
"red" : "0xFF"
}
},
"idiom" : "universal"
}
],
"info" : {
"author" : "xcode",
"version" : 1
}
}
20 changes: 20 additions & 0 deletions Nos/Assets/Colors.xcassets/action-banner-background-gradient-top.colorset/Contents.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
{
"colors" : [
{
"color" : {
"color-space" : "srgb",
"components" : {
"alpha" : "0.200",
"blue" : "0xFF",
"green" : "0xFF",
"red" : "0xFF"
}
},
"idiom" : "universal"
}
],
"info" : {
"author" : "xcode",
"version" : 1
}
}
4 changes: 2 additions & 2 deletions Nos/Views/ActionBanner.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,8 @@ struct ActionBanner: View {
ZStack {
LinearGradient(
colors: [
Color(red: 1, green: 1, blue: 1, opacity: 0.2),
Color(red: 1, green: 1, blue: 1, opacity: 1.0),
Color.actionBannerBackgroundGradientTop,
Color.actionBannerBackgroundGradientBottom,
],
startPoint: .top,
endPoint: .bottom
Expand Down