-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace all Color(hex:) references with Color constants #1375
Comments
I will take this issue as I have already done the work in 1374 to move colors to their own asset catalog. Please assign to me when convenient. |
@lingoslinger thanks! I've assigned it to you. |
Some questions as I begin work on this issue:
|
@lingoslinger the goal is to use semantic naming for the colors -- see the ones that are already there for examples, like |
@setch-l for UAT, we'll just want to make sure the colors are still the same. Let us know if any color in the app seems off. |
SwiftGen generates color constants based on our colors defined in
Colors.xcassets
. We should only use the color constants and never useColor(hex:)
. Let's replace all instances with color constants, and if there are no constants, create new colors inColors.xcassets
. Let's also replace any uses ofColor(red:green:blue:opacity:)
andColor(white:opacity:)
.See #733 for more context (this is essentially a dupe of that).
The text was updated successfully, but these errors were encountered: