Replace remaining Color(white: opacity:) references with semantic Color assets #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lingoslinger
requested review from
mplorentz,
martindsq and
joshuatbrown
as code owners
joshuatbrown
requested changes
Aug 16, 2024
There was a problem hiding this comment.
This is a partial review; I'll do a full one when #1403 is merged so the diff here is smaller. A couple things to change for now.
CHANGELOG.md
Outdated
| @@ -11,7 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| - Removed the like and repost counts from the Main and Profile feeds. | |||
| - Fixed an issue where the sheet asking users to set up a NIP-05 username would appear after reinstalling Nos, even if the profile already had a NIP-05 username. | |||
| - Fixed a bug where urls with periods after them would include the period. | |||
| - Replaced hard-coded color values. | |||
| - Replaced hard-coded hex and white: opacity: color values. | |||
There was a problem hiding this comment.
I think the original is better -- we don't need so much detail in the CHANGELOG.
Suggested change
| - Replaced hard-coded hex and white: opacity: color values. | |
| - Replaced hard-coded color values. |
There was a problem hiding this comment.
Understood, I will change this in the final PR for RGB values.
There was a problem hiding this comment.
Let's change it now and skip the changelog update in the future PRs.
joshuatbrown
requested changes
Aug 19, 2024
CHANGELOG.md
Outdated
| @@ -11,7 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| - Removed the like and repost counts from the Main and Profile feeds. | |||
| - Fixed an issue where the sheet asking users to set up a NIP-05 username would appear after reinstalling Nos, even if the profile already had a NIP-05 username. | |||
| - Fixed a bug where urls with periods after them would include the period. | |||
| - Replaced hard-coded color values. | |||
| - Replaced hard-coded hex and white: opacity: color values. | |||
There was a problem hiding this comment.
Let's change it now and skip the changelog update in the future PRs.
joshuatbrown
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues covered
#1375 (ongoing work)
Description
Replaced remaining Color(white: opacity:) references with semantically named colors in Colors.xcassets
How to test
Notes