Disable tests for aarch64_sysroot config that don't work without full kernel emulation #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… kernel emulation Signed-off-by: James Bartlett <jamesbartlett@pixielabs.ai>
JamesMBartlett
force-pushed
the
disable_full_emu_tests
branch
from
2006383 to
fcb886f
Compare
vihangm
approved these changes
Mar 2, 2023
NickLanam
pushed a commit
to NickLanam/pixie
that referenced
this pull request
Mar 6, 2023
… kernel emulation (pixie-io#941) Summary: Some tests use features that aren't supported by userspace qemu emulation, and will require full qemu kernel emulation to work. This adds a tag that is filtered out by the aarch64_sysroot config, so that these tests never run in userspace qemu emulation. Type of change: /kind test-infra Test Plan: Tested that the tests in question no longer get run by the `aarch64_sysroot` config. Signed-off-by: James Bartlett <jamesbartlett@pixielabs.ai>
RagalahariP
pushed a commit
to RagalahariP/pixie
that referenced
this pull request
Mar 23, 2023
… kernel emulation (pixie-io#941) Summary: Some tests use features that aren't supported by userspace qemu emulation, and will require full qemu kernel emulation to work. This adds a tag that is filtered out by the aarch64_sysroot config, so that these tests never run in userspace qemu emulation. Type of change: /kind test-infra Test Plan: Tested that the tests in question no longer get run by the `aarch64_sysroot` config. Signed-off-by: James Bartlett <jamesbartlett@pixielabs.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Some tests use features that aren't supported by userspace qemu emulation, and will require full qemu kernel emulation to work.
This adds a tag that is filtered out by the aarch64_sysroot config, so that these tests never run in userspace qemu emulation.
Type of change: /kind test-infra
Test Plan: Tested that the tests in question no longer get run by the
aarch64_sysrootconfig.