Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Disable tests for aarch64_sysroot config that don't work without full…
Browse files Browse the repository at this point in the history
… kernel emulation

Signed-off-by: James Bartlett <jamesbartlett@pixielabs.ai>
JamesMBartlett committed Mar 1, 2023
1 parent 4da41d7 commit 2006383
Showing 3 changed files with 11 additions and 1 deletion.
1 change: 1 addition & 0 deletions .bazelrc
Original file line number Diff line number Diff line change
@@ -93,6 +93,7 @@ build:aarch64_sysroot --config=sysroot-base
# Increase test timeouts for qemu (don't increase the slowest ones because those are already very long).
test:aarch64_sysroot --test_timeout=180,600,1800,3600
test:aarch64_sysroot --test_env=QEMU_STRACE
test:aarch64_sysroot --test_tag_filters=-no_libcpp,-requires_root,-requires_bpf,-disabled,-requires_full_qemu_emulation


# Build for Clang using Libc++.
6 changes: 5 additions & 1 deletion src/common/system/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -85,7 +85,11 @@ pl_cc_test(
flaky = 1,
# TODO(oazizi/yzhao): Make this test safe to run with other tests. Right now it relies on global
# network state making it flaky.
tags = ["exclusive"],
tags = [
"exclusive",
# The NETLINK_SOCK_DIAG protocol we use is not supported by userspace QEMU.
"requires_full_qemu_emulation",
],
deps = [
":cc_library",
],
5 changes: 5 additions & 0 deletions src/stirling/utils/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -78,6 +78,11 @@ pl_cc_test(
":cc_library",
"//src/common/system:cc_library",
],
tags = [
# Getting kernel version from VDSO fails because the system VDSO will be used with userspace qemu,
# so we need full qemu emulation to test that for ARM.
"requires_full_qemu_emulation",
],
)

pl_cc_test(

0 comments on commit 2006383

Please sign in to comment.