Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tests for aarch64_sysroot config that don't work without full kernel emulation #941

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Disable tests for aarch64_sysroot config that don't work without full…
… kernel emulation

Signed-off-by: James Bartlett <jamesbartlett@pixielabs.ai>
  • Loading branch information
JamesMBartlett committed Mar 2, 2023
commit fcb886ff53e724344f9ab42d5f19e60d0e4419f1
1 change: 1 addition & 0 deletions .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ build:aarch64_sysroot --config=sysroot-base
# Increase test timeouts for qemu (don't increase the slowest ones because those are already very long).
test:aarch64_sysroot --test_timeout=180,600,1800,3600
test:aarch64_sysroot --test_env=QEMU_STRACE
test:aarch64_sysroot --test_tag_filters=-no_libcpp,-requires_root,-requires_bpf,-disabled,-requires_full_qemu_emulation


# Build for Clang using Libc++.
Expand Down
6 changes: 5 additions & 1 deletion src/common/system/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,11 @@ pl_cc_test(
flaky = 1,
# TODO(oazizi/yzhao): Make this test safe to run with other tests. Right now it relies on global
# network state making it flaky.
tags = ["exclusive"],
tags = [
"exclusive",
# The NETLINK_SOCK_DIAG protocol we use is not supported by userspace QEMU.
"requires_full_qemu_emulation",
],
deps = [
":cc_library",
],
Expand Down
4 changes: 4 additions & 0 deletions src/stirling/source_connectors/jvm_stats/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@ pl_cc_test(
tags = [
"exclusive",
"no_coverage",
# Currently we detect java processes by checking the name of the command run.
# This fails when run under userspace qemu, because the name of the command run is qemu-aarch64-static.
# We should probably fix this, but for now we require full qemu emulation.
"requires_full_qemu_emulation",
],
deps = [
":cc_library",
Expand Down
5 changes: 5 additions & 0 deletions src/stirling/utils/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,11 @@ pl_cc_test(
"testdata/sample_host_ubuntu/**",
"testdata/sample_host_debian/**",
]),
tags = [
# Getting kernel version from VDSO fails because the system VDSO will be used with userspace qemu,
# so we need full qemu emulation to test that for ARM.
"requires_full_qemu_emulation",
],
deps = [
":cc_library",
"//src/common/system:cc_library",
Expand Down