Skip to content

fix(opencode): cancelled todos no longer keep the todo list running - #22938

Merged
t3dotgg merged 1 commit into
pingdotgg:mainfrom
MarcoDotIO:fix/opencode-cancelled-todos
Oct 21, 2026
Merged

t3dotgg merged 1 commit into
pingdotgg:mainfrom
MarcoDotIO:fix/opencode-cancelled-todos

Conversation

@MarcoDotIO

Copy link
Copy Markdown
Contributor

Problem

OpenCode marks a todo it drops as cancelled. Its SDK Todo type lists the statuses as pending, in_progress, completed and cancelled. The OpenCode adapter (packages/provider-opencode/src/server/adapter.ts, emitTodo) turned any status other than completed or in_progress into pending. A cancelled todo therefore looked like work still to do, and a list whose remaining items were all done never completed. The todo node and turn item stayed running and the plan stayed active.

To reproduce, have an OpenCode (1.x) agent write a todo list, finish some items and cancel one. The cancelled item still shows as pending and the list never reaches completed.

Change

emitTodo now drops cancelled todos before building plan steps. The Cursor adapter (cursorTodoSteps) and the Muse adapter (session/todoListChanged) already do this. Step ids still come from each todo's original position, so they stay stable when an earlier item is cancelled. The list counts as completed when OpenCode sent at least one todo and every remaining step is completed. A list where every item was cancelled therefore also completes. An empty todo list behaves as it did before.

Scope and approval

This is a very small fix for an obvious bug: one status mapping in one adapter. The OpenCode SDK lists cancelled as a todo status, plan steps have no cancelled state, and two sibling adapters already drop cancelled todos. There is no UI change and no change to contracts or other providers.

Verification

  • Added drops cancelled OpenCode todos so a finished list completes to packages/provider-opencode/src/server/adapter.test.ts. It pushes a native todo.updated event with items that are completed, cancelled and completed, then checks the projected plan.
    • With the adapter from upstream/main the test fails: AssertionError: expected [ …(3) ] to deeply equal [ …(2) ]. The cancelled item is projected as a pending step.
    • With the fix it passes: Tests 1 passed | 30 skipped (31).
  • node_modules/.bin/vp test run packages/provider-opencode/src/server/adapter.test.ts: 31 passed.
  • tsc-rs --noEmit in packages/provider-opencode exits 0.
  • vp fmt --check packages/provider-opencode/src is clean.
  • vp lint packages/provider-opencode/src shows only two warnings that are also on upstream/main (an unused layer in adapter.ts and no-empty-pattern in OpenCodeRuntime.environment.test.ts).
  • Not checked against a live OpenCode server. The OpenCode 2 adapter is not affected, because it does not project todo lists (emitsTodoList: false).

Claude Opus 5.5 (Claude Code desktop app)

🤖 Generated with Claude Code

OpenCode marks dropped todos "cancelled". The OpenCode adapter mapped
that status to "pending", so a cancelled item looked like outstanding
work and a list whose other items were all done never completed. Drop
cancelled todos, as the Cursor and Muse adapters already do.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Oct 21, 2026
@coderabbitai

coderabbitai Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Path: .coderabbit.config.ts
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 12d36623-6c64-46aa-ab42-a52d45c9fda1
📥 Commits

Reviewing files that changed from the base of the PR and between 680152e and b27bd8b.

📒 Files selected for processing: 2
  • packages/provider-opencode/src/server/adapter.test.ts
  • packages/provider-opencode/src/server/adapter.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.

📝 Walkthrough

The OpenCode adapter now omits cancelled todos from emitted plans. Plan completion is based on the retained steps, while an empty original todo list remains incomplete. An integration test checks the emitted plan.

Changes: OpenCode Todo Projection

Layer / File(s) Summary
Filter and emit todo plans
packages/provider-opencode/src/server/adapter.ts, packages/provider-opencode/src/server/adapter.test.ts
emitTodo excludes cancelled todos and evaluates completion using retained steps. The integration test checks the emitted steps and completed plan status.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to b27bd

The cancelled-todo change is mergeable after normal checks; no actionable risk remains identified.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly identifies the OpenCode fix: cancelled todos no longer keep the todo list running.
Description check Passed The description includes the required Problem, Change, Scope and approval, and Verification sections. It explains the bug, the fix, why prior approval is not required, and the focused test results and…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description includes the required Problem, Change, Scope and approval, and Verification sections. It explains the bug, the fix, why prior approval is not required, and the focused test results and limitations.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@t3dotgg
t3dotgg merged commit 2333f16 into pingdotgg:main Oct 21, 2026
29 checks passed
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Oct 22, 2026
## What's Changed
* docs(agents): proof for a bug fix depends on the bug by @juliusmarminge in pingdotgg/t3code#23008
* fix(server): removing a worktree on Windows no longer deletes what its junctions point to by @SunkenInTime in pingdotgg/t3code#21099
* perf(web): a streaming thread re-renders only its own sidebar row by @juliusmarminge in pingdotgg/t3code#22730
* refactor(web): the add environment dialog owns its form state by @juliusmarminge in pingdotgg/t3code#22686
* fix(desktop): use Clerk's upstream fix for abandoned browser sign-ins by @wobsoriano in pingdotgg/t3code#23038
* feat: show automation messages as compact timeline rows by @juliusmarminge in pingdotgg/t3code#22638
* feat(server,web,mobile): approvals in full access say why Claude asked by @juliusmarminge in pingdotgg/t3code#22546
* feat(claude): idle compaction has a global default and per-instance overrides by @juliusmarminge in pingdotgg/t3code#23037
* perf(web): typing no longer re-renders the traits picker or attach button by @juliusmarminge in pingdotgg/t3code#23040
* refactor(web): the composer's layout and provider hooks live in their own files by @juliusmarminge in pingdotgg/t3code#23042
* refactor(web): the prompt stash lives in useComposerStash by @juliusmarminge in pingdotgg/t3code#23046
* refactor(web): composer context imports live in useComposerContextImport by @juliusmarminge in pingdotgg/t3code#23048
* refactor(web): composer file intake lives in useComposerAttachmentIntake by @juliusmarminge in pingdotgg/t3code#23049
* refactor(web): the composer's footer controls render in ComposerControlsBar by @juliusmarminge in pingdotgg/t3code#23058
* refactor(web): composer key handling lives in useComposerCommandKey by @juliusmarminge in pingdotgg/t3code#23060
* refactor(web): ChatView's send paths live in useComposerSend by @juliusmarminge in pingdotgg/t3code#23062
* refactor(web): ChatView's terminal actions live in useChatTerminalActions by @juliusmarminge in pingdotgg/t3code#23063
* refactor(web): ChatView's right panel actions live in useRightPanelActions by @juliusmarminge in pingdotgg/t3code#23064
* refactor(web): ChatView's snooze, settle, and checkout actions live in useThreadLifecycle by @juliusmarminge in pingdotgg/t3code#23065
* refactor(web): ChatView's revert, rollback, and fork live in useTimelineRewind by @juliusmarminge in pingdotgg/t3code#23066
* refactor(web): ChatView's attachment preview handoff lives in useAttachmentPreviewHandoff by @juliusmarminge in pingdotgg/t3code#23067
* refactor(web): ChatView's project clone banner lives in useProjectCloneBanner by @juliusmarminge in pingdotgg/t3code#23068
* refactor(web): ChatView's model, mode, and workspace choices live in useComposerSelection by @juliusmarminge in pingdotgg/t3code#23069
* refactor(web): ChatView's pull request checkout lives in usePullRequestDraftThread by @juliusmarminge in pingdotgg/t3code#23070
* refactor(web): ChatView's thread derivations are tested functions in ChatView.logic by @juliusmarminge in pingdotgg/t3code#23071
* refactor(web): ChatView's paste-to-focus, titlebar controls, and timeline overlays move out by @juliusmarminge in pingdotgg/t3code#23072
* fix(cursor): a closed-stream write in the Cursor SDK no longer stops the server by @t3dotgg in pingdotgg/t3code#22897
* fix(server): Codex no longer offers a one-click update for installs it can't detect by @koushikxd in pingdotgg/t3code#22504
* fix(pi): declare properties on MCP tool schemas that omit them by @tlconde in pingdotgg/t3code#21822
* fix(server): a desktop backend whose launcher died shuts down cleanly instead of crashing by @SunkenInTime in pingdotgg/t3code#22471
* fix(mobile): chat feed no longer re-derives on every render by @t3dotgg in pingdotgg/t3code#22913
* docs(user): the outside agents guide says which addresses agents can sign in over by @Gourav224 in pingdotgg/t3code#22377
* fix(server): HTML preview reports a browser start error instead of an internal error by @t3dotgg in pingdotgg/t3code#22895
* fix(tailscale): a timed-out tailscale probe no longer outlives its call by @t3dotgg in pingdotgg/t3code#22900
* docs(composer): queued messages follow the Follow-up behavior setting by @t3dotgg in pingdotgg/t3code#22857
* fix(server): failed provider updates say why by @koushikxd in pingdotgg/t3code#22506
* test(telemetry): keep fixture PIDs from colliding with the test worker by @only21mil in pingdotgg/t3code#21446
* fix(server): server tests resolve the macOS temp dir symlink by @nabettu in pingdotgg/t3code#21442
* fix(scripts): mobile lint fails instead of passing when ktlint or detekt is missing by @t3dotgg in pingdotgg/t3code#22896
* fix(server): t3_thread_read clamps oversized page sizes instead of failing by @t3dotgg in pingdotgg/t3code#22901
* fix(mobile): opening a pull request no longer crashes with "Maximum update depth exceeded" by @nabettu in pingdotgg/t3code#22600
* fix(web): PR Code tab keeps its files after a refresh with an unchanged diff by @t3dotgg in pingdotgg/t3code#22917
* fix(web): finished provider updates no longer leave a hidden spinner in the sidebar by @t3dotgg in pingdotgg/t3code#22912
* fix(composer): mentions of files like `posts.$postId.tsx` or `[id].tsx` stay chips by @t3dotgg in pingdotgg/t3code#22922
* refactor(web): resuming an interrupted run lives in its own hook by @juliusmarminge in pingdotgg/t3code#23087
* refactor(web): proposed-plan follow-ups and implement-in-new-thread live in their own hooks by @juliusmarminge in pingdotgg/t3code#23091
* refactor(web): multiple-model sends live in their own hook by @juliusmarminge in pingdotgg/t3code#23094
* refactor(web): the composer send reads its own settings and draft instead of taking them from ChatView by @juliusmarminge in pingdotgg/t3code#23095
* refactor(web): ComposerControlsBar renders without a memo() wrapper by @juliusmarminge in pingdotgg/t3code#23093
* refactor(web): chat shortcuts live with the hooks that own their actions by @juliusmarminge in pingdotgg/t3code#23097
* refactor(web): ChatView's timeline banners render in ChatBannerLane by @juliusmarminge in pingdotgg/t3code#23101
* fix(web): the branch toolbar and thread details panel stay cached while a reply streams by @juliusmarminge in pingdotgg/t3code#23103
* fix(server): scheduled tasks no longer jump to the top when toggled by @t3dotgg in pingdotgg/t3code#22899
* fix(server): Forgejo and GitCafe pull requests link to their threads again by @MarcoDotIO in pingdotgg/t3code#22937
* fix(server): pushes the remote refuses say why instead of a generic failure by @t3dotgg in pingdotgg/t3code#22904
* fix(composer): typing a price no longer opens the skill menu by @MarcoDotIO in pingdotgg/t3code#21519
* fix(web): thread details PR merge uses the last selected merge method by @tris203 in pingdotgg/t3code#22399
* fix(web): a Usage toggle shortcut now goes back instead of staying on Usage by @t3dotgg in pingdotgg/t3code#22905
* fix(web): quote comment box stays on screen for long code lines by @EtanHey in pingdotgg/t3code#22149
* fix(web): right panel launcher letters open their surface instead of typing into the composer by @t3dotgg in pingdotgg/t3code#22898
* fix(web): ../ file links outside the workspace open as host files by @t3dotgg in pingdotgg/t3code#22853
* fix(shared): recognize relative folder links with trailing slash by @macodev00 in pingdotgg/t3code#22188
* fix(client): usage limits skip disabled connections by @M4NU5 in pingdotgg/t3code#22936
* fix(web): imported VS Code themes keep destructive buttons red by @lgollut in pingdotgg/t3code#21924
* fix(shared): Azure DevOps repositories with a space in the name list their pull requests by @Tabonx in pingdotgg/t3code#22782
* fix(opencode): cancelled todos no longer keep the todo list running by @MarcoDotIO in pingdotgg/t3code#22938
* fix(web): copy to machine clones the fork, not its upstream by @AKolenda in pingdotgg/t3code#22492
* fix(server): JetBrains IDEs open file links at the right column by @levochkaa in pingdotgg/t3code#22826
* fix(server): sync pull request draft status changes by @Yash-Singh1 in pingdotgg/t3code#22832
* test(web): chat shortcut test types through the composer handle by @juliusmarminge in pingdotgg/t3code#23126
* fix(source-control): merge messages drop Claude Code's current claude.com footer by @MarcoDotIO in pingdotgg/t3code#23133

## New Contributors
* @Gourav224 made their first contribution in pingdotgg/t3code#22377
* @nabettu made their first contribution in pingdotgg/t3code#21442
* @MarcoDotIO made their first contribution in pingdotgg/t3code#22937
* @M4NU5 made their first contribution in pingdotgg/t3code#22936
* @lgollut made their first contribution in pingdotgg/t3code#21924
* @Tabonx made their first contribution in pingdotgg/t3code#22782
* @levochkaa made their first contribution in pingdotgg/t3code#22826

**Full Changelog**: pingdotgg/t3code@v0.1.2-nightly.20261021.3486...v0.1.2-nightly.20261021.3499

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.1.2-nightly.20261021.3499
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants