Skip to content

feat(web): model options for source control writer and review guide models - #18488

Merged
juliusmarminge merged 1 commit into
mainfrom
t3code/writer-model-options
Oct 12, 2026
Merged

feat(web): model options for source control writer and review guide models#18488
juliusmarminge merged 1 commit into
mainfrom
t3code/writer-model-options

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Oct 12, 2026 •
edited by devin-ai-integration Bot
Loading

Copy link
Copy Markdown
Member

The source control writer model and review guide model settings only let you pick a model, not its options (reasoning effort, fast mode, etc.), even though both selections already carry options and the server passes them through.

Adds the same TraitsPicker the text generation model row uses next to both pickers. It writes options back into sourceControlWriterModelSelection / reviewGuideModelSelection and is hidden when the selection is mixed across targets. No contract or server changes.

Opus 5.5 via Claude Code in T3 Code

🤖 Generated with Claude Code

Devin Review

@juliusmarminge @claude
feat(web): model options for source control writer and review guide m…
199a13d 
…odels

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Oct 12, 2026
@juliusmarminge juliusmarminge added the macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews label Oct 12, 2026
@juliusmarminge
juliusmarminge enabled auto-merge (squash) October 12, 2026 03:44
@macroscopeapp

macroscopeapp Bot commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 199a13d

Macroscope's review found this PR approvable — Adds small, opt-in model-option controls to existing source-control writer and review-guide settings while preserving defaults and all existing non-dedicated paths. The options use existing persistence and server behavior, with no schema, deployment, security, billing, or static-analysis changes.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge merged commit e688034 into main Oct 12, 2026
32 of 34 checks passed
@juliusmarminge
juliusmarminge deleted the t3code/writer-model-options branch October 12, 2026 03:46
@github-actions

github-actions Bot commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 5.0 KiB 5.0 KiB 0 B (0.0%) 6.8 KiB ✅
Codex Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Codex Live turn WebSocket wire 1.2 KiB 1.2 KiB 0 B (0.0%) 2.0 KiB ✅
Codex Live turn WebSocket decoded 20.9 KiB 20.9 KiB 0 B (0.0%) 29.3 KiB ✅
Codex Live turn messages 2 2 0 (0.0%) 8 ✅
Claude Total thread wire 5.0 KiB 5.0 KiB +24 B (+0.5%) 6.8 KiB ✅
Claude Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Claude Live turn WebSocket wire 1.2 KiB 1.2 KiB +24 B (+2.0%) 2.0 KiB ✅
Claude Live turn WebSocket decoded 21.2 KiB 21.2 KiB +41 B (+0.2%) 29.3 KiB ✅
Claude Live turn messages 1 2 +1 (+100.0%) 8 ✅

Baseline: 4ab4cdf · PR result: 199a13d · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

aorwall added a commit to aorwall/t3code that referenced this pull request Oct 12, 2026
@aorwall
chore: merge upstream t3code to e688034 (pingdotgg#225)
0bcb48b 
Merges upstream `pingdotgg/t3code` `e688034b5f` (223 commits, base
`aacefcd7e9`) into the fork. No merge PR was open, so this branches from
`main`.

## Resolution
- 9 conflicts, each resolved by its `preflight.mjs` verdict. The tracker
entry in `docs/fork/upstream-merge-log.md` lists them. `AGENTS.md` kept
the fork copy because upstream only changed a user count in a section
the fork drops. `nativeMarkdownText.test.ts` takes upstream's deletion.
The rest combine both sides.
- The lockfile is upstream's copy, re-derived by install.
- Landed 1226 files against 1226 in the upstream range; the gap is
explained in the tracker.
- **Fork-side fix in `apps/server/src/server.ts`**: when `Ws.layer` was
first inferred inside `layerMakeRoutes`, its requirements widened to
`any`. That failed typecheck across `binCli.ts`, `cli/server.ts`,
`server.ts` and the cli tests, and it was the `TS377030` failure the
2026-10-10 merge had blamed on upstream. Moving it to its own statement
after the imports fixes it. The fix is recorded as inventory entry
`server-ws-layer-hoist`, and the gap entry is struck.
- `UnsupportedMethodError` was added to `filesystem.getMetadata`,
`orchestration.stopWorkflow` and `server.checkOtlpEndpoint`; nothing was
dropped.
- Three stale `duplicateAddExceptions` were removed.

## Verification
`verify.mjs` passed duplicate-adds, tripwires, resolution-check,
unsupported-methods, lockfile, fmt, lint, typecheck and build. `test`
failed on 5 files, each confirmed failing when run alone:
- The same four as 2026-10-10: `ServerBrowserPage`, `AcpAdapterV2`,
`OrchestratorReplayFixtures` and `OpenCodeServerLedger`.
- New: `@t3tools/shared` `AgentScope.test.ts`. It expects
`oom_score_adj` 800, but sandbox processes inherit 935, and an
unprivileged process cannot lower it. This is the sandbox, not the code.

## Usable as-is
- Drag to reorder right-panel tabs (pingdotgg#17730). A maximized panel now stays
maximized per thread, and there are other layout fixes.
- Claude workflow phases and members show in Lineage (pingdotgg#12598).
- Threads can be found by a branch's PR number (pingdotgg#14658), and no-project
filters are merged across environments (pingdotgg#17050).
- Cmd-F focuses settings search, and update settings appear in the
command palette.
- Resume continues on the composer's model (pingdotgg#17867), and queued threads
stay subscribed (pingdotgg#15293).
- Fixes to the timeline, minimap, composer, context menus and markdown
performance.
- Desktop and mobile features, which the fork does not ship.

## Unsupported in Moatless / needs implementation
- **Guided PR reviews** (pingdotgg#18124, pingdotgg#18143): `pullRequests.reviewGuide`,
`generateReviewGuide` and `reportState`, behind the Guide tab. Already
hidden by the PR capability and `FEATURES.pullRequestSurface`.
- **`orchestration.stopWorkflow`** (pingdotgg#17826): the Stop button for Claude
subagents in `ThreadRelationshipsControl.tsx`. It has no fork gate and
renders only for threads that carry workflow members.
- **`filesystem.getMetadata`** (pingdotgg#17923): server-derived file-chip icons.
When the call is refused, chips keep their extension icons.
- **`server.checkOtlpEndpoint`** and the OTLP export settings (pingdotgg#12538).
Already behind `FEATURES.diagnostics`.
- These all save through `server.updateSettings` or `projects.mutate`,
and the existing settings gates already hide them:
  - source-control host settings and the GitCafe token (pingdotgg#17901, pingdotgg#17746);
  - writer and review-guide model settings (pingdotgg#18488);
  - per-project provider enablement (pingdotgg#17879);
  - synced model favorites (pingdotgg#16816);
  - publish to any host and new-project folder (pingdotgg#17860, pingdotgg#17371).

## Backend behavior to consider reproducing in Moatless
- **Project settings overrides**: they gain `providerInstances` and
review-guide keys, and a sweep clears the overrides of deleted projects
(pingdotgg#17879).
- **Automatic thread continuations**: on by default and capped at three
in a row (pingdotgg#18461).
- **Agent isolation**: each agent runs in its own systemd scope with a
raised OOM score, so an OOM kill spares the server (pingdotgg#17662).
- **PR sweep and settlement fixes**:
  - linked PRs refresh without a checkout (pingdotgg#17167);
  - forks are detected for branches without upstreams (pingdotgg#13894);
- PR watch no longer reports passed while a re-run check is still going
(pingdotgg#17344);
  - thread PR badges catch up across environments (pingdotgg#17729);
  - the reason a thread can't be settled is now stated (pingdotgg#17258).
- **Worktree threads**: they keep their worktree when the agent starts,
and messages sent during setup queue (pingdotgg#17654). `t3_thread_launch` also
refuses a base ref with no commit (pingdotgg#17791).
- **Provider fixes**: a missing agent binary reports a launch failure,
and Claude 5.1+ text before a tool call shows as assistant text
(pingdotgg#18364).

## After merge
- Disable the new upstream workflow: `gh workflow disable
mobile-android-apk.yml --repo soaplabs/t3code`.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---
Moatless task:
https://moatless.soaplabstest.com/tasks/0c7fbce8-cdd5-426e-afb0-037def1ac545
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@macroscopeapp macroscopeapp[bot] macroscopeapp[bot] approved these changes

Assignees

No one assigned

Labels

macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge