Repository navigation
feat(mobile): redesign the Add environment sheet - #17092
Conversation
Scan-first layout: a frosted live camera card with a sharp reticle cutout, inline Address/Code fields with the pairing error shown in place, a header checkmark that spins while connecting, haptics on success/failure, and a T3 Connect section that lists account environments or offers sign-in. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This PR substantially redesigns the production Add environment workflow, adding QR scanning, native platform UI, authentication-aware managed relay behavior, and shared header infrastructure changes. Its new runtime paths and required native rebuild create a broader review surface than a routine UI-only change. You can add or adjust custom eligibility rules. Learn more. |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Brings in 77 upstream commits through pingdotgg#17092. - WelcomeWizard.tsx: kept Cody's CodyMark/APP_BASE_NAME imports beside upstream's saved cloud connection import. - MessagesTimeline.logic.ts: kept the fork's turn-answer imports beside upstream's assistant citation imports; the wrap-up answer and upstream's live subagent cards both feed the fold. - mobile threadActivity.test.ts: kept both the wrap-up answer test and upstream's live subagent test. - Adapted: Cody's t3 launcher (upstream pingdotgg#16676/pingdotgg#16683) carries a Cody marker, so Settings > Install t3 command in Cody never repoints or removes official T3 Code's t3 link. Covered by DesktopCliCommand.test.ts, now in personal-fixes. - DesktopBackendConfiguration.test.ts: clear an inherited T3CODE_WINDOWS_SSO_HELPER so the WSL sign-in test is hermetic on a Cody backend. - Superseded: none this round. Unaffected after review: sparse checkouts, worktree base refs, Azure DevOps, Windows work-account sign-in (desktop and server browser), auto-install updates, turn answers, OpenCode usage.
## What's Changed * chore(review): remove the custom Approvability check by @esthor in pingdotgg/t3code#17018 * perf(mobile): show the cached thread list sooner and stop the freeze after it by @juliusmarminge in pingdotgg/t3code#16713 * fix(server): replaying a command no longer freezes the server by @SunkenInTime in pingdotgg/t3code#17041 * fix(server): opening a long thread no longer blocks the server for a second by @SunkenInTime in pingdotgg/t3code#17029 * fix(server,web,mobile): thread links reference the thread id, not a baked title by @juliusmarminge in pingdotgg/t3code#17017 * fix(web): messages with quotes or links no longer collapse when short by @flamboh in pingdotgg/t3code#16624 * refactor(web): PR loading skeleton shares the detail panel's layout by @flamboh in pingdotgg/t3code#15583 * fix(web): PR file headers keep the file name in narrow panels by @flamboh in pingdotgg/t3code#15562 * fix(web): PR timeline no longer shifts when its scrollbar appears by @flamboh in pingdotgg/t3code#15588 * fix(server): held queued wakes no longer keep delegated tasks running by @juliusmarminge in pingdotgg/t3code#17028 * fix(server): a message sent during a rollback no longer undoes it by @t3dotgg in pingdotgg/t3code#17079 * fix(web): PR file stats ignore the hide-whitespace toggle by @flamboh in pingdotgg/t3code#16162 * perf(mobile): omit duplicated turn items from bounded thread snapshots by @juliusmarminge in pingdotgg/t3code#15385 * perf(mobile): pause elapsed-time timers on hidden thread screens by @juliusmarminge in pingdotgg/t3code#15397 * fix(mobile): pause hidden home thread list updates by @juliusmarminge in pingdotgg/t3code#15705 * fix(mobile): restore file viewer insets and glass header by @juliusmarminge in pingdotgg/t3code#17073 * fix(web): PR code toolbar no longer overlaps in narrow panels by @flamboh in pingdotgg/t3code#15561 * fix(web): PR commit menu no longer stretches across the window by @flamboh in pingdotgg/t3code#15560 * fix(web): command palette scrollbar no longer clipped at the top by @flamboh in pingdotgg/t3code#17035 * fix(web): Usage breadcrumb stays centered on small viewports by @flamboh in pingdotgg/t3code#15552 * fix(mobile): stop refreshing Git status on streamed thread updates by @juliusmarminge in pingdotgg/t3code#15893 * fix(mobile): skip move indexes for empty and single-thread sections by @juliusmarminge in pingdotgg/t3code#16115 * perf(mobile): reuse encoded rows in shell cache saves by @juliusmarminge in pingdotgg/t3code#16129 * perf(mobile): skip showcase subscriptions in normal builds by @juliusmarminge in pingdotgg/t3code#16131 * perf(mobile): remove unused Home project sorting by @juliusmarminge in pingdotgg/t3code#16177 * perf(mobile): reduce move-menu index allocations by @juliusmarminge in pingdotgg/t3code#16256 * perf(mobile): skip impossible thread-key lookups by @juliusmarminge in pingdotgg/t3code#16263 * fix(mobile): collect UI runtime garbage on iOS memory warnings by @juliusmarminge in pingdotgg/t3code#16296 * fix(mobile): stop Git sheet refresh loop by @juliusmarminge in pingdotgg/t3code#16305 * fix(mobile): refresh Git status after reconnect by @juliusmarminge in pingdotgg/t3code#16329 * fix(mobile): update the iOS Git header menu when status changes by @juliusmarminge in pingdotgg/t3code#16330 * perf(mobile): reuse the settled sort when settled rows are unchanged by @juliusmarminge in pingdotgg/t3code#16369 * perf(mobile): highlight source files in small batches that keep grammar state by @juliusmarminge in pingdotgg/t3code#16729 * feat(web): quote chips show what you said about the quote by @flamboh in pingdotgg/t3code#15703 * feat(web): projectless threads show their machine in the sidebar by @flamboh in pingdotgg/t3code#17022 * fix(lineage): keep agent effort and speed after completion by @Bil0000 in pingdotgg/t3code#16925 * fix(mobile): align diff scrolling with glass headers by @juliusmarminge in pingdotgg/t3code#17085 * fix(web): workspace page headers can no longer grow past the top-bar height by @maria-rcks in pingdotgg/t3code#17086 * feat(mobile): redesign the Add environment sheet by @juliusmarminge in pingdotgg/t3code#17092 **Full Changelog**: pingdotgg/t3code@v0.0.46-nightly.20261008.2801...v0.0.46-nightly.20261008.2813 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.46-nightly.20261008.2813
## What's Changed * chore(review): remove the custom Approvability check by @esthor in pingdotgg/t3code#17018 * perf(mobile): show the cached thread list sooner and stop the freeze after it by @juliusmarminge in pingdotgg/t3code#16713 * fix(server): replaying a command no longer freezes the server by @SunkenInTime in pingdotgg/t3code#17041 * fix(server): opening a long thread no longer blocks the server for a second by @SunkenInTime in pingdotgg/t3code#17029 * fix(server,web,mobile): thread links reference the thread id, not a baked title by @juliusmarminge in pingdotgg/t3code#17017 * fix(web): messages with quotes or links no longer collapse when short by @flamboh in pingdotgg/t3code#16624 * refactor(web): PR loading skeleton shares the detail panel's layout by @flamboh in pingdotgg/t3code#15583 * fix(web): PR file headers keep the file name in narrow panels by @flamboh in pingdotgg/t3code#15562 * fix(web): PR timeline no longer shifts when its scrollbar appears by @flamboh in pingdotgg/t3code#15588 * fix(server): held queued wakes no longer keep delegated tasks running by @juliusmarminge in pingdotgg/t3code#17028 * fix(server): a message sent during a rollback no longer undoes it by @t3dotgg in pingdotgg/t3code#17079 * fix(web): PR file stats ignore the hide-whitespace toggle by @flamboh in pingdotgg/t3code#16162 * perf(mobile): omit duplicated turn items from bounded thread snapshots by @juliusmarminge in pingdotgg/t3code#15385 * perf(mobile): pause elapsed-time timers on hidden thread screens by @juliusmarminge in pingdotgg/t3code#15397 * fix(mobile): pause hidden home thread list updates by @juliusmarminge in pingdotgg/t3code#15705 * fix(mobile): restore file viewer insets and glass header by @juliusmarminge in pingdotgg/t3code#17073 * fix(web): PR code toolbar no longer overlaps in narrow panels by @flamboh in pingdotgg/t3code#15561 * fix(web): PR commit menu no longer stretches across the window by @flamboh in pingdotgg/t3code#15560 * fix(web): command palette scrollbar no longer clipped at the top by @flamboh in pingdotgg/t3code#17035 * fix(web): Usage breadcrumb stays centered on small viewports by @flamboh in pingdotgg/t3code#15552 * fix(mobile): stop refreshing Git status on streamed thread updates by @juliusmarminge in pingdotgg/t3code#15893 * fix(mobile): skip move indexes for empty and single-thread sections by @juliusmarminge in pingdotgg/t3code#16115 * perf(mobile): reuse encoded rows in shell cache saves by @juliusmarminge in pingdotgg/t3code#16129 * perf(mobile): skip showcase subscriptions in normal builds by @juliusmarminge in pingdotgg/t3code#16131 * perf(mobile): remove unused Home project sorting by @juliusmarminge in pingdotgg/t3code#16177 * perf(mobile): reduce move-menu index allocations by @juliusmarminge in pingdotgg/t3code#16256 * perf(mobile): skip impossible thread-key lookups by @juliusmarminge in pingdotgg/t3code#16263 * fix(mobile): collect UI runtime garbage on iOS memory warnings by @juliusmarminge in pingdotgg/t3code#16296 * fix(mobile): stop Git sheet refresh loop by @juliusmarminge in pingdotgg/t3code#16305 * fix(mobile): refresh Git status after reconnect by @juliusmarminge in pingdotgg/t3code#16329 * fix(mobile): update the iOS Git header menu when status changes by @juliusmarminge in pingdotgg/t3code#16330 * perf(mobile): reuse the settled sort when settled rows are unchanged by @juliusmarminge in pingdotgg/t3code#16369 * perf(mobile): highlight source files in small batches that keep grammar state by @juliusmarminge in pingdotgg/t3code#16729 * feat(web): quote chips show what you said about the quote by @flamboh in pingdotgg/t3code#15703 * feat(web): projectless threads show their machine in the sidebar by @flamboh in pingdotgg/t3code#17022 * fix(lineage): keep agent effort and speed after completion by @Bil0000 in pingdotgg/t3code#16925 * fix(mobile): align diff scrolling with glass headers by @juliusmarminge in pingdotgg/t3code#17085 * fix(web): workspace page headers can no longer grow past the top-bar height by @maria-rcks in pingdotgg/t3code#17086 * feat(mobile): redesign the Add environment sheet by @juliusmarminge in pingdotgg/t3code#17092 **Full Changelog**: pingdotgg/t3code@v0.0.46-nightly.20261008.2801...v0.0.46-nightly.20261008.2813 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.46-nightly.20261008.2813
The mobile Add environment sheet was a plain form with a hidden QR toggle in the header, and connecting gave no feedback until it finished or an error banner pushed the layout around.
What changed
T3FrostedCutoutViewint3-native-controls) that follows the app's light/dark theme. Android uses a tinted SVG cutout instead.loadingflag (iOS via a newNativeHeaderToolbar.Customitem, Android inAndroidScreenHeader). Success and failure trigger haptics.CloudEnvironmentRowswhen signed in and shows a sign-in row otherwise. Manual pairing copy now targets local network and Tailscale only.ConnectionSheetButton.Requires a native rebuild (new iOS view). Verified on device by @juliusmarminge.
Done with Claude Opus 5.5 in Claude Code.
🤖 Generated with Claude Code