Skip to content

Conversation

@Lloyd-Pottiger
Copy link
Contributor

What problem does this PR solve?

close #xxx

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

dveeden and others added 28 commits July 24, 2025 10:51
* Telemetry removal

* Remove left over teleCommand
* env: clean up old code

Signed-off-by: xhe <xw897002528@gmail.com>

* repo: leverage all apis into v1_repository

Signed-off-by: xhe <xw897002528@gmail.com>

* repo: abstract it as an interface

Signed-off-by: xhe <xw897002528@gmail.com>

* clean the remained part

Signed-off-by: xhe <xw897002528@gmail.com>

* rename to LocalComponentInstalled

Signed-off-by: xhe <xw897002528@gmail.com>

* update

Signed-off-by: xhe <xw897002528@gmail.com>

* try fix

Signed-off-by: xhe <xw897002528@gmail.com>

* g

Signed-off-by: xhe <xw897002528@gmail.com>

* try fix

Signed-off-by: xhe <xw897002528@gmail.com>

* g

Signed-off-by: xhe <xw897002528@gmail.com>

* g

Signed-off-by: xhe <xw897002528@gmail.com>

* g

Signed-off-by: xhe <xw897002528@gmail.com>

---------

Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
* cluster: improve SELinux compatibility

* fixup
* Update --ssh desc

* Update components/cluster/command/root.go

---------

Co-authored-by: xhe <xw897002528@gmail.com>
* Move insight to tiup

* Fix linting issues

* Fix unused/gocritic/staticcheck issues
* check_to_require: cluster

* Restore TestCountDirMultiPath

---------

Co-authored-by: xhe <xw897002528@gmail.com>
* Update dmpb

* Remove dm grpc gw
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
* ci: fix STAGING version competition

* ci: replace slashes with dots in branch name for STAGING_VER

* Apply suggestion from @wuhuizuo
* add tici component in playground

* fix: resolve lint errors in tici.go

- Add comments for exported constants TiCIRoleMeta and TiCIRoleWorker
- Remove extra empty line in NewTiCIInstanceWithRole function
- Replace interface{} with any for Go 1.18+ compatibility

* fix: update golangci-lint config for v2 and Makefile

- Add version: 2 to golangci.yaml for golangci-lint v2 compatibility
- Remove typecheck from enabled linters (not a linter in v2)
- Update Makefile to use golangci-lint v2.1.6 (latest)

* fix: add comment to clarify executor mock setup in test

- Add explanatory comment to TestCheckConfig method
- This helps understand the purpose of the mock setup for better test readability

* fix compile error

* revert makefile

* modify the sleep time and adjust the cdc server

* Update components/playground/instance/tici.go

---------

Co-authored-by: xhe <xw897002528@gmail.com>
…cap#2567)

* Update the default config filename

Signed-off-by: JaySon-Huang <tshent@qq.com>

* Update default port

Signed-off-by: JaySon-Huang <tshent@qq.com>

---------

Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
…ingcap#2573)

* tici: refine config path

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>

* fix

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>

* fix

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>

* fix

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>

---------

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
)

* playground: make the tici changefeed endpoint configurable

* address comments
…-defined binarys or configurations (pingcap#2583)

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@ti-chi-bot ti-chi-bot bot requested review from breezewish and kaaaaaaang August 14, 2025 07:47
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 14, 2025
Lloyd-Pottiger and others added 3 commits August 14, 2025 15:50
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 14, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 14, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-08-14 07:57:50.319018337 +0000 UTC m=+513469.353601566: ☑️ agreed by xhebox.

@xhebox xhebox merged commit a2e2751 into pingcap:feature/fts Aug 14, 2025
6 of 7 checks passed
@Lloyd-Pottiger Lloyd-Pottiger deleted the rebase-master branch August 14, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants